Get HOST by Address improvement?

halojoy

Hello. halojoy here

I have this little script I wrote for my brother's website.
It gives visitor info about IP-address and Host.

yourip.php:

<?php

echo '<body bgcolor="#666666" topmargin="100" leftmargin="75">
<table bgcolor="#cccccc" cellspacing="5" cellpadding="0">
<tr>
<td align="center"><b>Your Present IP-Adress is:<br><font color="blue">'.$_SERVER['REMOTE_ADDR'].'</font></b></td></tr>
<tr>
<td align="center"><b>Your Host Name is:<br><font color="blue">'.gethostbyaddr($_SERVER['REMOTE_ADDR']).'</font></b></td>
</tr></table>
</body>';

?>

I have a feeling there are situations, where this script wont work.
Can I add something to improve this, make sure it ALWAYS work?

Here is a demo of present script:
http://213.100.118.115/phpextra/yourip.php

halojoy

🆒

this time I was lucky ....

this script is probably perfect
otherwise people would have banged me on my head
telling me rewrite all that crap

thanks folk, now I have no worry for my brother, using my script

🆒

nicknax

<?php 
 if (getenv(HTTP_X_FORWARDED_FOR)) {							
    $ip = getenv(HTTP_X_FORWARDED_FOR); 
} else { 
    $ip = getenv(REMOTE_ADDR);
}
echo '<body bgcolor="#666666" topmargin="100" leftmargin="75"> 
<table bgcolor="#cccccc" cellspacing="5" cellpadding="0"> 
<tr> 
<td align="center"><b>Your Present IP-Adress is:<br><font color="blue">'.$ip.'</font></b></td></tr> 
<tr> 
<td align="center"><b>Your Host Name is:<br><font color="blue">'.gethostbyaddr($ip).'</font></b></td> 
</tr></table> 
</body>'; 

?>

Gets REAL ip if the user is behind a proxy.

halojoy

I had this feeling it could be improved.
Now I know!

thanks, nicknax
🙂

nicknax

no probs. I'll look into improving at a little bit more later. (yep, still room for improvements) Keep getting parse errors now! 🙁

halojoy

It's possible for a HTTP client to spoof HTTP_X_FORWARDED_FOR,
and set it to a fake IP number.

It's more secure to use this code and log BOTH the ip and the proxy ip.

if ($_SERVER["HTTP_X_FORWARDED_FOR"]) {
   if ($_SERVER["HTTP_CLIENT_IP"]) {
   $proxy = $_SERVER["HTTP_CLIENT_IP"];
  } else {
   $proxy = $_SERVER["REMOTE_ADDR"];
  }
  $ip = $_SERVER["HTTP_X_FORWARDED_FOR"];
} else {
  if ($_SERVER["HTTP_CLIENT_IP"]) {
   $ip = $_SERVER["HTTP_CLIENT_IP"];
  } else {
   $ip = $_SERVER["REMOTE_ADDR"];
  }
}

echo "Your IP $ip<BR>\n";
if (isset($proxy)) {
  echo "Your proxy IP is $proxy<BR>\n";
}

Web Reference:
http://php.net/variables.predefined

Drakla

This goes through whatever's thrown at you in the order most likely to get the real IP of the user

function get_user_ip()
{
	$ipRoutes = array 
	(
		'HTTP_CLIENT_IP',
		'HTTP_X_FORWARDED_FOR',
		'HTTP_X_FORWARDED', 
		'HTTP_FORWARDED_FOR', 
		'HTTP_FORWARDED',
        'HTTP_VIA', 
		'HTTP_X_COMING_FROM',
		'HTTP_COMING_FROM',
		'REMOTE_ADDR',
	);

foreach ($ipRoutes as $route)
{	if (!empty($_SERVER[$route]))
	{
		$is_ip = ereg('^([0-9]{1,3}.){3,3}[0-9]{1,3}', $_SERVER[$route], $regs);

        if ($is_ip && (count($regs) > 0))
            return $regs[0];
	}
}

return '0.0.0.0';
}

halojoy

sorry Drakla

All other scripts in this topic works.
As my in first post, etc etc.
They return my IP number when run at my server.

Your function looks good.
So I want to use it.
Why doesn't your function get_user_ip() return something?

Value is nothing.
not even '0.0.0.0' 😃

How I use your function:

<?php

$ip = get_user_ip();
echo 'Your IP is: ';$ip;
echo'<br><br>welcome back';
exit;

halojoy

If Drakla or other clever
like Weedpacket
can not tell me what is wrong with this function above
I guess nobody can, at this phpbuilder forum 🙁

my own thinking is something is not right
in these two lines:

            $is_ip = ereg('^([0-9]{1,3}.){3,3}[0-9]{1,3}', $_SERVER[$route], $regs);

        if ($is_ip && (count($regs) > 0))
            return $regs[0];

this is why I get no Return Value

Kudose

Anyone every figure this out?