PHP Interfering where it shouldnt be

Strikebf

I'm creating a member system for my site, and in the login page, PHP says:

Parse error: parse error, unexpected $ in /usr/export/www/hosting/strikebf/Zanapets/login.php on line 153

But in my script, the PHP tags close on line 104. And on line 153, I have </html>

How can I fix this?

drew010

it most likely means you are missing a closing } somewhere inside the php code before you close the ?> tag and when it reaches the end of the file its still expecting a } but its not there so it returns an error.

Strikebf

But I already have a } closing the IF/Else statement. And I just made sure that all of the semi-colons were there.

Any other suggestions?

drew010

something is missing that should be there then. if you want you can post the code to the page.

Strikebf

Okay, ill post the last else statement:

} else {

echo ('Sorry, we couldnt log you on. Your account may not be active. Please check your email for the activation code. Or, <a href="resend.php">click here</a> to resend the activation code.<br><br>Or, the information you just put in is wrong. <a href="login.php">Click here</a> to go back and try again.');
}
?>

drew010

what about the whole page.

Installer

You are missing a closing curly brace somewhere. Period.

Strikebf

Sorry, it wont let me post the whole page. It's way too long.

kburger

Attach it. Or remove the huge blocks of HTML from it. You've definitely left something off, as Installer and drew010 have said.

Strikebf

Here's the whole page with some edits so it would fit:

<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<title>Zanapets ~ Home</title>
<script language="JavaScript" type="text/JavaScript">

</script>
<style type="text/css">

</style></head>

  <td width="152" height="55" bgcolor="#0F3711"><form method="post" action="login.php">
    <p align="center">Username:<br>
      <input name="username" type="text" id="username">
      Password:
      <input name="password" type="password" id="password">
      <input type="submit" name="Submit" value="Submit">
    </p>
  </form>
  </td>

  <td width="450"><img src="images/tlogo.png" width="450" height="120"></td>
  <td width="160"><div align="center">
  <?
  include 'config.php';
  session_start();

if($_SESSION['s_logged_n'] == 'true'){
$query="SELECT * FROM Users";
$result=mysql_query($query);
$num=mysql_numrows($result);

$i=0;
while ($i < $num) {

$current_zg=mysql_result($result,$i,"ZG");
$current_username=mysql_result($result,$i,"Username");

$i++;
}
echo ('Username:');
echo($current_username);
echo('ZanaGold:');
echo($current_zg);
echo('Current Pet:');
} else {
echo ('You cannot access this information unless you are logged in. <a href="login.php">Click here</a> to login.');
}?>
</div></td>

</tr>
<tr>
  <td height="289" colspan="2">
    <div align="center">Login to your Zanapets account<br>
      <?php

session_start();
include 'config.php';

if(isset($_POST['login']))
{

$username = trim(addslashes($POST['username']));
$password = md5(trim($POST['password']));

$query = mysql_query("SELECT * FROM Users WHERE Username = '$username' AND Password = '$password' LIMIT 1") or die(mysql_error());

$row = mysql_fetch_array($query);

// now we check if they are activated

if(mysql_num_rows($query) > 0)
{

if($row['Activated'] > 0)
{

$SESSION['s_logged_n'] = 'true';
$SESSION['s_username'] = $username;
$_SESSION['s_name'] = $row['Name'];

header("Location: member.php");

} else {

      <br>
      <br>
      <br>
      <br>
      <br>
      <br>
      <br>
      <br>
      <br>
      <br>
      <br>
      <br>
      <br>
      <br>
      <br>
      <br>
      <br>
      <br>
      <br>
      <br>
      </div>
  </td>

  <td><div align="center">
      <p><a href="index.php"><font color="#FFFFFF">Home</font></a></p>
      <p><a href="login.php">Login</a></p>
      <p><a href="logout.php">Logout</a></p>
      <p><a href="member.php">ZanaCentral</a></p>
    <p>Worlds</p>

    <p>Shops</p>
    <p>Search</p>
    <p>Games</p>
    <p>Boards</p>
      <p><a href="news.php">News</a></p>  <p>ZMail</p>

      <p>Help</p>
  </div></td>
</tr>
<tr>
  <td height="23" colspan="3"><div align="center">All names, news, content, characters, logos, data, and indicia are &copy;2005 Zanapets. </div></td>
</tr>

</table>

</div>
</body>
</html>

Drakla

There are two closing braces missing - the one that matches if(isset($_POST['login'])), and another from if(mysql_num_rows($query) > 0)

kburger

Plus, at least a few more problems:

session_start() must be at the top of the page, or at least before any HTML is sent to the browser.
You're calling session_start() it twice.
You're including config.php twice.
$num=mysql_numrows($result); should be $num=mysql_num_rows($result);

There may be others. That's just what I spotted with a quick scan.

Strikebf

Okay, thanks 🙂