variable importing help please

Talia

I am in a PHP class and the assignment was to make a dice guessing game (using only one die) and the user guesses what number they think the roll will land on. No sweat got that part. Works fine, my problem is how do I get six different pictures of dice (die1.gif, die2.gif, etc) to match the result of the die roll. So if the dice randomly lands on one then the picture of the dice with one pip on it shows up.

I cannot seem to figure out how to make this work. Do I put the images in an array? Then how do I associate the array with the random roll? Little frustrated here I think.

The instructor just said, remember variable importing. Which I have yet to find any reference of in this book.

Any suggestions to point me in the right direction would be helpful. I don't want anyone to write the code for me, I just would like a shove in the right direction is all.

Thanks.

Talia

edcellgavin

yes, you could put the filename in an array -

// starting index is zero
$diceroll = yourfunction(); // result is 1-6
$arrPics = array('', 'dice1.gif', 'dice2.gif', ..., 'dice6.gif');
echo "<img src=\"" . $arrPics[$diceroll] . "\">";

or with your filenaming convention, you could do

$diceroll = yourfunction(); // result is 1-6
echo "<img src=\"dice".  $diceroll . ".gif\">";

Talia

Thank you it works, the picture comes up with the roll and everything. One minor little problem though. If the correct number is picked it gives me the Illegal State Error, instead of the 'You got it right message'.

So, guess I didn't check it out far enough the first time. What am I doing wrong? Is it in the way I have the else if ($diceroll != 1 && $pick == 1)? 😕

<?php
srand ((double) microtime() * 10000000);
$diceroll = rand(1, 6);
//starting index is zero
$arrPics = array(' ', 'die1.gif', 'die2.gif', 'die3.gif', 'die4.gif', 'die5.gif', 'die6.gif');
print "<img src=\"" . $arrPics[$diceroll] . "\">";

if ($roll == 1 && $pick == 1) {
print ' You got it right! ';
} elseif ($diceroll != 1 && $pick == 1) {
print ' You got it wrong! ';
} elseif ( $diceroll == 2 && $pick == 2) {
print ' You got it right! ';
} elseif ($diceroll != 2 && $pick == 2) {
print ' You got it wrong! ';
} elseif ( $diceroll == 3 && $pick == 3) {
print ' You got it right! ';
} elseif ($diceroll != 3 && $pick == 3) {
print ' You got it wrong! ';
} elseif ( $diceroll == 4 && $pick == 4) {
print ' You got it right! ';
} elseif ($diceroll != 4 && $pick == 4) {
print ' You got it wrong! ';
} elseif ( $diceroll == 5 && $pick == 5) {
print ' You got it right! ';
} elseif ($diceroll != 5 && $pick == 5) {
print ' You got it wrong! ';
} elseif ( $diceroll == 6 && $pick == 6) {
print ' You got it right! ';
} elseif ($diceroll != 6 && $pick == 6) {
print ' You got it wrong! ';
} else {
print " Illegal state error!";
}

I know there has to be a shorter way of doing this too, but being a newbie we tend to take the hardest road cause its the only road we know. And well, I guess I don't know this road very well at all yet. :bemused:

Suggestions appreciated and thank you for the advice on getting the pictures and die to match up. That works slick.

Talia

Nevermind, my bad.

if ($roll == 1 && $pick == 1) {
print ' You got it right! ';

Should be $diceroll not roll. Typo. Sheesh I feel like a dodo. Thanks for the help.

:rolleyes:

Talia

Drakla

All those if statements can be boiled down to

if ($diceRoll == $pick)
{
   echo 'You got it right<br/>';
}
else
{
    echo 'You got it wrong<br />';
}

plus all your font things.

halojoy

All those if statements can be boiled down to
if ($diceRoll == $pick)
{
 echo 'You got it right ';
}
else
{
 echo 'You got it wrong ';
}
[/B]

To make it even shorter:

After if(condition) do-something;

You will only need { do-something } within brackets,
when there are more than one thing to do

Two thing to do within and 'if' 'else'

if ($diceRoll == $pick){
   echo 'You got it right<br/>';
   counter = counter+1;
}
else{
    echo 'You got it wrong<br />';
    counter = counter-1;
}

Only One thing todo within IF and ELSE, ( one echo )

<?php

if ( $diceRoll == $pick ) echo "You got it right<br />";
else                     echo "You got it wrong<br />";

?>

This is as simple as it gets.
/halojoy

🙂

Talia

Well the shorter way sure seems a lot smarter then the way they are teaching us in this class. Well, the way this book teaches it is a better way to put it.

Lot less things to mess up. But, they probably making us do things the long way so it is drilled into our heads more. But, I like your way a whole lot better.

Thank you for the input, I really appreciate it. This is only my 9th day of learning PHP so all the help I can get I am very thankful for.

:bemused: Plus, our instructor decided now was the time to take a 3 week trip to Greece and Budapest. Been grading our homework by email, and isn't being exceptionally helpful at the moment.

Again, I can't thank you all enough. You are the greatest.

Talia