Uploading multiple pictures and for loop

[Elhombrebala]

I'm trying to upload and thumbnail 3 pictures in a shot.
The form is as follows:

<input name="userfile[]" type="file" /><br />
<input name="userfile[]" type="file" /><br />
<input name="userfile[]" type="file" /><br />

So I'm using an array to send all pictures, after I try to acces it with a for loop:
The count($userfile) should maybe look better like count($_FILES['userfile']) but the fact is that only works in the first case.
If I echo them, only count($userfile) gives me the right result.

Too many weird things...
Check my code, please:

$totalimages=count($userfile);
if($totalimages != 0){
for($a=0;$a<$totalimages;$a++){
$msg = "";
switch($_SERVER['REQUEST_METHOD']) {

   case true:

   if(!isset($_FILES['userfile'][$a]) || $_FILES['userfile'][$a] == "none" || $_FILES['userfile'][$a] == "") {
		$msg = "Press browse to select a picture";
		break;
	}


$tmp = getcwd()."/".$_FILES['userfile'][$a]['name'];

if(!@move_uploaded_file($_FILES['userfile'][$a]['tmp_name'], $tmp)) {

$msg = "There was an error while uploading";
		break;
	}

$fp = fopen($tmp, "rb");
$str = fread($fp, filesize($tmp));

fclose($fp);
unlink($tmp);

$im1 = ImageCreateFromString($str);

$imgname = $ref."_thumb_".$a;
$maxwidth =250;
$maxheight = 200;	

$width1 = ImageSX($im1);
$height1 = ImageSY($im1);
$width2 = $maxwidth;
$height2 = floor(($width2 * $height1) / $width1);

if($maxheight > 0 && $height2 > $maxheight) {

	$height2 = $maxheight;
	$width2 = floor(($height2 * $width1) / $height1);
}

$im2 = ImageCreateTrueColor($width2, $height2);
ImageCopyResampled($im2, $im1, 0, 0, 0, 0, $width2, $height2, $width1, $height1);

ImageJpeg($im2, "thumb/".$imgname.".jpg");		// Se copia en temp/
$msg = "Ok";
$im3 = ImageCreateFromString($str);

$imgname2 = $ref."_full_".$a;	
$maxwidth2 = 500;	
$maxheight2 = 300;

$width12 = ImageSX($im3);
$height12 = ImageSY($im3);
$width22 = $maxwidth2;
$height22 = floor(($width22 * $height12) / $width12);

if($maxheight2 > 0 && $height22 > $maxheight2) {

	$height22 = $maxheight2;
	$width22 = floor(($height22 * $width12) / $height12);
}

$im4 = ImageCreateTrueColor($width22, $height22);
ImageCopyResampled($im4, $im3, 0, 0, 0, 0, $width22, $height22, $width12, $height12);

ImageJpeg($im4, "full/".$imgname2.".jpg");
ImageDestroy($im1);
ImageDestroy($im2);
ImageDestroy($im3);
ImageDestroy($im4);
break;
}}

[leatherback]

Hi,

Try this script I am using for multi-file upload. I clipped some sections from it (The function handles all sorts of uploads for me), so check whether all brackets are in place:

foreach($_FILES as $key => $linkdata)
  {
  if(!$linkdata[tmp_name] == "")
    {
    // test whether a picture exists in this location

   $newfname = $photoalbumpath."album".$album."_pic";
   $newfname2 = $photoalbumpath."album".$album."_pic.jpg";
   $newthname = $photoalbumpath."th_album".$album."_pic";
   $newthname2 = $photoalbumpath."th_album".$album."_pic.jpg";
   $i=1;
   $fname2 = $fname;
/*
   While(filetest($newfname2))
     {
     $newfname2 = $newfname.$i.".jpg";
     $newthname2 = $newthname.$i.".jpg";
     $safename = "album".$album."_pic".$i.".jpg";
     $i++;
     }
*/
$destination = $newfname2;   

$thdestination = $newthname2;   

// upload the files
    $mainresult = upload_file($linkdata, $destination, $album_max_width, $album_max_height, 0);

  $thumbresult = upload_file($linkdata, $thdestination, $thumb_max_width, $thumb_max_height, 1);
  }
}


// the upload function


function upload_file($file_array, $destination, $new_max_width, $new_max_height, $remove_orig)
  {

   $original_picture = $file_array['name'];         // original filename
   $tmp_picture      = $file_array['tmp_name'];     // Filname in upload folder
   $new_picture      = $destination;                // full path filename

    // ****************** Test variables / files for correct input *******************************

    if (!file_exists($tmp_picture) )         // Check wether filesource exists
    {
    return("File doesn't exist in temporary folder on server!");
    // The script has died here
    }

    if(file_exists($new_picture))        // Remove existsing file
    {
    $delete = @unlink($new_picture);
    }

    // ***************** Get file details **************************

    $size = GetImageSize($tmp_picture);
    $aspectRat = (float)($size[1] / $size[0]);

    // ***************** Calculate new x/y size, maintaining original aspect ratio

    if( ($size[0] <= $new_max_width) && ($size[1] <= $new_max_width) )  // Image < max size
      {        
      copy($tmp_picture, $new_picture); 
      $newX = $size[0];
      $newY = $size[1];
      }
    else 
      {

      $width_ratio = $size[0] / $new_max_width;
      $height_ratio = $size[1] / $new_max_height;

    if($width_ratio >= $height_ratio)  // width needs to be reduced more
      {
      $newY = $new_max_width * $aspectRat;
      $newX = $new_max_width;
      }
    else
      {
      $newY = $new_max_height;
      $newX = $new_max_height * (1/$aspectRat);
      }


    //create the destination image resource. 

    $destImg = ImageCreateTrueColor($newX, $newY );

    //read the source image (original), use correct function depending on format

    if ($size[2] == 1)
    {
    $sourceImg = ImageCreateFromGIF($tmp_picture);
    }
    if ($size[2] == 2)
    {
    $sourceImg = ImageCreateFromJPEG($tmp_picture);
    }
    else if ($size[2] == 3)
    {
    $sourceImg = ImageCreateFromPNG($tmp_picture);
    }
    else
    {
    return("This file cannot be used. It is not a jpg, gif or png file.<br>");
    die(); // This is a double-trap. Return should have ended execution fo the scriopt already 
    }

    // **************************** Create the new output file *******************

    imagecopyresampled($destImg, $sourceImg, 0, 0, 0, 0, $newX, $newY, $size[0],  $size[1]);
    imagejpeg($destImg, $destination);

    }

    // *************************** Remove the temproary file *********************
    if($remove_orig == 1)
      {
      $deletedfile = @unlink($tmp_picture);
      }

    $output = array(
    0 => true,
    1 => $newY,
    2 => $newX);
    return($output);
 }

[Elhombrebala]

I'm trying to get in to your code but or I'm more stupid than I thought or there's something missing I can't find (Which is merely the same thing as condition 1.

Can not make it work...

[Kudose]

This is how I would handle multiple file uploads. It doesn't matter how may files there are either. Just as an example...

<?php
$files = $_POST['userfile']; //store array
$perm_dir = "/home/username/publit_html/images/"; //absolute path
$max_size = 250000; // roughly 250k
$err = array(); //error array

foreach($files as $file){
  if(filesize($file['name']) > $max_size)
    $err[] = "File size it too great.";
  if(!is_uploaded_file($file['tmp_name']))
    $err[] = "File was not uploaded properly.";

  if(count($err) == 0)
    if(!move_uploaded_file($file['tmp_name'], $perm_dir.$file['name']))
      $err[] = "File could not be moved to the permanent directory.";

  if(count($err)) == 0){
    echo 'File uploaded.';
  } else {
    echo 'The following errors occured:<br>';
    echo '<ol>';
    foreach($err as $error){
      echo '<li>'.$error.'</li>';
    }//end foreach error
    echo '</ol>';
  }//end if no errors
}//end foreach file
?>

Note: This isnt meant for production use.