[Resolved] Is there a simpler way?

[middleman666]

Sorry, fairly new to PHP...

I created the following using a tutorial i found on the web, but i was just wondering... is there a simpler way of writing this script?

<?php 

$myFile = "../JSPOPUP.php";

if ($_POST["update"] == "yes") { 
$fh = fopen($myFile, 'ar') or die("can't open file");

$stringData = "\r\r";
fwrite($fh, $stringData);

$stringData = 'function Artist';
fwrite($fh, $stringData);

$stringData = "$BandName";
fwrite($fh, $stringData);

$stringData = '(){';
fwrite($fh, $stringData);

$stringData = "\r";
fwrite($fh, $stringData);

$stringData = 'var popurl="content/Artist-';
fwrite($fh, $stringData);

$stringData = "$BandName";
fwrite($fh, $stringData);

$stringData = '.php"';
fwrite($fh, $stringData);

$stringData = "\r";
fwrite($fh, $stringData);

$stringData = 'winpops=window.open(popurl,"","width=400,height=580,")';
fwrite($fh, $stringData);

$stringData = "\r";
fwrite($fh, $stringData);

$stringData = '}';
fwrite($fh, $stringData);

fclose($fh); 

echo "<font color=\"red\">File Updated</font>";
} 

?> 

[Installer]

Just assemble the string first, using concatenation or heredoc, then write that string with one statement.

BTW, what is 'ar' in this line

$fh = fopen($myFile, 'ar')

?

[middleman666]

you lost me with the use of big words... but ill search around for the meanings.

the ar bit... lol well... a for append... and r for read... though im not sure if your able to put them together like that, but the script seems to be working fine..

thanks for the help.

[Installer]

Concatenation and heredoc are both explained in the link I provided.

[halojoy]

Originally posted by Installer
Just assemble the string first, using concatenation or heredoc, then write that string with one statement.
BTW, what is 'ar' in this line $fh = fopen($myFile, 'ar') ?

// concenating into $stringData
// using '.=' instead of '=' will add to string = append
$stringData  = "\r\r";
$stringData .= 'function Artist';
$stringData .= ' more text added';
// add more an more to $stringData
// ......

// most simple method;   '.' means + ; and add it all
$stringData  = "\r\r" . 'function Artist' . ' more text added' . ' and this too';

// finally make ONE fopen,fwrite,fclose of $stringData into $myFile
// 'ab' = append binary, to this file, there is no such thing as 'ar'
$fh = fopen( $myFile, 'ab' );
fwrite( $fh, $stringData );
fclose( $fh );

[middleman666]

that made mucho sense, thankyou all! 🙂

think ill go with this method:

$stringData  = "\r\r" . 'function Artist' . ' more text added' . ' and this too';