[Resolved] login script only works second time!

[camowel]

Ok, as with any problem I have this is probably a result of laziness somewhere on my part, but I have no clue where

I am using an object, in a session variable to track users, so far, its worked great!

But I just noticed, that I can't seem to log in the first time I try, I get no error messages, simply redirected to my main page (like whats supposed to happen after I log in

Its getting confusing, I've look through every bit of the script but I can't figure it out.

Here is the login function in the user class:

<?php
function login($user, $pass) {
	// Check if the user is already logged in
	if ($this->login == TRUE) {
		header('Location:  index.php');
	}
	global $db;
	global $site;
	if (!$db) {
		die('NO DATABASE CONNECTION FOUND');
	}
	$sql = 'SELECT * FROM `users` WHERE ';
	$sql .= "username='$user' AND password=SHA1('$pass')";

$query = $db->query($sql);

if ($query->numrows != 1) {
	$this->error_message("Invalid Username or password");
	header('Location: '.$site['dir_root'].'/login.php');
} else {
	$info = $query->data[0];
	$this->username = $info['username'];
	$this->uid = $info['uid'];;
	$this->login = TRUE;
}
}
?>

And here is the auth.php script:

<?php
require_once('setup.php');

if (!isset($_POST['username']) || (!isset($_POST['password']))) {
	$_SESSION['user']->error_message("Please enter a username and password!");
	header('Location: login.php');
}

$_SESSION['user']->login(addslashes($_POST['username']), addslashes($_POST['password']));

$page = addslashes($_POST['redirect']);

header('Location: '.$page);

?>

I'm not sure what the problem is, the first time I try to log in, I get redirected back to the home page with no change to the $_SESSION['user'] object, the second time I get logged in like I should.

Any help is greatly appreciated, its not a major issue right now but it'll be great to get it out of the way and not have to solve it later (and it would be nice to only have to log in once)

If there is any more info I can provide to make solving this easier, please ask 🙂

[planetsim]

if ($query->numrows != 1) {
        $this->error_message("Invalid Username or password");
        header('Location: '.$site['dir_root'].'/login.php');
    } else {
        $info = $query->data[0];
        $this->username = $info['username'];
        $this->uid = $info['uid'];;
        $this->login = TRUE;
    } 

$this->error_message is basically pointless since it will never be sent to the browser as output. A part from that and using $_SESSION with an Object Attached (try to serialize it or just not use an Object) I see nothing wrong it.

[camowel]

The error_message() function does not send any output, it just sets a variable,

when the user is redirected, error_message() is called again, when its called without an argument, it returns the error 🙂

how would I go about 'serializing' the object?

[planetsim]

[man]serialize[/man] [man]unserialize[/man]

[camowel]

thanks 🙂 I'll look in to it

[camowel]

I'm using PHP5, apparantly those functions only work in PHP4

Does anyone have an idea why this is being such a problem, if its running the script fine the second time I don't see how it can be a problem the first :S

Thanks for any replies

[bradgrafelman]

serialize
(PHP 3 >= 3.0.5, PHP 4, PHP 5)

??

[camowel]

I guess I was looking at the wrong thing... That always happens to me 😉

Thanks, I'm still trying to fix it
I set up an auth page to thank the user for loggin in, enjoy your visit etc, it says that the user is logged in, and even prints the username fine, just when I go to the next page, it says the username is guest again

[camowel]

I think I found my problem, I think its one of those one-of-a-time glitches that I accidentally cause

My homepage was set to localhost:8080, so thats where I started, but, after the log in I was redirected back to 127.0.0.1/index.php, but if I went to a page on localhost:8080, I was logged in

I'm not quite sure why it happened but I am fairly sure it was my fault and that it wouldn't happen to another user, I'm getting rid of apache's Listen 8080 and setting my home page to 127.0.0.1, that should be enough to solve this problem

Thanks for the help

[bradgrafelman]

Probably something to do with browsers not allowing cookies to be refrenced across different domains, and it might have seen port 8080 as a different 'domain' in this case than the usual port 80.

At any rate, glad you found a solution.