[Resolved] formatting 'while' output data

[vertigrade]

Hi guys, here is the code to pull some images from mysql which is fine but due to not wanting a page 30 foot wide I would like to either insert a <br> after every 5th record returned or even echo </tr><tr> perhaps. Thanks in advance because my head hurts:

$num=mysql_numrows($result);

mysql_close();

$i=0;
while ($i < $num) {

                    $title=mysql_result($result,$i,"title");

$description=mysql_result($result,$i,"description");
$price=mysql_result($result,$i,"price");
$size=mysql_result($result,$i,"size");
$button=mysql_result($result,$i,"button");
$currency=mysql_result($result,$i,"currency");
?>

                    <TD vAlign=top width=100>
                  <form target="paypal" action="https://www.paypal.com/cgi-bin/webscr" method="post">

<input type="image" src="<? echo "$description"; ?>" border="0" name="submit" alt="<? echo "$currency"; ?><? echo "$price"; ?> - Click to Buy">
<input type="hidden" name="add" value="1">
<input type="hidden" name="cmd" value="_cart">
<input type="hidden" name="business" value="***">
<input type="hidden" name="item_name" value="<? echo "$title"; ?>">
<input type="hidden" name="amount" value="<? echo "$price"; ?>">
<input type="hidden" name="no_shipping" value="2">
<input type="hidden" name="currency_code" value="GBP">
<input type="hidden" name="lc" value="GB"><? echo "$title"; ?><br><? echo "$currency"; ?><? echo "$price"; ?>
</form></TD>

<?
++$i;
}

?>

[Roger_Ramjet]

You just need a second counter inside the loop.

<?
$c=1;
$i=0;
while ($i < $num) {


$title=mysql_result($result,$i,"title");
$description=mysql_result($result,$i,"description");
$price=mysql_result($result,$i,"price");
$size=mysql_result($result,$i,"size");
$button=mysql_result($result,$i,"button");
$currency=mysql_result($result,$i,"currency");
?>

<TD vAlign=top width=100>
<form target="paypal" action="https://www.paypal.com/cgi-bin/webscr" method="post">
<input type="image" src="<? echo "$description"; ?>" border="0" name="submit" alt="<? echo "$currency"; ?><? echo "$price"; ?> - Click to Buy">
<input type="hidden" name="add" value="1">
<input type="hidden" name="cmd" value="_cart">
<input type="hidden" name="business" value="***">
<input type="hidden" name="item_name" value="<? echo "$title"; ?>">
<input type="hidden" name="amount" value="<? echo "$price"; ?>">
<input type="hidden" name="no_shipping" value="2">
<input type="hidden" name="currency_code" value="GBP">
<input type="hidden" name="lc" value="GB"><? echo "$title"; ?><br><? echo "$currency"; ?><? echo "$price"; ?>
</form></TD>

<?
if ($c=5) {
	echo '</tr><tr>';
	$c=1;
}
else {
	++$c;
}
++$i;
}
?>

[vertigrade]

Thanks for the reply.
Still couldn't get it to work.
It inserts </tr><tr> after every record.
I increased the
if ($c=7)
-there are only 6 records so far-
and it still echoed </tr><tr> after every record.
I tried starting $c=0 instead of 1 - no help
I then tried
if ($c=pig)
just to see if it was evaluating the if else and it still inserted a </tr><tr> after every record!
I then tried
if ($c%3)
and it inserted the </tr><tr> after every other record but only after I had changed the initial value of $c=0 instead of $c=1
Then I put
if ($c%7)
and it still echoed after every other record.

Help please.

[bradgrafelman]

if ($c=5) { 

You need a comparison operator there. Try this:

if ($c==5) { 

Though, you could probably revise that whole code to just this and get rid of any $c reference:

if (!($i%5)) echo '</tr><tr>'; 

Besides, the whole way you do that section is something I've never done. Making extra calls to mysql_num_rows() and multiple calls to mysql_result() if you ask me.

while ($data = mysql_fetch_assoc($result)) { 

?>

<TD vAlign=top width=100> 
<form target="paypal" action="https://www.paypal.com/cgi-bin/webscr" method="post"> 
<input type="image" src="<? echo $data['description']; ?>"

and so on.

[vertigrade]

With help from you both I finally got it to work - cheers guys.
If it will help others, here is the final code:

$i=0;
$c=0;

while ($i < $num) {

                    $title=mysql_result($result,$i,"title");

$description=mysql_result($result,$i,"description");
$price=mysql_result($result,$i,"price");
$size=mysql_result($result,$i,"size");
$button=mysql_result($result,$i,"button");
$currency=mysql_result($result,$i,"currency");
?>

                    <TD vAlign=top width=100>
                  <form target="paypal" action="https://www.paypal.com/cgi-bin/webscr" method="post">

<input type="image" src="<? echo "$description"; ?>" border="0" name="submit" alt="<? echo "$currency"; ?><? echo "$price"; ?> - Click to Buy">
<input type="hidden" name="add" value="1">
<input type="hidden" name="cmd" value="_cart">
<input type="hidden" name="business" value="***">
<input type="hidden" name="item_name" value="<? echo "$title"; ?>">
<input type="hidden" name="amount" value="<? echo "$price"; ?>">
<input type="hidden" name="no_shipping" value="2">
<input type="hidden" name="currency_code" value="GBP">
<input type="hidden" name="lc" value="GB"><? echo "$title"; ?><br><? echo "$currency"; ?><? echo "$price"; ?>
</form></TD>
<?
if ($c==5) {
echo '</tr><tr>';
$c=0;
}
else {
++$c;
}
++$i;
}
?>

[Roger_Ramjet]

Whoops, always forget that it's == in php/c/etc, mostly I'm coding VB at the moment and it's just one = in a comparison in VB. Sorry 😃