[Resolved] Dam Cookie Problem!

ownedman

EDIT:

ownedman:

YES TIS WORKING THANKS TO DRACULA it was the domain aspect of the cookie too many dots the cookie thought all those different nubers were subdomains. LMAO!

anyways thanks drak brad and halo for all your help much appreciatedd

ooooo guess wat?
RESOLVED!

heh heh, alright.

http://154.20.148.186:1716/tests/cookie-fix.php

i realized some things that i didntearlier that first assigning the function setcookie() to a variable is wayyyy better. thanx all.

original post below:

well i know im not wanting this document to be html compliant and i know i got a meta tag ion the middle of my page 😛
i just dont know wats rong?!?!?
it gave me this on cookie.php
Warning: Cannot modify header information - headers already sent by (output started at C:\Site\tests\cookie.php:16) in C:\Site\tests\cookie.php on line 27

line 27 ill comment in the script. lol its the setcookie line.

cookie.php

<?
session_start();
header('Cache-control: private');
$self = $_SERVER['PHP_SELF'];
?>
<html>
<head>
<title>Cookie Test</title>
</head>
<body>
<center>
<h1>My Cookie Test :P</h1>
<p>&nbsp;</p>
<h3>Ener your name to be set to the cookie.</h3>
<br />
<form method="post" action="<?= $self ?>">
Enter Your Name >> <input type="text" name="value">
<br />
Thnx.
<input type="hidden" value="http://154.20.148.186:1716/tests/cooktest.php" name="url">
<input type="submit" value="Set Cookie">
</form>
<p>&nbsp;</p>
<?
$value = $_POST['value']
if(isset($_POST['value'])) {
setcookie("cookie", $value, time()+3600, "/", "http://154.20.148.186:1716", 0); //line // 27
?>
<span style="color:#FF0000">Cookie Set Redirecting......</span><br />
<meta http-equiv="refresh" content="5;url=redirect.php">
</center>
</body>
</html>
<?
};
?>
<?
$url = $_POST['url'];

if(!isset($url)) {
unset($url);
echo "enter sumthin.<br />";
} else {
$_SESSION['url'] = $_POST['url'];
};
?>

i dont think anythings wrong with this. but ima gonna post all three pages just in case.

redirect.php

<?
session_start();
header('Cache-control: private');
if(!isset($_SESSION['url'])) {
echo "get lost!";
} else {
?>
<center>
<p>&nbsp;</p>
<h1>Redirecting....</h1>
<meta http-equiv="refresh" content="5;url=<?= $_SESSION['url'] ?>">
</center>
<?
};

and here is the page that tests to see if the cookie was placed.

cooktest.php

<?
session_start();
header('Cache-control: private');
if (isset($_SESSION['url'])) {
$_SESSION = array();
session_destroy();
};

if (isset($_COOKIE['cookie'])) {
echo "<p>&nbsp;</p><center><h1> OORAA! the cookies is set!</h1<br /><strong> hello " .$_COOKIE['cookie']. "!</strong><p>&nbsp;</p>";
} else {
echo "<p>&nbsp;</p><center>Cookie failed to set :(<br /> <p>&nbsp;</p>";
};

print_r($_COOKIE);

echo "<br />";

if(isset($_COOKIE['cookie'])) {
?>
<h4>Delete Cookie?</h4><br />
<form method="post" action="<?= $_SERVER['PHP_SELF'] ?>">
<input type="submit" value="Delete Cookie" name="delete">
<br /> <strong>Note:</strong>if you do not delete the cookie it will expire in one hour.<br />
</form>
<?
};

$delete = $_POST['delete'];

if ($delete == TRUE) {
setcookie("cookie", "", time() - 3600, "/tests/", "http://154.20.148.186:1716");
echo "Cookie Deleted.";
} else { 
unset($delete);
};
?>

<br />
thanks for viewing my script i used sessions and cookies enjoy :P<br /> try again? <a href="cookie.php">Click</a>.
<br />
copyright&copy; Richard C-Wilson
</center>

thanks alot!

halojoy

<?php
// dont know if this will make your script totally fixed
// but you can try to change this line
// your original:
<form method="post" action="<?= $self ?>">

// my suggestion
// allow short <? tag is set in php.ini
// so, not all systems surely will allow <? instead of full <?php
// so a good rule is ALWAYS use <?php
<form method="post" action="<?php echo $self ?>">

// more like your version
<form method="post" action="<?=$self ?>">

?>

Hope it helps!
/halojoy sweden
🆒

Drakla

Your problem is you're tring to set a cookie after output has been sent to the script - you must do it before any output, just like your session start. Before line 27 you break back out to html and all that gets dumped to output.

ownedman

but i want the cookie to have the value of $value but how shall i do this pop the cookie if statement up to the top if the document?

ownedman

Originally posted by halojoy

<?php
// dont know if this will make your script totally fixed
// but you can try to change this line
// your original:
<form method="post" action="<?= $self ?>">

// my suggestion
// allow short <? tag is set in php.ini
// so, not all systems surely will allow <? instead of full <?php
// so a good rule is ALWAYS use <?php
<form method="post" action="<?php echo $self ?>">

// more like your version
<form method="post" action="<?=$self ?>">

?>

Hope it helps!
/halojoy sweden
🆒 [/B]

thanks but yea man it is enabled works for all my other scripts thanks cheers

halojoy

so
this did not change Warning line 16 ?????
Well, then you just have to wait for somebody else to help you

🙁 😕 :bemused:

Drakla

If you're submitting data to this page you can check if $_POST['value'] is set right at the top, and set the cookie appropriately. Cookies go out as part of the header, just like session_start and header() commands.

halojoy

Warning: Cannot modify header information - headers already sent by (output started at C:\Site\tests\cookie.php:16) in C:\Site\tests\cookie.php on line 27 line 27 ill comment in the script. lol its the setcookie line.

i am beginning to believe you are right,
problem is at line 27.
a cookie case for Dracula ..

=====
But anyway,
you can go on using your short <?
( some people are in lack of time for writing 2 extra chars, I know this )
but I to all other beginners, I say is a good rule ALWAYS using <?php

This you will discover on that very day you upload all your php scipts,
to your new Web Host, who does not allow short php-tag.
You will be spending hours, to open php after php
and find <? to change in them php-pages, you did put in effort and time to write.

Time you gain now - might be paid back later - 10 times more ...

😃

ownedman

i dont get it?!?!?

so just put the cookie crap at the top of the page before anything is output to the Browser? like right under the $self = $_SERVER['PHP_SELF'] would that work?

ownedman

i played around with itn put cookie @ the top and i got another parse error sigh.

Parse error: syntax error, unexpected $end in C:\Site\tests\cookie.php on line 43

<?
session_start();
header('Cache-control: private');
$value = $_POST['value'];
if(isset($_POST['value'])) {
setcookie("cookie", $value, time()+3600, "/", "http://154.20.148.186:1716", 0);

$self = $_SERVER['PHP_SELF'];

$url = $_POST['url'];

if (!isset($url)) {
unset($url);
echo "enter sumthin.<br />";
} else {
$_SESSION['url'] = $_POST['url'];
};
?>
<title>Cookie Test</title>
<body>
<center>
<h1>My Cookie Test :P</h1>
<p>&nbsp;</p>
<h3>Enter your name to be set to the cookie.</h3>
<br />
<form method="post" action="<?php $_SERVER['PHP_SELF'] ?>">
Enter Your Name >> <input type="text" name="value">
<br />
Thnx.
<input type="hidden" value="http://154.20.148.186:1716/tests/cooktest.php" name="url">
<input type="submit" value="Set Cookie">
</form>
<p>&nbsp;</p>
<?
if (isset($_COOKIE['cookie'])) {

echo "<span style=color:#FF0000>Cookie Set Redirecting......</span><br />
<meta http-equiv=refresh content=5;url=redirect.php>
</center></body>";
} else {
echo "cookie did not set.</center></body>";
};
?>

bradgrafelman

This line:

if(isset($_POST['value'])) {

has no matching ending brace '}'.

EDIT: I found this problem after about 5 seconds. How? Because I use Notepad2 to edit PHP. Started clicking on opening '{'s and they turned red & bold. Their matching '}' turned red & bold too. Finally, when I got to this line, the opening brace turned blue and bold, indicating it was unclosed. Easy! 🙂

ownedman

o watttttttttt theres a new notepad? lol i was literally staring at it for like an half an hour lol no fair you cheated well hopefully thats the case 😛

ownedman

damnit everythins workin but the cookie is not setting.

<?
session_start();
header('Cache-control: private');
$value = $_POST['value'];
if(isset($value)) {
setcookie("cookie", $value, time() + 3600, "/tests/", "http://154.20.148.186:1716", 0);
} else {
unset($value);
};
?>
<title>Cookie Test</title>
<body>
<center>
<h1>My Cookie Test :P</h1>
<p>&nbsp;</p>
<h3>Enter your name to be set to the cookie.</h3>
<br />
<form method="post" action="<?php $_SERVER['PHP_SELF'] ?>">
Enter Your Name >> <input type="text" name="value">
<br />
Thnx.
<input type="hidden" value="http://154.20.148.186:1716/tests/cooktest.php" name="url">
<input type="submit" value="Set Cookie">
</form>
<p>&nbsp;</p>
<?
$url = $_POST['url'];

if (!isset($url)) {
unset($url);
echo "enter sumthin.<br />";
} else {
$_SESSION['url'] = $_POST['url'];
};

if (isset($_COOKIE['cookie'])) {

echo "<span style=color:#FF0000>Cookie Set Redirecting......</span><br />
<meta http-equiv=refresh content=5;url=redirect.php>
</center></body>";
} else {
echo "cookie did not set.</center></body>";
};
?>

bradgrafelman

if (isset($_COOKIE['cookie'])) {

Even if the cookie is set properly, the $_COOKIE array is only populated when the user's browser sends the cookie. That won't happen until they go to another page again.

Plus, you might want to remove the 'http://' from your domain parameter.

EDIT: Just in case it comes up in the future... the semicolons after ending braces ('}') are unnecessary.. in fact, I've never seen them used in PHP! :p

halojoy

:queasy:

Your script looks well written. Much better than most php scripts I have seen here.
Should work.
But sometimes is only a small detail.

You do not get any PHP error_reporting Notices?
Any mysql errors?
What does HTML Source of your Browser page show?

Have you correct php.ini settings, for Cookies?

A phpinfo(); is never wrong ....

<?php phpinfo() ?>

The above should be saved as phpinfo.php
and be copied to whereever folder you are working and writing your php scripts.
I would not do without it ....

:queasy:

ownedman

wow thats a compliment i must have codin in my bl00d lol im a newb umm yea you need to configure php ini for cookies enlighten me 😛

ownedman

Originally posted by bradgrafelman

EDIT: Just in case it comes up in the future... the semicolons after ending braces ('}') are unnecessary.. in fact, I've never seen them used in PHP! :p

lol i just try to make it a habit if i dont lol its just an annoying parse error eassy to fix just made it a habit nuttin rong everythin works lol (im itching to hit resloved!)

ownedman

o btw sry triple post the cookiesis still ot set i wen to another page lol still.

ownedman

here is my PHP info lol i dot know how to tell if cookies are enabled:
http://154.20.148.186:1716/test.php

and th script is here:
http://154.20.148.186:1716/tests/cookie.php

try out the script plz cuz it mite jus be me

Drakla

Script well written? It's got a blaring error in its first few lines

$value = $_POST['value'];
if(isset($value)) {
setcookie("cookie", $value, time() + 3600, "/tests/", "http://154.20.148.186:1716", 0);
}

You're checking if a value is set AFTER taking it. If error reporting was on it would create a notice on its first run. Change it to

if (isset($_POST['value'])) 
{
$value = $_POST['value'];
setcookie("cookie", $value, time() + 3600, "/tests/", "http://154.20.148.186:1716", 0);
}

Also if you're testing cookie scripts it's a good idea to set the cookie lifetime WAY in the future, over a day as differences in the server time and your computer can cause the cookie to be considered dead the second it's thrown at you.

You've also supplied a script to test if cookies are set out of the path the cookie is allowed to be set in, which is "/tests/", so also make that "/" until you've got things working.

You're also checking for the success of cookie being set by checking the $_COOKIE array. This won't tell you if a cookie is set until the 3rd time the script is run. You should check the return value of setcookie.

Now I think you might have enough info to create a well written script.