[RESOLVED] File Upload Issues

[rprincejr]

Im having a few issues with a file upload script Im writing. Here is the first error Im getting. Thx for any help.

Warning: getimagesize(Array) [function.getimagesize]: failed to open stream: No such file or directory in c:\Inetpub\wwwroot\xxxx.php on line 155

Here's my code.

function stories_add($story_id, $div_id, $story_content,$fileupload1) {
    global $prefix, $db;
    $UploadImageSize = "50";         /* Max File size allowed in uploading image for ads -- in KiloBye(s) */
    $UploadImageHeight =  "150";         /* Max Height Allowed in uploading image for ads -- in Pixel(s) */
    $UploadImagewidth = "225";         /* Max Width Allowed in uploading image for ads -- in Pixel(s) */
    $UploadPath = "images/div-storyimages/"; /* The path to uploaded image ads*/
    $UploadImageType[0] = "gif";
    $UploadImageType[1] = "jpeg";
    $UploadImageType[2] = "jpg";
    $UploadImageType[3] = "JPG";

if (($fileupload1 != "") && ($fileupload1 != "none")) {
    if ($fileupload1_size > ($UploadImageSize * 1024)) {
            $errorImageSize = 1;
}
$imgsize = getimagesize($fileupload1);
$imgwidth = $imgsize[0];
$imgheight = $imgsize[1];
if (($imgwidth > $UploadImagewidth) || ($imgheight > $UploadImageHeight)) {
    $errorImageDimension = 1;
}
$imagetype = basename($fileupload1_type);
if (!in_array($imagetype,$UploadImageType)) $errorImageType = 1;
}

if ($errorImageSize || $errorImageDimension || $errorImageType) {
    include ("header.php");
    GraphicAdmin();
    OpenTable();
    echo "<CENTER><FONT CLASS=\"title\">Division Story Error</font></center><BR>";
    echo "<CENTER>";
    if ($errorImageSize) {
            echo "Max image size allowed in uploading is $UploadImageSize kilobytes. <BR>";
    }
    if ($errorImageDimension) {
            echo "Max image dimensions allowed is $UploadImageHeight x $UploadImagewidth pixels. <BR>";
    }
    if ($errorImageType) {
            echo "<BR>Allowed image types are: ";
            for ($i = 0;$i<= sizeof($UploadImageType)-1;$i++) {
            echo ".".$UploadImageType[$i]."";
            if ($j != sizeof($UploadImageType)-1) {
                    echo ", ";
            }
            $j++;
            }
            echo ".<BR>";
    }
CloseTable();
include("footer.php");
} else {

if ($fileupload1 != "") {
$type = basename($fileupload1_type);
$filename = $UploadPath.$fileupload1.$type;
copy ($fileupload1, $filename);
$imguploadname1 = $fileupload1.".".$type;
} else {
$imguploadname1 = "";
}
$db->sql_query("insert into ".$prefix."_tourn_stories (story_id, div_id, story_content, story_image1) values (NULL, '$div_id', '$story_content', '$fileupload1')");
Header("Location: admin.php?op=div_stories");
}
}

[bradgrafelman]

Ok, here's some questions:

• Where does $fileupload1_size come from?

• What is the value of $fileupload1 ?

• Is this being run directly after a file upload? Why not use the $_FILES superglobal?

[rprincejr]

I dont know how to use the $_FILES superglobal. This is my first attempt at writing an upload script. My actual goal is to upload 4 pictures within one form plus some text. I have all fields in the table laid out.

The test value of $fileupload1 I was using was C:\Documents and Settings\user\Desktop\101_0112_small.jpg

As far as $fileupload1_size, Im not sure.

Im pretty decent with PHP, but this file uploads is a new area to me. So any advice is appreciated. I am posting my form below.

        ."<form enctype=\"multipart/form-data\" method=\"post\" action=\"admin.php\">"
        ."<tr bgcolor=\"#e6e6e6\"><td colspan=\"2\" align=\"center\">"
        ."<b>Image Upload</b><br>"
        ."</td></tr>"
        ."<tr bgcolor=\"#e6e6e6\"><td>"
        ."<b>First Place:</b></td><td><input type=\"file\" name=\"fileupload1\" size=\"40\">"
        ."</td></tr>"
        ."<tr bgcolor=\"#e6e6e6\"><td colspan=\"2\">"
        ."<center><br><textarea name=\"story_content\" cols=\"80\" rows=\"15\">$story_content</textarea></center><br>"
        ."</td></tr>"
        ."</table>"
        ."</td></tr></table>"
        ."<input type=\"hidden\" name=\"div_id\" value=\"$div_id\">"
        ."<input type=\"hidden\" name=\"fileupload1\" value=\"$fileupload1\">"
        ."<input type=\"hidden\" name=\"op\" value=\"stories_add\">"
        ."<center><br><input type=\"submit\" value=\"Submit\"></center>"
        ."</form></align>"

[bradgrafelman]

This page has some information regarding file uploads.

It even talks about moving files and whatnot. Check out that page, and let me know if you still can't figure out how to use $_FILES. Also, a link to your upload page would help, too.

[rprincejr]

I read up on the $FILES superglobal. I understand what its function has now. But where is it set? I assume in the form. So if it is in the form, how do you call it out as $FILES? In the name or values area of the input tag?

[bradgrafelman]

When you submit a file, it's automatically added to the array.

Also, why do you have two HTML entities with the same name? You have a 'file' and 'hidden' both named "fileupload1".

[rprincejr]

Heres my form revised. I am working on the upload script and will post it soon.

        ."<form enctype=\"multipart/form-data\" method=\"post\" action=\"admin.php\">"
        ."<tr bgcolor=\"#e6e6e6\"><td colspan=\"2\" align=\"center\">"
        ."<b>Image Upload</b><br>"
        ."</td></tr>"
        ."<tr bgcolor=\"#e6e6e6\"><td>"
        ."<b>First Place:</b></td><td><input type=\"file\" name=\"picture1\" size=\"40\">"
        ."<b>Second Place:</b></td><td><input type=\"file\" name=\"picture2\" size=\"40\">"
        ."<b>Third Place:</b></td><td><input type=\"file\" name=\"picture3\" size=\"40\">"
        ."</td></tr>"
        ."<tr bgcolor=\"#e6e6e6\"><td colspan=\"2\">"
        ."<center><br><textarea name=\"story_content\" cols=\"80\" rows=\"15\">$story_content</textarea></center><br>"
        ."</td></tr>"
        ."</table>"
        ."</td></tr></table>"
        ."<input type=\"hidden\" name=\"MAX_FILE_SIZE\" value=\"51200\">"  //Size in bytes (51200=50kb)
        ."<input type=\"hidden\" name=\"div_id\" value=\"$div_id\">"
        ."<input type=\"hidden\" name=\"op\" value=\"stories_add\">"
        ."<center><br><input type=\"submit\" value=\"Submit\"></center>"
        ."</form></align>"

[bradgrafelman]

Don't forget this hidden value (as noted on the manual page I linked above)!

<!-- MAX_FILE_SIZE must precede the file input field -->
<input type="hidden" name="MAX_FILE_SIZE" value="30000" />

[rprincejr]

I have revised up to this point and cannot get the getimagesize error to go away. I dont see whats missing.

Heres the new code:

        ."<form enctype=\"multipart/form-data\" method=\"post\" action=\"admin.php\">"
        ."<tr bgcolor=\"#e6e6e6\"><td colspan=\"2\" align=\"center\">"
        ."<b>Image Upload</b><br>"
        ."</td></tr>"
        ."<tr bgcolor=\"#e6e6e6\"><td>"
        ."<b>First Place:</b></td><td><input type=\"file\" name=\"picture1\" size=\"40\">"
        ."</td></tr>"
        ."<tr bgcolor=\"#e6e6e6\"><td>"
        ."<b>Second Place:</b></td><td><input type=\"file\" name=\"picture2\" size=\"40\">"
        ."</td></tr>"
        ."<tr bgcolor=\"#e6e6e6\"><td>"
        ."<b>Third Place:</b></td><td><input type=\"file\" name=\"picture3\" size=\"40\">"
        ."</td></tr>"
        ."<tr bgcolor=\"#e6e6e6\"><td colspan=\"2\">"
        ."<center><br><textarea name=\"story_content\" cols=\"80\" rows=\"15\">$story_content</textarea></center><br>"
        ."</td></tr>"
        ."</table>"
        ."</td></tr></table>"
        ."<input type=\"hidden\" name=\"MAX_FILE_SIZE\" value=\"51200\">"  //Size in bytes (51200=50kb)
        ."<input type=\"hidden\" name=\"div_id\" value=\"$div_id\">"
        ."<input type=\"hidden\" name=\"op\" value=\"stories_add\">"
        ."<center><br><input type=\"submit\" value=\"Submit\"></center>"
        ."</form></align>"
        ."<br>"
        ."</td></tr></table>"
        ."</td></tr></table>";
    CloseTable();
    include("footer.php");
}

function stories_add($story_id, $div_id, $story_content) {
    global $prefix, $db;
    $UploadImageSize = "50";         /* Max File size allowed in uploading image for ads -- in KiloBye(s) */
    $UploadImageHeight =  "150";         /* Max Height Allowed in uploading image for ads -- in Pixel(s) */
    $UploadImagewidth = "225";         /* Max Width Allowed in uploading image for ads -- in Pixel(s) */
    $UploadPath = "images/div-storyimages/"; /* The path to uploaded image ads*/
    $UploadImageType[0] = "gif";
    $UploadImageType[1] = "jpeg";
    $UploadImageType[2] = "jpg";
    $UploadImageType[3] = "JPG";

if (($_FILES['picture1']['name'] != "") && ($_FILES['picture1']['name'] != "none")) {
    if ($_FILES['picture1']['size'] > ($UploadImageSize * 1024)) {
            $errorImageSize = 1;
}
$picture1 = $_FILES['picture1']['name'];
$imgsize = getimagesize($picture1);
$imgwidth = $imgsize[0];
$imgheight = $imgsize[1];
if (($imgwidth > $UploadImagewidth) || ($imgheight > $UploadImageHeight)) {
    $errorImageDimension = 1;
}
$imagetype = basename($_FILES['picture1']['type']);
if (!in_array($imagetype,$UploadImageType)) {
    $errorImageType = 1;
}
}

if ($errorImageSize || $errorImageDimension || $errorImageType) {
    include ("header.php");
    GraphicAdmin();
    OpenTable();
    echo "<CENTER><FONT CLASS=\"title\">Division Story Error</font></center><BR>";
    echo "<CENTER>";
    if ($errorImageSize) {
            echo "Max image size you are allowed to upload is $UploadImageSize kilobytes.<BR>Please resize your image.<br>";
    }
    if ($errorImageDimension) {
            echo "Max image dimensions allowed is $UploadImageHeight x $UploadImagewidth pixels.<BR>Please resize your image.<br>";
    }
    if ($errorImageType) {
            echo "<BR>Allowed image types are: ";
            for ($i = 0;$i<= sizeof($UploadImageType)-1;$i++) {
            echo ".".$UploadImageType[$i]."";
            if ($j != sizeof($UploadImageType)-1) {
                    echo ", ";
            }
            $j++;
            }
            echo ".<BR>Please resave your image as an acceptable format.<br>";
    }
CloseTable();
include("footer.php");

[bradgrafelman]

    $picture1 = $_FILES['picture1']['name']; 
    $imgsize = getimagesize($picture1); 

The 'name' key refers to the original file name on the person's computer, it has NOTHING to do with the file on your server.

Try using 'tmp_name' instead.

[planetsim]

Have you read the error at all?

Warning: getimagesize(Array) [function.getimagesize]: failed to open stream: No such file or directory in c:\Inetpub\wwwroot\xxxx.php on line 155

Notice how it says Array is the filename. Do a print_r() on $picture1

print_r($picture1); just before the function, see if it returns an Array result as the first time you showed us the error suggests (I think it would be slightly different now and $picture1 shouldnt be an Array).

Also another reason to $_FILE['uploadname']['name'] is just the name not the actual location, for function to work you will need to specify the actual location to the file.

[bradgrafelman]

Also another reason to $_FILE['uploadname']['name'] is just the name not the actual location, for function to work you will need to specify the actual location to the file.

(i.e. tmp_name)

[rprincejr]

I got my script edited and now it works. Thats great! Thanks Brad.

Now I have one more question concerning the same upload script. The script is currently only uploading one file. How do I do a total of four files without copying my current code four times and changing the variables for each file? Can I use an array for the $_FILES superglobal?

As an example, how would I rewrite the following code to look at each of the four files without just writing the code four times in a row?

Heres my code example:

    if (($_FILES['picture1']['name'] != "") && ($_FILES['picture1']['name'] != "none")) {
        if ($_FILES['picture1']['size'] > ($UploadImageSize * 1024)) {
                $errorImageSize = 1;
    } else {
                $picture1 = $_FILES['picture1']['tmp_name'];
                $imgsize = getimagesize($picture1);
                $imgwidth = $imgsize[0];
                $imgheight = $imgsize[1];
    }

[bradgrafelman]

You could make it even more versatile! Try this:

for($i = 1; isset($_FILES['picture'.$i]); $i++) {

if (($_FILES['picture'.$i]['name'] != "") && ($_FILES['picture'.$i]['name'] != "none")) { 
		if ($_FILES['picture'.$i]['size'] > ($UploadImageSize * 1024)) { 
				$errorImageSize = 1; 
	} else { 
				${'picture'.$i} = $_FILES['picture'.$i]['tmp_name']; 
				$imgsize = getimagesize(${'picture'.$i}); 
				$imgwidth = $imgsize[0]; 
				$imgheight = $imgsize[1]; 
	}

}

Also, the $imgsize, $imgwidth, and $imgheight variables will be overwritten unless you make them like.. $img1width and whatnot. Just FYI.

[rprincejr]

I have updated my script to upload four files. The script runs trough without any errors but no files are uploaded. Im posting the script here to see if an error can be seen.

    $UploadImageSize = "50";                                                    // Max File size allowed in uploading image for ads -- in KiloBye(s)
    $UploadImageHeight =  "150";                                                // Max Height Allowed in uploading image for ads -- in Pixel(s)
    $UploadImagewidth = "225";                                                  // Max Width Allowed in uploading image for ads -- in Pixel(s)
    $UploadPath  = './images/div-storyimages/'.$_FILES['picture'.$i]['name'];   // The path to uploaded image ads
    $UploadImageType[0] = "gif";
    $UploadImageType[1] = "jpeg";
    $UploadImageType[2] = "jpg";
    $UploadImageType[3] = "JPG";

for($i = 1; isset($_FILES['picture'.$i]); $i++) {

if (($_FILES['picture'.$i]['name'] != "") && ($_FILES['picture'.$i]['name'] != "none")) {
    if ($_FILES['picture'.$i]['size'] > ($UploadImageSize * 1024)) {
            $errorImageSize = 1;
} else {
            ${'picture'.$i} = $_FILES['picture'.$i]['tmp_name'];
            $imgsize = getimagesize(${'picture'.$i});
            $imgwidth = $imgsize[0];
            $imgheight = $imgsize[1];
}

if (($imgwidth > $UploadImagewidth) || ($imgheight > $UploadImageHeight)) {
    $errorImageDimension = 1;
}
$imagetype = basename($_FILES['picture'.$i]['type']);
if (!in_array($imagetype,$UploadImageType)) {
    $errorImageType = 1;
}
}

if ($errorImageSize || $errorImageDimension || $errorImageType) {
    include ("header.php");
    GraphicAdmin();
    OpenTable();
    echo "<CENTER><FONT CLASS=\"title\">Division Story Error</font></center><BR>";
    echo "<CENTER>";
    if ($errorImageSize) {
            echo "Max image size you are allowed to upload is $UploadImageSize kilobytes.<BR>Please resize your image.<br>";
    }
    if ($errorImageDimension) {
            echo "Max image dimensions allowed is $UploadImageHeight x $UploadImagewidth  pixels.<BR>Please resize your image.<br>";
    }
    if ($errorImageType) {
            echo "<BR>Allowed image types are: ";
            for ($t = 0;$t<= sizeof($UploadImageType)-1;$t++) {
            echo ".".$UploadImageType[$t]."";
            if ($j != sizeof($UploadImageType)-1) {
                    echo ", ";
            }
            $j++;
            }
            echo ".<BR>Please resave your image as an acceptable format.<br>";
    }
CloseTable();
include("footer.php");
} else {

move_uploaded_file($_FILES['picture'.$i]['tmp_name'], $UploadPath);
if ($i == "1") {
    $db->sql_query("insert into ".$prefix."_tourn_stories (story_id, div_id, story_content, story_image1, story_image2, story_image2, story_image3, story_image4) values (NULL, '$div_id', '$story_content', '${'picture'.$i}', , , )");
} elseif ($i == "2") {
    $db->sql_query("insert into ".$prefix."_tourn_stories (story_id, div_id, story_content, story_image1, story_image2, story_image2, story_image3, story_image4) values (NULL, '$div_id', '$story_content', , '${'picture'.$i}', , )");
} elseif ($i == "3") {
    $db->sql_query("insert into ".$prefix."_tourn_stories (story_id, div_id, story_content, story_image1, story_image2, story_image2, story_image3, story_image4) values (NULL, '$div_id', '$story_content', , , '${'picture'.$i}', )");
} elseif ($i == "4") {
    $db->sql_query("insert into ".$prefix."_tourn_stories (story_id, div_id, story_content, story_image1, story_image2, story_image2, story_image3, story_image4) values (NULL, '$div_id', '$story_content', , , , '${'picture'.$i}')");
    Header("Location: admin.php?op=div_stories");
} else {
    echo "Error: No Files were uploaded.<br>";

}
}
}
}

[bradgrafelman]

The last ending brace '}' is extra, no opening brace found.

EDIT: Also, your script will insert 4 different rows into your database. Why not just combine it all into one row??

[rprincejr]

I fixed my problem with many thanks to Brad. Here is the final code. This thread is resolved.

    for($i = 1; isset($_FILES['picture'.$i]); $i++) {

$UploadImageSize = "50";                                                    // Max File size allowed in uploading image for ads -- in KiloBye(s)
$UploadImageHeight =  "100";                                                // Max Height Allowed in uploading image for ads -- in Pixel(s)
$UploadImagewidth = "150";                                                  // Max Width Allowed in uploading image for ads -- in Pixel(s)
$UploadPath  = './images/div-storyimages/'.$_FILES['picture'.$i]['name'];   // The path to uploaded image ads                           // Blah
$UploadImageType[0] = "gif";
$UploadImageType[1] = "jpeg";
$UploadImageType[2] = "jpg";
$UploadImageType[3] = "JPG";



if (($_FILES['picture'.$i]['name'] != "") && ($_FILES['picture'.$i]['name'] != "none")) {
    if ($_FILES['picture'.$i]['size'] > ($UploadImageSize * 1024)) {
            $errorImageSize = 1;
    } else {
            $picture = $_FILES['picture'.$i]['tmp_name'];
            $imgsize = getimagesize($picture);
            $imgwidth = $imgsize[0];
            $imgheight = $imgsize[1];

    }

    if (($imgwidth > $UploadImagewidth) || ($imgheight > $UploadImageHeight)) {
            $errorImageDimension = 1;

    }

    $imagetype = basename($_FILES['picture'.$i]['type']);
    if (!in_array($imagetype,$UploadImageType)) {
            $errorImageType = 1;

    }

    }

if ($errorImageSize || $errorImageDimension || $errorImageType) {
    include ("header.php");
    GraphicAdmin();
    OpenTable();
    echo "<CENTER><FONT CLASS=\"title\">Story Submission Error</font></center><BR>";
    echo "<CENTER>";
    if ($errorImageSize) {
            echo "The maximum image size you are allowed to upload is $UploadImageSize kilobytes.<BR>Please check your images and resize them if necessary.<br>";

    }

    if ($errorImageDimension) {
            echo "The maximum image dimensions allowed are $UploadImagewidth x $UploadImageHeight pixels (Width x Height).<BR>Please check your images and resize them if necessary.<br>";

    }

    if ($errorImageType) {
            echo "<BR>Allowed image types are: ";
            for ($t = 0;$t<= sizeof($UploadImageType)-1;$t++) {
            echo ".".$UploadImageType[$t]."";
            if ($j != sizeof($UploadImageType)-1) {
                    echo ", ";
            }
            $j++;
            }
            echo ".<BR>Please resave your image as an acceptable image type.<br>";

    }
echo "<br><FORM><INPUT TYPE=\"button\" VALUE=\"Back\" onClick=\"history.go(-1)\"></FORM>";
CloseTable();
include("footer.php");

} else {

move_uploaded_file($_FILES['picture'.$i]['tmp_name'], $UploadPath);

}
}

$picture_array = array($_FILES['picture1']['name'], $_FILES['picture2']['name'], $_FILES['picture3']['name'], $_FILES['picture4']['name']);
$pictures = implode(', ', $picture_array);
if ($db->sql_query("insert into ".$prefix."_tourn_stories (story_id, div_id, story_content, story_images) values (NULL, '$div_id', '$story_content', '$pictures')")) {
           Header("Location: admin.php?op=div_stories");
} else {
           echo "Error: There was a problem submitting your story.<br> Please try submitting it again.<br>";
}

}