[Resolved] database

talkster5

Something completley weird is going on with my database connection. I have exactly the same code on both pages copy and pasted many times and yet on one page it works and the other one it doesnt. Both pages are also in the same directory and its really starting to annoy me now after looking at it for ages. However if on the page that its not working on I hard code in the id number then it will work but without doing that it wont and just tells me "You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1"

<?php require_once('Connections/database.php'); ?>
<?php
mysql_select_db($database_database, $database);
$sql    = "SELECT * FROM guides WHERE id=$id"; 
$result = mysql_query($sql) or die(mysql_error());

if(mysql_num_rows($result) > 0) { 
if ($row = mysql_fetch_array($result))
{
echo "$row[text]\n";
}
}
?>

bradgrafelman

Where is "$id" coming from? I don't see it defined.

EDIT: Also, this:

echo "$row[text]\n";

Has 2 problems. One being that array items aren't referenced inside a string, rather concantenated. Also, the array key should be treated as a string, i.e. delimited by quotes. Here's an example:

echo $row['text'] . "\n";

or, using braces,

echo "{$row['text']}\n";

At any rate, I don't think your code will go awry, though it's definitely not a good coding style/habbit.

talkster5

It is from the url.

bradgrafelman

Then don't use $id, use $_GET['id'] !

$id should never work, and if it does, then you need to read the first post in this thread and consider turning register_globals off.

EDIT: Also note the edits in my above post.

talkster5

Thanks, it seems to be working now.

bradgrafelman

Double check, and if it is indeed working now, don't forget to mark this thread resolved!