[Resolved] mysql_query problem

devona

Hey,
I cannot find out why this is not updating the database. could anyone glance this over and see what I have done wrong?

<?php

require 'db_connect.php';

$result = mysql_query("SELECT * FROM users WHERE id = '" . $_GET['id'] . "' LIMIT 1");
$row = mysql_fetch_array($result);
$email = $row['email'];
?>

<?php
if (isset($_POST['submit'])) {
mysql_query("UPDATE `users` SET `postal` = '".$_POST['a']."', `pp` = '".$_POST['b']."' WHERE `email` = '$email'");

$db_object->disconnect();
?>

the form fields are labled a and b.

<form action="<?php echo $_SERVER['PHP_SELF']?>" method="post">

further down in the code is the closing }.

thorpe

is the id filed of the int type? int's dont need to be surrounded by single quotes.

devona

Yes sir, it is. However the problem does not lie with the the line

$result = mysql_query("SELECT * FROM users WHERE id = '" . $_GET['id'] . "' LIMIT 1");

I know this because I have echo's within the page that display the correct information based on the users ID.

So there is something wrong with the way im using UPDATE. What is wierd is I have used these sames lines in the same program and they work. But when it comes to this page they are not working. The only difference is that in the other files, it was the user updating the their own profiles, whereas now it is the administration updating the users profile. But, the GET[id] pulls up all the information for the correct user, so i dont understand why setting $email = $row['email'] would not have the same effect as in my other files where $email = $SESSION["email"].

im so confused

bradgrafelman

Visit the Debugging 101 thread (link in my sig) for tips on erraneous SQL statements.

thorpe

ok... sorry miss read your post. you might try adding some error checking to see what error you get. add a die() statement after your query.
eg;

mysql_query() or die(mysql_error());

also... is there any reason why your doing this in two queries? i meen why do a SELECT just to do an UPDATE? the less queries the better.

devona

I am using 2 queries because the way I have the program set up, the admin clicks on a members name to edit their profile, when he clicks that name, some of the members information is brought up and echo'd on the page.

I have added the error checking and everything goes through OK, there is no error.

Here is the new code:

mysql_query("UPDATE `users` SET `postal` = '".$_POST['a']."', `pp` = '".$_POST['b']."' WHERE `email` = '$email'") or die(mysql_error());

I have also added:

<?php echo '<pre>';
print_r ($_POST);
echo '</pre>';
?>

to make sure that everything I wanted posted was going through, and it is.
I also have echo'd $email to make sure its the users email, and it is. So, since there are no sytax errors and all of the information from $_POST is coming through, I cannot find out why the hell this is not working.

The fields in the database are labeled correctly the tablename is "users" im updating fields "postal" and "pp" and there is a field named "email"

devona

the code needed to look like this:

mysql_query("UPDATE `users` SET `postal` = '".$_POST['a']."', `pp` = '".$_POST['b']."' WHERE `email` = '".$email."'") or die(mysql_error());

incase someone else experiences the same problem, here it is.