is this right?

[lukeurtnowski]

ok I think I made a query for my form (which consists or 4 filters)
select * from company, activity
where c_id = a_c_id and

medivas = $poc and
priority in ($prioritya, $priorityb, $priorityc) and
a_date between ($startdate, $enddate) and
c_name = $C_name

But I get this error?
You have an error in your SQL syntax near 'medivas (2) and priority in (A, , ) and a_date between (2005-01-01, 2005-01-' at line 3
I can't figure ouuuut where the error lies, any ideas? thanks

[thorpe]

can we see the actuall query in actuall context?

[lukeurtnowski]

like this?

....
$db = mysql_selectdb($database , $connection)
or die("cannot find database");
$sql="select * from company, activity
where c_id = a_c_id and  

medivas = $poc and 
priority in ($prioritya, $priorityb, $priorityc) and 
a_date between ($startdate, $enddate) and 
c_name = $C_name";
$query=mysql_query($sql) or die(mysql_error());
$numofrows = mysql_num_rows($query);

or did you want to see where it residess?
http://www.lukesplace.com/Padilla/createreport.php

[thorpe]

change this

or die(mysql_error());

to

or die($sql);

what does it print to screen?

[lukeurtnowski]

k, I get this
You have an error in your SQL syntax near 'and priority in (, , ) and a_date between (2005-01-01, 2005-01-01) and c_n' at line 3

[thorpe]

makes no sense. comment out the execution of the query and print the $sql variable to the screen.

$sql="select * from company, activity
where c_id = a_c_id and  

medivas = $poc and 
priority in ($prioritya, $priorityb, $priorityc) and 
a_date between ($startdate, $enddate) and 
c_name = $C_name";
echo $sql;
// $query=mysql_query($sql) or die(mysql_error());

what do you get?

[lukeurtnowski]

this?

Warning: Supplied argument is not a valid MySQL result resource in /home/domains/lukeu/lukesplace.com/Padilla/report_generator.php on line 19

[thorpe]

this?

no...... you really need to learn to debug. i want you to echo() your sql statement contained in the variable $sql. this will help make the errors clearer. we need to see what your sql statement will look like to the database.

and it appears from your last post... this is just the beggining of the errors.

[lukeurtnowski]

OK, made the change, when the page runs, this is returned

Warning: Supplied argument is not a valid MySQL result resource in /home/domains/lukeu/lukesplace.com/Padilla/report_generator.php on line 19

heres my php where The problem must lie.

<?php
$hostname = "10.0.0.127";
$username = "luke";
$password = "blues";
$database = "test";
$connection = mysql_connect($hostname , $username , $password)
or die("cannot make connection");
$db = mysql_selectdb($database , $connection)
or die("cannot find database");
$sql="select * from company, activity
where c_id = a_c_id and  

medivas = $poc and 
priority in ($prioritya, $priorityb, $priorityc) and 
a_date between $startdate and $enddate and 
c_name = $C_name";
//$query=mysql_query($sql) or die($sql);
echo $sql;
$numofrows = mysql_num_rows($query);
?>

If you want to see what I'm trying to do, its at
http://www.lukesplace.com/Padilla/createreport.php

[inerte]

You're getting this error because $query isn't defined when mysql_num_rows($query) is called. $query should be whatever mysql_query() returned. That's the invalid resource reason.

Anyway, you sql statement is probably not being executed because the variables inside aren't quoted. If $C_name has "John" on its value, PHP parses $C_name and your last line will be this: c_name = John

Now Mysql thinks that John is a column from a table. Or this part (your actual 1st post):

priority in (A, , )

You see, (A, , ) is wrong. It should be ('A', '', ''), these are empty values.

Anyway, just put single-quotes around your variables, it should work :p

[lukeurtnowski]

beautiful, thank you, that returned some records,. Now do I replace the dates with the variables $startdate and $enddate? (which works, thank you)

Also, heres the php code where I display the results,

    print "<TD><a href=showactivity.php?num=$result[c_id]&start=$GET_[startdate]&end=$GET[enddate]".$result['c_id']."</TD>"; 
    print "<TD>".$result['c_city'].", ".$result['c_state']."</TD>"; 
    print "<TD>".$result['c_desc']."</TD>"; 
    print "<TD>".$result['rationale']."</TD>"; 
    print "<TD>".$result['contact_name']."</TD>"; 
    print "<TD>".$result['contact_phone']."</td>"; 
    print "<TD>".$result['contact_title']."</TD>"; 
    print "<TD ALIGN=CENTER><b>".$result['priority']."</B></TD>"; 
    print "<TD>".$result['medivas']."</td>"; 

All the records print like the should except for the first one, do you know why?
Thanks soo much!