[RESOLVED] Code Review, Advice Request:

[Rodney_H_]

edited: sorry:

[halojoy]

Rodney H. wrote:

Hello: I have put together a little blog, and was wondering if you more experienced php-ers could make suggestions to make the code more functional, or symantically correct. I would appreciate any help or suggestions to make this work and more secure. Please and thank you!

PS. I do love those comments now, don't I ? ;-)

I have just downloaded a copy of your Blog.

questions:

1. What do I name this php? blog_rod.php maybe
   It is all in one page, isnt it? The True Beginners Way ... 😃
   ( personally I need like 4 pages, with all includes, to make a blog setup )

2. Does it work, and what happens, if I try to run it?

/halojoy
just about to something foolish or GOOD

😉

[Rodney_H_]

halojoy wrote:

I have just downloaded a copy of your Blog.

questions:

1. What do I name this php? blog_rod.php maybe
   It is all in one page, isnt it? The True Beginners Way ... 😃
   ( personally I need like 4 pages, with all includes, to make a blog setup )

2. Does it work, and what happens, if I try to run it?

Hello, Halojoy! Greetings to you. There is more to it than this one page. This is just the entry page. I have an edit page, a display page and an archive page. This does work and I have this file in my admin folder.

My admin structure is kind of silly but it is as follows:

1) admin/blog_entry/index.php (that is what this page is)
2) admin/blog_edit/index.php (menu of entries) & edit.php (with form and action)
3) admin/blog_comments_edit/index.php (menu of visitor comments) & edit.php

Then, in another directory that isn't secured by PHP sessions, I have the main blog directory:

1) blog/index.php (to display the last five entries)
2) blog/details.php (to show just one entry and user comments and have a form for visitor input)
3) blog/archive.php (a list of all entries by year, which when clicked, goes to the details page by id# in the url)

I hope that makes sense. But, yes, download it, tell me what you think. If you want the other files, I can zip them up and send them. Let me know...

[halojoy]

so,
this is blog/index.php

Quote:
I have put together a little blog, and was wondering
if you more experienced php-ers could make suggestions
1. ..... to make the code more functional,
2. ..... or symantically correct.

I would appreciate
3. ... any help
4. ... or suggestions
5. ... to make this work

6. ... and more secure.

That is a long list of help you need from us!
In just one thread.
Six ( 6 ) things we can do for you!

And this is only index.php startpage of your blog.
hmmmm ..

It is so much I do not even know where to start.

Maybe you should split this BLOG thing into 15 different topis/threads

/halojoy
🙂

[Rodney_H_]

LOL You crack me up! I would expect nothing less from you. As always, you are correct. I am, in a word (or two), without-words! :o

[halojoy]

When i study this php you posted,
it more looks like the admin - index.php

but who can tell?

<?php
/******
This is admin startpage 'admin/index.php'
of Rod's blog
Full Copyright and rights reserved by Rodney H.
Version: blog_rod-1.0.2beta
Date:     2005-07-15
*****/

// start session 
session_start(); 

// if no prior authentication was performed 
if (!$_SESSION['auth'] == 1) { 
// Redirect browser 
header("Location: ../index.php");  

// and exit 
exit;  

} 
// ELSE there is authentication 
//else { 

?>

[Rodney_H_]

I am not sure what you mean by that. Do you mean that I don't need to authenticate users on this page? (Sorry, I've been up all night and might not be thinking as clearly as I could be...) And isn't it LATE for you??

[halojoy]

I do not know what page it is?
That is what i mean.
My guess was admin/index.php

But who knows.

Anyway, when I have added SESSION auth = 1;
I get this:
Warning: main(../../inc/blog_hdr_long.php) [function.main]: failed to open stream: No such file or directory in /opt/lampp/htdocs/aaa-temp1/rodneyh/blogcode.php on line 20

Fatal error: main() [function.require]: Failed opening required '../../inc/blog_hdr_long.php' (include_path='.:/opt/lampp/lib/php') in /opt/lampp/htdocs/aaa-temp1/rodneyh/blogcode.php on line 20

My code I runat my experiment server:

<?php 
// start session 
session_start(); $_SESSION['auth'] = 1;
// if no prior authentication was performed 
if (!$_SESSION['auth'] == 1) { 
// Redirect browser 
header("Location: ../index.php");  

// and exit 
exit;  

} 
// ELSE there is authentication 
else { 
// Grab current time/date info from server 
$current_month = date("F"); 
$current_date = date("d"); 
$current_year = date("Y"); 
$current_hour = date("H"); 
$current_min = date("i"); 
// Header Include 
require("../../inc/blog_hdr_long.php"); 
?> 

<div id="sideNav"> 
<h2>Status</h2> 
<ul> 
<li>Logged in: <?php echo $_COOKIE['username']; ?></li> 
<li>&nbsp;</li> 
<li><a href="../logout.php">Click here to Log Out</a></li> 
</ul> 
</div> 
<div id="pageContents"> 
<h1 id="startcontent">Add Entry to the my_blog Blog</h1> 

[Rodney_H_]

Well, the error messages are from this bit: require("../../inc/blog_hdr_long.php");

you need that file, it is required for the page and has my doc type declaration, my style sheet, my javascript functions, my navigation system, etc... )It is my header.

1) Remove this: "require("../../inc/blog_hdr_long.php"); " entirely,

2) close the php tag "?>"

3) add this as a replacement for the required header ( that is not included in the code here)

<html>
<head>
<title>blog<title>
</head>

That should be enough to remove the fatal errors.

[halojoy]

yes,
I could do that. To replace headers.
But still I do not know if is rehular startpage ( to watch your blog )
or is admin index.php

well,
why should I bother with this.
you havent even told me what is wrong, what you want help with ...

there are 100reds of good php blog scripts out there.

right now my version of a downloaded blog script (no names mentioned)
looks like this:

halojoy ONLINE blog

uses flat files, of course, as data storage
to avoid some:
SELECT headache AND get worried FROM this mxxxx db program

/halojoy
sweden
flat and happy without any selected querieries problems

[Rodney_H_]

Halojoy:

I couldn't connect to your blog. I would like to see it, however, so I will try again.

You are right. There ARE hundreds of them out there. This is just for ME to see if I could do it. That is all. To make my own.

Don't bother, by any means, to trouble if you are not into helping. I just wanted to know if there was any shortcuts or tips to the coding that you could share.

Anyway, it is nice to talk to you, even if you are all the way over in Sweden.

[halojoy]

I setup your code (admin in blog)
so I got a look at your creation.

🙂
I am impressed!
I could not do this better (probably a bit worse, though)

Here is how it looks, without any styles:
Rodney H first blog DEMO

Responsable webmaster for DEMO is
halojoy
😉

[Rodney_H_]

Halojoy: I felt bad for asking you to look at the code when I really didn't have a specific problem. That is why I removed all my comments and code.

After our conversation on this forum yesterday, I spent the evening going over every line of code for the blog: every curly brace, every function, every array.

Thank you for following up with this and installing it on your server. I, too, have installed it on a server and did some testing this morning.

All I can say is IT WORKS!!

You are too kind. As I am sure you could do it much better, and are sacrificing your own knowledge while paying me a compliment.