[RESOLVED] mysql question

[lozza1978]

I have a news page which pulls the news articles from mysql like this

"SELECT * FROM tbl_news WHERE pressid = $_GET['pressid'];"

This code pulls all the news for the particular pressid, now what I would like to do is some how have the tbl_news be dynamic, I have another table in mysql called tbl_articles, and depending on which link the user presses depends on the sql query,

i surpose i need an if statement,

if $_GET['pressid'] == 1 OR 2 OR 3 OR 4; {
"SELECT * FROM tbl_news WHERE pressid = $_GET['pressid'];"
} else {
"SELECT * FROM tbl_articles WHERE artid = $_GET['artid'];"
}

Will this work ? and is there any better soultions,

cheers

[lozza1978]

ok i have an error on line 15

<?
//ip of server
$ip = "localhost";
//username for server
$user = "****";
//password for server
$pass = "****";
//databse we require to query
$db = "itrepair_webdb";
//connect to server or error
$conn = mysql_connect($ip,$user,$pass) or die("problem connecting to mysql server please EMAIL ADMIN<br>" . mysql_error());
//select the database or error
$selectdb = mysql_select_db($db,$conn) or die("problem selecting database please EMAIL ADMIN" . mysql_error());
//query the table or error!
$query1 = if ($_GET['pressid'] == '1' OR '2' OR '3' OR '4') { 
"SELECT * FROM tbl_news WHERE pressid = $_GET['pressid'];" 
} else { 
"SELECT * FROM tbl_articles WHERE artid = $_GET['artid'];" 
}  

// results for query or error
$results1 = mysql_query($query1) or die("problem with mysql query1 please EMAIL Webmaster" . mysql_error());

?>

line 15 =

$query1 = if ($_GET['pressid'] == '1' OR '2' OR '3' OR '4') { 

can anyone help me out ? thanks in advance

[laserlight]

$GET['pressid'] == '1' || $GET['pressid'] == '2'
not
$_GET['pressid'] == '1' OR 2

[lozza1978]

line 15 now looks like

$query1 = if ($_GET['pressid'] == '1' || $_GET['pressid'] == '2' || $_GET['pressid'] == '3' || $_GET['pressid'] == '4') {

Still getting a parse error on this line, any ideas?,

Thanks for the help Laser Light, much apreceaited.

[dalecosp]

You can't assign a conditional statement to a variable.

$foo=if (0); will create an error every time....

What you want would be more like

if($something) {
   $query="select * from table";
} else {
   $query="select * from other_table";
}

[dalecosp]

IOW, you have the $query1 in the wrong place . . .

[lozza1978]

Hi there thanks for the help, but i still have a parse error with the code you supplied. can anyone please help.
code.

<?
//ip of server
$ip = "localhost";
//username for server
$user = "****";
//password for server
$pass = "****";
//databse we require to query
$db = "itrepair_webdb";
//connect to server or error
$conn = mysql_connect($ip,$user,$pass) or die("problem connecting to mysql server please EMAIL ADMIN<br>" . mysql_error());
//select the database or error
$selectdb = mysql_select_db($db,$conn) or die("problem selecting database please EMAIL ADMIN" . mysql_error());
//query the table or error!

 if($_GET['pressid'] == '1' ||$_GET['pressid'] == '2' || $_GET['pressid'] == '3' ||
$_GET['pressid'] == '4') { 
   $query1 = "SELECT * FROM tbl_news WHERE pressid = $_GET['pressid'];"
}
if($_GET['artid'] == '1'){
   $query1="SELECT * FROM tbl_articles WHERE artid = $_GET['artid'];"  

} else {
require 'error.php';
exit();
}
?>

the error im getting is around line 18

code=phpif($GET['pressid'] == '1' ||$GET['pressid'] == '2' || $GET['pressid'] == '3' ||
$GET['pressid'] == '4') {
b[/b]$query1 = "SELECT * FROM tbl_news WHERE pressid = $_GET['pressid'];"
}[/code]

[dalecosp]

Hey now 😉 nothing wrong with the code I wrote, just the implementation: "unexpected T_ENCAPSED_AND_WHITESPACE" should give that away. You must escape from the doublequotes if you're going to use array items in your query string:

$query="Select * from tbl_news WHERE pressid = ". $GET['pressid'];

🙂

[lozza1978]

Thanks you very much, At the moment the remote server is down, so I can not try this till the morning,

will let you know how I get on and thanks again for the reply.

lozza1978

[lozza1978]

dalecosp wrote:

Hey now 😉 nothing wrong with the code I wrote, just the implementation: "unexpected T_ENCAPSED_AND_WHITESPACE" should give that away. You must escape from the doublequotes if you're going to use array items in your query string:

$query="Select * from tbl_news WHERE pressid = ". $GET['pressid'];

🙂

Hi There, Thanks for taking time out and helping a noob like me, The code you supplied worked perfectly,

Great Stuff