Upload File

cap97

I've been forced to be a real coder and write stuff with globals off for the first time, and I'm having problems with a form that has an option to upload an image. On the form I have a field like so:

<input type="file" name="userpic">

Then, in the script that processes the form's various info (all of which works except the blasted image), I have this:

if ($_FILES['userpic']) {
                echo "ya a pic!";
                exit;
}

Just to test whether a pic is passed or not. Unfortunately, it prints "ya a pic" everytime I hit submit, regardless of whether I've actually uploaded a pic or not. So I guess I'm missing something. Any ideas?

dnast

Make sure your form tag looks like this

<form enctype="multipart/form-data" action="__URL__" method="POST">

Also try something like this to test whether the file was uploaded.

if (!$_FILES['userpic']['error']) {

Or just check when you use [man]move_uploaded_file()[/man]. If it doesn't work then you know the file wasn't uploaded. Check out the page Handling File Upoads in the PHP manual. They give a good explanation on how to handle file uploads.

LoganK

A better idea would be to check for the existance of a name - a file obviously has to have a name, so if there is no name, no file was uploaded!

if ($_FILES['file']['name'] == null)
     die("No file uploaded!");
// File processing instructions

BTW, you should always program with register_globals turned off. It's more secure that way 🙂

cap97

LoganK wrote:
A better idea would be to check for the existance of a name - a file obviously has to have a name, so if there is no name, no file was uploaded!

Thanks, that worked!

LoganK wrote:
BTW, you should always program with register_globals turned off. It's more secure that way 🙂

Yeah and I always knew that, but never took the time to bite the bullet and learn how.

LoganK

You're welcome...it's really not that hard with register_globals turned off, just reference them as an array: $POST['name'] or $GET['page']. If you want to emulate the functioning of register_globals, use extract() to take every value of an array and create variables based on the key names...for example, if $POST has a key named "name" and a value of "Logan" ($POST['name'] == "Logan"), you could use extract($_POST) and a variable named "$name" will be created with value "Logan".