[RESOLVED] SQL File

talkster5

Hi,
I have an SQL file that I am trying to run and create the tables in my database but at the moment I can not get it to work. Most likley its something that needs to be changed in my code. Can you take a look at the code and tell me what I have wrong please.

<?php
//Get the required files.
$sql = include 'test.sql';

//Run the sql file to create the tables.
mysql_connect ("localhost", "user", "pass") or die ('I cannot connect to the database because: ' . mysql_error());
mysql_select_db ("database");
$query = mysql_query($sql);
if (!$query) {
   echo 'Could not run query: ' . mysql_error();
   exit;
}
?>

drew010

id try

<?php

$sql = "/full/path/to/test.sql";

mysql_connect("localhost", "user", "pass") or die("No connection");
mysql_select_db("database") or die("no select");

$res = mysql_query("\\. $sql");

if (!$res) {
  die(mysql_error());
} else {
  echo "successfully inserted data";
}

?>

alternatively you can use the LOAD DATA INFILE command... http://dev.mysql.com/doc/mysql/en/load-data.html

talkster5

Thans for the suggestion but that wont work as it thinks the $sql value is the patch and not what is actually in the file.

drew010

is the file a .sql file generated from mysql? if so the sql command to load it into a db from the mysql prompt is actually just ". sql.txt"

talkster5

drew010 wrote:
is the file a .sql file generated from mysql? if so the sql command to load it into a db from the mysql prompt is actually just ". sql.txt"

Yes it was generate through phpmyadmin. So I just put that in my mysql_query?

drew010

yeah
mysql_query("\. $sql");

talkster5

drew010 wrote:
yeah
mysql_query("\. $sql");

Doesnt seem to work.

drew010

$sql is set to the exact path of the .sql file right?

LoganK

Your line "$sql = include 'test.sql';" will give the result of the include() command. Since it includes files and processes them, it does not return the value of the file. Instead, it returns "1" if it was a success. Really, you're query the MySQL database for "1" 😃 I realized this once when I wrote a switch statement to define a file to include, and then typed "<?=include($include)?>" in the page. At the bottom of every page a "1" would appear.

Look up [man]file_get_contents/man.

talkster5

Thanks for that Logan. I will take a look at it.

LoganK

You're welcome. Post back with comments/questions/etc.

Weedpacket

If the SQL file contains multiple SQL statements, you'll need to run them through mysql_query one at a time. Either that or find a way to tell the DBMS itself to import the file.

LoganK

Can't you seperate multiple commands with semicolons? Isn't that the basis of SQL injection?

Weedpacket

Not through mysql_query, no (even the use of semicolons via the MySQL client is a client-side implementation; the SQL commands themselves are still sent to the DBMS one at a time). The basis of SQL injection is typically the use of ' characters to prematurely cut short a field's contents and allow adding further clauses to the query under construction.

talkster5

It worked fine with logans way without passing it through seperatley. My SQL file isn't actually that long which is probably the reason for it working.

LoganK

Weedpacket - I could've sworn I've seen books about SQL injection where the author typed in a field "; SELECT * FROM users". Maybe it's best not to argue with a mod 😃

Talkster - You're welcome. Mark the thread resolved please! 🙂

talkster5

LoganK wrote:
Talkster - You're welcome. Mark the thread resolved please! 🙂

I was trying to but I couldn't find the resolve thread button on this new theme.

laserlight

I was trying to but I couldn't find the resolve thread button on this new theme.

It's under the "Thread Tools" tab.

talkster5

laserlight wrote:
It's under the "Thread Tools" tab.

Ahh right, done.

LoganK

Edit: I was too slow. Oh well. Glad it worked out!