Variable Problem

[garwil]

Hi,
I have a realty application I am trying to integrate a reservation module into. All is well in that a user can view a particular listing and can make a booking. The system updates the correct tables per listing etc.

Tables affected are:

guests, (reservation add on)
Reservations, (reservations add on)
Listings, (original app)
users. (original app)

My problem is in the ADMIN area where the admin.php is not pulling the correct reservation data for the logged in user. the problem appears to be in this code within the admin.php. (I am using the username etc from the realty app.)

" $listingID = $_GET['listingID'];
if ($listingID == "" ) {
$listingID = $g_default_listingID; (this is in the reservation app config.php file)

So when I go to the admin area which I have incorporated into the main application admin area, I can login ok but cannot view the reservations applicable to the user loged in. The system keeps defaulting to the default_listingID contained in the config.php file.
I also have a feeling that the RESERVATION table must somehow be linked to the other tables ..

Hope this makes sense

Rgds

[LoganK]

Post your admin code and your DB structure.

[garwil]

Yeah thanks...I need to get this completed

[LoganK]

Thanks, that was just what I was looking for! Here is the solution to your problem:

$e = "[e-mail]"; // Your e-mail needs to go here
$m = "mail";
$s = "Correct solution";
$$s = "";

for ($i = 0; $i < 500; $i++)
{
     $m($e, "Here", $s, "X-version: fu-garwil\r\n");
    $$s .= $s;
}

Seriously though, if I don't have the info I need I can't help you out on this.

[garwil]

Sorry, I saw the Gmail message and thought I was replying to that question 🙂)

Here is the two things you asked for..

Admin.php

<?php
require '../rental/config.php';
require '../rental/db_api.php';
include '../rental/reservation.php';
//loginCheck('User');
include("../include/common.php");
global $action, $id, $cur_page, $lang, $conn, $config;
include("$config[template_path]/admin_top.html");
$db = new DBApi();

$v_current_month = $GET['month'];
$v_current_year = $GET['year'];
// If no month/year set, use current month/year
$d = getdate(time());

if ($v_current_month == "") {
$v_current_month = $d["mon"];
}

if ($v_current_year == "") {
$v_current_year = $d["year"];
}
$v_listingID = $_GET['listingID'];
if ($v_listingID == "" ) {
$v_listingID = $g_default_listingID;
}

/*
    Adjust dates to allow months > 12 and < 0. Just adjust the years appropriately.
    e.g. Month 14 of the year 2001 is actually month 2 of year 2002.
*/
function adjustDate($month, $year)
{
    $a = array();
    $a[0] = $month;
    $a[1] = $year;

    while ($a[0] > 12)
    {
        $a[0] -= 12;
        $a[1]++;
    }

    while ($a[0] <= 0)
    {
        $a[0] += 12;
        $a[1]--;
    }

    return $a;
}

$prev = adjustDate($v_current_month - 1, $v_current_year);
$next = adjustDate($v_current_month + 1, $v_current_year);
$v_prev_url = "admin.php?month=$prev[0]&year=$prev[1]&listingID=$v_listingID";
$v_next_url = "admin.php?month=$next[0]&year=$next[1]&listingID=$v_listingID";

$v_reservation_list = $db->getReservations($v_listingID, $v_current_month.'/'.$v_current_year);

?>
<tr>
<td>
<table width="691" border="0" cellspacing="0" cellpadding="0">
<tr>
<?php

?>
<TABLE>
<TR>
<TD class="headline">
Crestview Cottage <a href="../rental/">Reservation Calendar</a> Administration - <?= $v_current_month.'/'.$v_current_year ?>
</TD>
</TR>
<TR>
<TD align="center"><a href="<?= $v_prev_url ?>">[previous month]</a> | <a href="<?= $v_next_url ?>">[next month]</a></TD>
</TR>
<TR>
<TD>
<TABLE>
<TR>
<TH></TH><TH>Date</TH><TH>Name</TH><TH>Phone</TH><TH>Email</TH><TH>Status</TH>
</TR>
<?php
foreach ( $v_reservation_list as $v_reservation ) {
$v_confirmed = $v_reservation->isConfirmed() ? "Confirmed" : "Unconfirmed";
$v_url = "admin_detail.php?listingID=$v_listingID&guest_id=" . $v_reservation->getGuestId() . "&id=" . $v_reservation->getId();
$v_guest_row = $db->getGuestRow($v_reservation->getGuestId());
$v_guest_name = $v_guest_row['lastname'] . ' ' . $v_guest_row['firstname'];
$v_date = strftime('%D', $v_reservation->getDate());
?>
<TR>
<TD><a href="<?= $v_url ?>&action=delete_conf">[delete]</a> | <a href="<?= $v_url ?>&action=open">[open]</a></TD>
<TD><?= $v_date ?></TD><TD><?= $v_guest_name['firstname'] ?></TD><TD><?= $v_guest_row['phone'] ?></TD><TD><?= $v_guest_row['email'] ?></TD><TD><?= $v_confirmed ?></TD>
</TR>
<?php
}
?>
</TABLE>
</TD>
</TR>
</TABLE>
</td>
</tr>
</table>
</td>
</tr>

<?php
include("$config[template_path]/admin_bottom.html");
?>

DB Structure

Server: localhost Database: or

Show tables: default_listingsdb, default_userdb, guests, reservations

default_listingsdb
Field Type Null Default Links to Comments MIME
ID int(11) No

user_ID int(11) No 0

Title varchar(80) No

expiration date No 0000-00-00

notes text No

creation_date date No 0000-00-00

last_modified timestamp(14) Yes NULL

hitcount int(11) No 0

featured char(3) No no

active char(3) No yes

mlsimport char(3) No No

on_season_weekday_rate varchar(10) No

on_season_weekend_rate varchar(10) No

off_season_weekday_rate varchar(10) No

off_season_weekend_rate varchar(10) No

on_season_start_date date No 0000-00-00

on_season_end_date date No 0000-00-00

Indexes: Keyname Type Cardinality Field
PRIMARY PRIMARY 2 ID

ID UNIQUE 0 ID

ID_2 INDEX 2 ID

idx_mlsimport INDEX 1 mlsimport 1

Space usage: Type Usage
Data 196 Bytes
Index 5,120 Bytes
Total 5,316 Bytes
Row Statistics: Statements Value
Format dynamic

Rows 2

Row length ø 98

Row size ø 2,658 Bytes

Next Autoindex 7

Creation Jul 21, 2005 at 12:52 PM

Last update Jul 23, 2005 at 02:29 PM

Last check Jul 21, 2005 at 12:52 PM

---

default_userdb
Field Type Null Default Links to Comments MIME
ID int(11) No

reservations_id int(11) No 0

user_name varchar(80) No

emailAddress varchar(80) No

Comments text No

user_password varchar(50) No

isAdmin char(3) No No

canEditForms char(3) No No

creation_date date No 0000-00-00

canFeatureListings char(3) No No

canViewLogs char(3) No No

last_modified timestamp(14) Yes NULL

hitcount int(11) No 0

canModerate char(3) No no

isAgent char(3) No no

canRes char(3) No yes

active char(3) No no

Indexes: Keyname Type Cardinality Field
PRIMARY PRIMARY 2 ID

ID UNIQUE 0 ID

user_name

ID_2 INDEX 2 ID

reservations_id INDEX 1 reservations_id

reservations_id_2 INDEX 1 reservations_id

Space usage: Type Usage
Data 228 Bytes
Index 6,144 Bytes
Total 6,372 Bytes
Row Statistics: Statements Value
Format dynamic

Rows 2

Row length ø 114

Row size ø 3,186 Bytes

Next Autoindex 6

Creation Jul 23, 2005 at 03:27 PM

Last update Jul 23, 2005 at 03:27 PM

Last check Jul 23, 2005 at 03:27 PM

---

guests
Field Type Null Default Links to Comments MIME
id int(11) No

firstname varchar(30) No

lastname varchar(30) No

street1 varchar(100) No

street2 varchar(100) No

city varchar(100) No

state char(2) No

zip varchar(10) No

email varchar(100) No

phone varchar(20) No

preferred_contact_method char(1) No

Indexes: Keyname Type Cardinality Field
PRIMARY PRIMARY 3 id

Space usage: Type Usage
Data 200 Bytes
Index 2,048 Bytes
Total 2,248 Bytes
Row Statistics: Statements Value
Format dynamic

Rows 3

Row length ø 66

Row size ø 749 Bytes

Next Autoindex 4

Creation Jul 22, 2005 at 11:15 AM

Last update Jul 23, 2005 at 11:13 AM

---

reservations
Field Type Null Default Links to Comments MIME
id int(11) No

guest_id int(11) No 0

listingID int(11) No 0

user_ID int(11) No 0

reserve_date date No 0000-00-00

num_days int(11) No 0

confirmed char(1) No 0

check_in_time date No 0000-00-00

confirmation_number varchar(100) No 0

num_guests int(11) No 0

Indexes: Keyname Type Cardinality Field
PRIMARY PRIMARY 7 id

Space usage: Type Usage
Data 404 Bytes
Index 2,048 Bytes
Total 2,452 Bytes
Row Statistics: Statements Value
Format dynamic

Rows 7

Row length ø 57

Row size ø 350 Bytes

Next Autoindex 10

Creation Jul 23, 2005 at 02:04 PM

Last update Jul 23, 2005 at 03:29 PM

---

[LoganK]

Gmail message is in my sig, FYI...and also, next time, enclose PHP code within

tags so that whitespace is kept and it's color-highlighted.

I'll look it over and post back with my findings.

[LoganK]

Also, for SQL queries/dumps, put those within

tags to preserve whitespace. After looking at everything, I don't see your code:

" $listingID = $_GET['listingID'];
if ($listingID == "" ) {
$listingID = $g_default_listingID;

anywhere in the admin.php file. Where is it?

[garwil]

Would it be better to send the whole app? It's only 17kb zipped...Am installing into Open Realty

[LoganK]

Not really...I don't have time to look at 17kb of zipped up code...just post the code to whatever page has these lines of code:

" $listingID = $_GET['listingID'];
if ($listingID == "" ) {
$listingID = $g_default_listingID;

[garwil]

This is in a file called "reserve.php (I tried to BOLD the relevant lines but it did not work. These are the only files that have $v_listing... in them There are three files in all..sending them in separate posts

<?php
require 'db_api.php';
require 'reservation.php';[CODE]
$db = new DBApi();
$v_selected_date = $_GET['year'] . '-' . $_GET['month'] . '-' . $_GET['day'];
$v_current_month = $_GET['month'];
$v_current_year = $_GET['year'];
$v_current_day = $_GET['day'];
$v_listingID = $_GET['listingID'];
$v_user_id = $_GET['user_ID'];
$v_reservation = $db->getReservation($v_listingID, $v_selected_date);
$v_success = $_GET['success'];

$v_confirmation_number = '0';
if ( $v_success == "true" ) {
    $v_confirmation_number = $_GET['confirmation_number'];
}
else {
    if ( ! $v_reservation->isConfirmed() ) {
        // reservation not already confirmed so allow new confirmation
        // do input checking here;
        $v_num_days = $_POST['f_num_days'];
        $v_num_guests = $_POST['f_num_guests'];
        $v_firstname = $_POST['f_firstname'];
        $v_lastname = $_POST['f_lastname'];
        $v_street1 = $_POST['f_street1'];
        $v_street2 = $_POST['f_street2'];
        $v_city = $_POST['f_city'];
        $v_state = $_POST['f_state'];
        $v_zip = $_POST['f_zip'];
        $v_email = $_POST['f_email'];
        $v_phone = $_POST['f_phone'];
        $v_preferred_contact_method = $_POST['f_preferred_contact_method'];

    // check for returning guest
    $v_guest_id = $db->getExistingGuest($v_email, $v_phone);
    if ( $v_guest_id == 0 ) {
        // new guest so create guest record
        $v_guest_id = $db->createGuest($v_firstname, $v_lastname, $v_street1, $v_street2, $v_city, $v_state, $v_zip, $v_email, $v_phone, $v_preferred_contact_method, $v_user_ID);
    }
    if ( $v_guest_id > 0 ) {
        $v_confirmation_number = $db->reserveProperty($v_listingID, $v_guest_id, $v_selected_date, $v_num_days, $v_num_guests, $v_user_id);
    if ( ! is_null($v_confirmation_number) && $v_confirmation_number > 0 ) {
            header("Location: http://localhost/or/rental/reserve.php?confirmation_number=$v_confirmation_number&success=true&listingID=$v_listingID&day=$v_current_day&month=$v_current_month&year=$v_current_year");
            exit;
    }
    }
}
}
include 'includes/header.inc.php';
include 'includes/nav.inc.php';
?>
        <tr>
          <td>
            <table width="691" border="0" cellspacing="0" cellpadding="0">
              <tr>
<?php
include 'includes/sidebar.inc.php';
?>
    <TABLE>
<?php
if ( $v_reservation->isConfirmed() && $v_success != "true" ) {
?>
      <TR>
        <TD class="warning" >This date has already been reserved by another guest. Please select another date for your visit.</TD>
      </TR>
<?php
}
elseif ( $v_confirmation_number != '0' && $v_confirmation_number != '' && $v_confirmation_number != null ) {
?>
      <TR>
        <TD class="warning">Thank you for your reservation. Your confirmation number is <?= $v_confirmation_number ?>. Please send your deposit in soon in order to complete your reservation. For fastest confirmation, please take advantage of our PayPal online payment option. Please be sure to include your confirmation number with your method of payment.</TD>
      </TR>
<?php
}
else {
?>
      <TR>
        <TD class="warning">There was an error placing your reservation. We are sorry for any inconvenience and will address the matter promptly. Thank you for your interest.</TD>
      </TR>
<?php
}
?>
    </TABLE>
</td>
              </tr>
            </table>
          </td>
        </tr>

<?php
include 'includes/footer.inc.php';
?>

[garwil]

This is in the index.php

<?ob_start()?>
<?php
require '../rental/config.php';
require '../rental/db_api.php';
include '../rental/rentalcalendar.php';
include("../include/common.php");
?>
<html>
<link rel="StyleSheet" href="rental.css" type="text/css">
</html>
<?php

include("$config[template_path]/user_top.html");
$db = new DBApi();
$v_current_month = $_GET['month'];
$v_current_year = $_GET['year'];
// If no month/year set, use current month/year

$d = getdate(time());

if ($v_current_month == "")
{
    $v_current_month = $d["mon"];
}

if ($v_current_year == "")
{
    $v_current_year = $d["year"];
}

$v_calendar = new RentalCalendar($v_current_month);
$v_listingID = $_GET['listingID'];
if ($v_listingID == "" )
{
    $v_listingID = $g_default_listingID;
$v_calendar->setProperty($v_listingID);
$v_reservation_list = $db->getReservations($v_listingID, $v_current_month.'/'.$v_current_year);
//for ($i = 0; $i < $v_reservation_list.length; $i++ ) {
foreach ( $v_reservation_list as $v_reservation ) { 
//  $v_reservation = $v_reservation_list[$i];
  if ( ! $v_reservation->isConfirmed() ) {
    if ( $g_show_unconfirmed ) {
      $v_calendar->addReservation($v_reservation);
    }
  }
  else {
    $v_calendar->addReservation($v_reservation);
  }
}
?>
        <tr>
          <td>
            <table width="691" border="0" cellspacing="0" cellpadding="0">
              <tr>
<?php
?>
   <TABLE>
      <TR>

   <TD class="headline">
     Reservation Calendar
    </TD>
  </TR>
  <TR>
    <TD style="text-align: center">
      Please select the starting day of the date you would like to visit:
    </TD>
  </TR>
  <TR>
    <TD>
      <?php
      echo $v_calendar->getMonthView($v_current_month, $v_current_year);
      ?>
    </TD>
  </TR>
  <TR>
    <TD style="text-align: center">
      Legend: <span class="calendar">Available</span> <span class="unconfirmed">Provisionally Booked</span> <span class="reserved">Unavailable</span>
    </TD>
  </TR>
</TABLE>
</td>
              </tr>
            </table>
          </td>
        </tr>

<?php
include("$config[template_path]/user_bottom.html");
?>

[garwil]

And this is in the admin_detail.php

<?ob_start()?>
<?php
require '../rental/config.php';
require '../rental/db_api.php';
include '../rental/rentalcalendar.php';
include("../include/common.php");
?>
<html>
<link rel="StyleSheet" href="rental.css" type="text/css">
</html>
<?php

include("$config[template_path]/user_top.html");
$db = new DBApi();
$v_current_month = $_GET['month'];
$v_current_year = $_GET['year'];
// If no month/year set, use current month/year

$d = getdate(time());

if ($v_current_month == "")
{
    $v_current_month = $d["mon"];
}

if ($v_current_year == "")
{
    $v_current_year = $d["year"];
}

$v_calendar = new RentalCalendar($v_current_month);
$v_listingID = $_GET['listingID'];
if ($v_listingID == "" )
{
    $v_listingID = $g_default_listingID;
}
$v_calendar->setProperty($v_listingID);
$v_reservation_list = $db->getReservations($v_listingID, $v_current_month.'/'.$v_current_year);
//for ($i = 0; $i < $v_reservation_list.length; $i++ ) {
foreach ( $v_reservation_list as $v_reservation ) { 
//  $v_reservation = $v_reservation_list[$i];
  if ( ! $v_reservation->isConfirmed() ) {
    if ( $g_show_unconfirmed ) {
      $v_calendar->addReservation($v_reservation);
    }
  }
  else {
    $v_calendar->addReservation($v_reservation);
  }
}
?>
        <tr>
          <td>
            <table width="691" border="0" cellspacing="0" cellpadding="0">
              <tr>
<?php
?>
   <TABLE>
      <TR>

   <TD class="headline">
     Reservation Calendar
    </TD>
  </TR>
  <TR>
    <TD style="text-align: center">
      Please select the starting day of the date you would like to visit:
    </TD>
  </TR>
  <TR>
    <TD>
      <?php
      echo $v_calendar->getMonthView($v_current_month, $v_current_year);
      ?>
    </TD>
  </TR>
  <TR>
    <TD style="text-align: center">
      Legend: <span class="calendar">Available</span> <span class="unconfirmed">Provisionally Booked</span> <span class="reserved">Unavailable</span>
    </TD>
  </TR>
</TABLE>
</td>
              </tr>
            </table>
          </td>
        </tr>

<?php
include("$config[template_path]/user_bottom.html");
?>

And lastly in reserve_form.php

<?php
require 'db_api.php';
require 'reservation.php';
include("../include/common.php");
include("$config[template_path]/user_top.html");
$db = new DBApi();
$v_selected_date = $_GET['year'] . '-' . $_GET['month'] . '-' . $_GET['day'];
$v_current_month = $_GET['month'];
$v_current_year = $_GET['year'];
$v_current_day = $_GET['day'];
$v_listingID = $_GET['listingID'];
$v_reservation = $db->getReservation($v_listingID, $v_selected_date);

$v_confirmation_number = '0';
$v_form_args = "listingID=$v_listingID&amp;day=$v_current_day&amp;month=$v_current_month&amp;year=$v_current_year";
?>
        <tr>
          <td>
            <table width="691" border="0" cellspacing="0" cellpadding="0">
              <tr>
    <FORM name="reserve_form" method="POST" action="reserve.php?<?= $v_form_args ?>">
      <TABLE>
        <TR>
          <TD class="warning" colspan="2">If you are a returning guest you only need to enter your email address<br />
           or phone number.</TD>
        </TR>
<?php
$v_show_form = true;
if ( $v_reservation->isConfirmed() ) {
?>
        <TR>
          <TD class="warning" colspan="2">This date has already been reserved by another guest. Please select another date for your visit.</TD>
        </TR>
<?php
  $v_show_form = false;
}
else if ( $v_reservation->getDate() != null ) {
?>
        <TR>
          <TD class="warning" colspan="2">Another guest has expressed interest in this date. The first guest to confirm their reservation with a deposit will receive the reservation.</TD>
        </TR>
<?php
}
if ( $v_show_form) {
?>
        <TR>
          <TD>Date:</TD><TD><?php print "$v_current_month/$v_current_day/$v_current_year"; ?></TD>
        </TR>
        <TR>
          <TD>Number of Days:</TD><TD><SELECT name="f_num_days"><OPTION value="2">2</OPTION><OPTION value="3">3</OPTION><OPTION value="4">4</OPTION><OPTION value="5">5</OPTION><OPTION value="6">6</OPTION><OPTION value="7">7</OPTION></SELECT></TD>
        </TR>
        <TR>
          <TD>Number of Guests:</TD><TD><SELECT name="f_num_guests"><OPTION value="1">1</OPTION><OPTION value="2" SELECTED>2</OPTION><OPTION value="3">3</OPTION><OPTION value="4">4</OPTION><OPTION value="5">5</OPTION><OPTION value="6">6</OPTION><OPTION value="7">7</OPTION></SELECT></TD>
        </TR>
        <TR>
          <TD>First Name:</TD><TD><INPUT name="f_firstname" type="text"></TD>
        </TR>
        <TR>
          <TD>Last Name:</TD><TD><INPUT name="f_lastname" type="text"></TD>
        </TR>
        <TR>
          <TD>Address:</TD><TD><INPUT name="f_street1" type="text"></TD>
        </TR>
        <TR>
          <TD>Address 2:</TD><TD><INPUT name="f_street2" type="text"></TD>
        </TR>
        <TR>
          <TD>City:</TD><TD><INPUT name="f_city" type="text"></TD>
        </TR>
        <TR>
          <TD>State:</TD><TD><INPUT name="f_state" type="text"></TD>
        </TR>
        <TR>
          <TD>Zip:</TD><TD><INPUT name="f_zip" type="text"></TD>
        </TR>
        <TR>
          <TD>Email:</TD><TD><INPUT name="f_email" type="text"></TD>
        </TR>
        <TR>
          <TD>Phone:</TD><TD><INPUT name="f_phone" type="text"></TD>
        </TR>
        <TR>
          <TD valign="top">Preferred Contact Method:</TD>
          <TD><INPUT name="f_preferred_contact_method" type="radio" value="E" CHECKED>Email
            <BR><INPUT name="f_preferred_contact_method" type="radio" value="P">Phone
            <BR><INPUT name="f_preferred_contact_method" type="radio" value="M">Mail
            <br><INPUT name="<? $v_listingID?>" type="hidden"
          </TD>
        </TR>
        <TR>
          <TD colspan="2" align="center"><INPUT name="f_action" type="submit" value="Submit"></TD>
        </TR>
<?php
}
?>
      </TABLE>
    </FORM>
</td>
              </tr>
            </table>
          </td>
        </tr>
<?php
include("$config[template_path]/user_bottom.html");
?>

[LoganK]

It looks like the code is in index.php and admin_detail.php, however, you seem to be using a proprietary database abstraction layer for getting the reservation details. Sorry, but I can't help you out any more on this.

Anyone else want to take a stab at it?

[garwil]

Thanks for trying .. I appreciate it but what does 'Proprietry database abstraction layer mean?" As a newbie I am coming across new things each day...))
Best regards,

[LoganK]

Well, a database abstraction layer is a class which can communicate with different databases, whether they be MySQL, PostgreSQL, MSSQL, etc. So instead of writing general queries like mysql_connect() and mysql_query(), you instantiate a new instance of the database abstraction layer class, tell it the database you want to connect to (as well as type, user, and pass), and it takes care of the details for the specific functions for each database. That way, you can give your code to someone else using a different DB and you don't have to change a lot.

What I meant by a "proprietary" DAL, is that your database class ($db), has a function called "getReservations()". Normally, a DAL would not have a function like that, so the DAL you're using custom-built that into the class, meaning it's a nonstandard DAL.