mysql_select_db() problem...

General_Nuisanc

hey guys we just cant figure this error out it makes no sense.. this is error we getting

Warning: mysql_select_db(): supplied argument is not a valid MySQL-Link resource in C:\www\webroot\addbestscoretest.php on line 38

this is the code:

<html><body>
<?php 
$self = $_SERVER['PHP_SELF'];
$player_name = $_POST['player_name'];
$date = $_POST['date'];
$score = $_POST['score'];
$ss = $_POST['ss'];
$submit = $_POST['submit'];

//The Form//

$form = "<form action='$self' method='post'>";
$form.="The Players Name: <input type='text' name='player_name' ";
$form.="size='50' value='$player_name'> <BR> ";
$form.="The Date: <input type='text' name='date' ";
$form.="size='10' value='$date'> <BR> ";
$form.="The Players Score: <input type='text' name='score' ";
$form.="size='10' value='$score'> <BR> ";
$form.="The Picture: <input type='file' name='ss' ";
$form.="size='20'> value='$ss'> <BR> ";
$form.="<input type='submit' name='submit' ";
$form.="value='Submit Score'> </form>";

//on open display form//
if( !$submit) { $msg = $form; }

//or display a notice that form is in complete//
else if( !$player_name or !$date or !$score or !$ss)
{ $msg = "<b>Please Complete All Fields</b><br><br>";
$msg.= $form; }

//or add the data to mysql//
else
{ $conn = mysql_connect( "localhost", "root", "MY PASS" ) or die( mysql_error());}

// Select DB//

mysql_select_db( "nova-zone", $conn ) or die ( mysql_error( ) );

//create the query//
if( $player_name and $date and $score and $ss )
{
$sql ="insert into best_scores (player_name, date, score, ss) values('$player_name','$date','$score',$ss')";
$rs = mysql_query( $sql, $conn ) or die (mysql_error()); }

//confirm entry and display TY page//

if( isset( $rs ) )
{ $msg = "<h3>Thank You - Your entry has been added to our database.</h3>";
}

//Write the Page//

echo( $msg );
?>
</body></html>

thanks in advanced

hitman6003

Try changing from double to single quotes:

From

mysql_select_db( "nova-zone", $conn )

mysql_select_db('nova-zone',$conn )

General_Nuisanc

nope same error

drew010

well it was hard for me to see because of the way the indentation is and how the curly braces are placed but here it what is wrong.

the two lines

else
{ $conn = mysql_connect( "localhost", "root", "MY PASS" ) or die( mysql_error());}

seem to be executed if the $submit variable is not 0 or false AND $player_name $ss $score and $date are all not 0 or false, but then the brace is closed. so it appears you are ALWAYS trying to select the db with that link no matter what part the script is in, (showing the form or trying to validate data.

probably the cleaner way to do this is:

//on open display form//
if( !isset($submit)) { 
  $msg = $form;
} else if (!empty($player_name) AND !empty($date) AND !empty($score) AND !empty($ss)) {
  //or display a notice that form is in complete//
  $msg = "<b>Please Complete All Fields</b><br><br>";
  $msg.= $form; 
} else {
  //or add the data to mysql//
  $conn = mysql_connect( "localhost", "root", "MY PASS" ) or die( mysql_error());

  mysql_select_db( "nova-zone", $conn ) or die ( mysql_error( ) ); 

  //insert stuff here..................
}

General_Nuisanc

that got it exept for the } at the of this line

mysql_select_db( "nova-zone", $conn ) or die ( mysql_error( ) );

had to put a } at the end.. other wise i got parse error line 47...

and i had a extra > on the file upload line..

thanks guys!

General_Nuisanc

another problem..

when i enter all info and hit submit it goes to a blank page no error or anything..

and it does NOT submit to mysql. i checked.
this is the current code..

<html><body>
<?php 
$self = $_SERVER['PHP_SELF'];
$player_name = $_POST['dfx_player_name'];
$date = $_POST['dfx_date'];
$score = $_POST['dfx_score'];
$ss = $_POST['dfx_ss'];
$submit = $_POST['submit'];

//The Form//

$form = "<form action='$self' method='post'>";
$form.="The Players Name: <input type='text' name='player_name' ";
$form.="size='50' value='$player_name'> <BR> ";
$form.="The Date: <input type='text' name='date' ";
$form.="size='10' value='$date'> <BR> ";
$form.="The Players Score: <input type='text' name='score' ";
$form.="size='10' value='$dfx_score'> <BR> ";
$form.="The Picture: <input type='file' name='ss' ";
$form.="size='20' value='$ss'> <BR> ";
$form.="<input type='submit' name='submit' ";
$form.="value='Submit Score'> </form>";

//on open display form// 
if( !isset($submit)) {  

  $msg = $form; 
} else if (!empty($player_name) AND !empty($date) AND !empty($score) AND !empty($ss)) { 
  //or display a notice that form is in complete// 
  $msg = "<b>Please Complete All Fields</b><br><br>"; 
  $msg.= $form;  

} else { 
//or add the data to mysql// 
  $conn = mysql_connect( "localhost", "root", "MY PASS" ) or die( mysql_error()); 

  mysql_select_db( "nova-zone", $conn ) or die ( mysql_error( ) ); } 

//create the query// 
if( $player_name and $date and $core and $ss ) 
{ 
$sql ="insert into best_scores (player_name, date, score, ss) values('$player_name','$date','$score',$ss')"; 
$rs = mysql_query( $sql, $conn ) or die (mysql_error()); }

//confirm entry and display TY page//

if( isset( $rs ) )
{ $msg = "<h3>Thank You - Your entry has been added to our database.</h3>";
}

//Write the Page//

echo( $msg );
?>
</body></html>

drew010

its probably getting to the query part fine but the query fails because its missing a '
$sql ="insert into best_scores (player_name, date, score, ss) values('$player_name','$date','$score',$ss')";
you need it to be
$sql ="insert into best_scores (player_name, date, score, ss) values('$player_name','$date','$score','$ss')";

General_Nuisanc

still a blank page.. no errors

drew010

try putting echos in different places to see where it gets and where it doesnt. then maybe you can find where the problem is.