show tables by loop(while)

rahaiffi

i try to show all the data from database by using loop(while)...Before that,i successful show the data selected by ID..

Coding to show data selected by ID

<html>
<head>
<title>Untitled Document</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>

<body>
<table width="100%" border="0">
  <tr> 
    <td>&nbsp;</td>
  </tr>
  <tr> 
    <td> 
      <?
include 'dbase.php';

$query = "SELECT * FROM keputusan WHERE id = '$id'";
$result = mysql_db_query($dbname,$query);

$row = mysql_fetch_array($result) ;
$keputusan = $row["keputusan"];
$kenderaan = $row["kenderaan"];
$pemandu = $row["pemandu"];
$pegawai = $row["pegawai"];
$jawatan = $row["jawatan"];
$tarikh2 = $row["tarikh2"];
$masa2 = $row["masa2"];

$query2 = "SELECT nama FROM mohon
			WHERE id = '$id'";
$result2 = mysql_db_query($dbname,$query2);
$row2 = mysql_fetch_array($result2);
$nama = $row2["nama"];
?>
      <table width="100%" border="0">
        <tr>
          <td width="29%"><strong><font color="#FF0033" size="2">Nama : </font></strong></td>
          <td width="71%"><?  echo "$nama"; ?></td>
        </tr>
        <tr>
          <td><strong><font color="#666666" size="2">Keputusan Permohonan : </font></strong></td>
          <td>
            <?  echo "$keputusan"; ?>
          </td>
        </tr>
        <tr>
          <td><strong><font color="#666666" size="2">No Kenderaan :</font></strong></td>
          <td><? echo "$kenderaan"; ?></td>
        </tr>
        <tr>
          <td><font size="2"><strong><font color="#FF0033">Nama Pemandu</font>: 
            </strong></font></td>
          <td>
            <?  echo "$pemandu"; ?>
          </td>
        </tr>
        <tr>
          <td><strong><font color="#666666" size="2">Nama Pegawai : </font></strong></td>
          <td><? echo "$pegawai"; ?></td>
        </tr>
        <tr>
          <td><strong><font color="#666666" size="2">Jawatan Pegawai :</font></strong></td>
          <td><? echo "$jawatan";?></td>
        </tr>
        <tr>
          <td><strong><font color="#666666" size="2">Tarikh / Masa :</font></strong></td>
          <td><? echo "$tarikh2 / $masa2"; ?></td>
        </tr>
        <tr>
          <td>

      </td>
      <td>&nbsp;</td>
    </tr>
  </table> </td>
  </tr>
</table>
</body>
</html>

This is coding i try to show all data using loop(while) but it failed...

<html>
<head>
<title>Untitled Document</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>

<body>
<table width="100%" border="0">
  <tr> 
    <td>&nbsp;</td>
  </tr>
  <tr> 
    <td> 
      <?
include 'dbase.php';

$query = "SELECT * FROM keputusan";
$result = mysql_db_query($dbname,$query);

while($row = mysql_fetch_array($result)) {
$keputusan = $row["keputusan"];
$kenderaan = $row["kenderaan"];
$pemandu = $row["pemandu"];
$pegawai = $row["pegawai"];
$jawatan = $row["jawatan"];
$tarikh2 = $row["tarikh2"];
$masa2 = $row["masa2"];

$query2 = "SELECT nama FROM mohon";
$result2 = mysql_db_query($dbname,$query2)

while($row2 = mysql_fetch_array($result2)) {
$nama = $row2["nama"];
?>
      <table width="100%" border="0">
        <tr>
          <td width="29%"><strong><font color="#FF0033" size="2">Nama : </font></strong></td>
          <td width="71%"><?  echo "$nama"; ?></td>
        </tr>
        <tr>
          <td><strong><font color="#666666" size="2">Keputusan Permohonan : </font></strong></td>
          <td>
            <?  echo "$keputusan"; ?>
          </td>
        </tr>
        <tr>
          <td><strong><font color="#666666" size="2">No Kenderaan :</font></strong></td>
          <td><? echo "$kenderaan"; ?></td>
        </tr>
        <tr>
          <td><font size="2"><strong><font color="#FF0033">Nama Pemandu</font>: 
            </strong></font></td>
          <td>
            <?  echo "$pemandu"; ?>
          </td>
        </tr>
        <tr>
          <td><strong><font color="#666666" size="2">Nama Pegawai : </font></strong></td>
          <td><? echo "$pegawai"; ?></td>
        </tr>
        <tr>
          <td><strong><font color="#666666" size="2">Jawatan Pegawai :</font></strong></td>
          <td><? echo "$jawatan";?></td>
        </tr>
        <tr>
          <td><strong><font color="#666666" size="2">Tarikh / Masa :</font></strong></td>
          <td><? echo "$tarikh2 / $masa2"; ?></td>
        </tr>
        <tr>
          <td><?
				}
				?>

			<?
			}
			?>

      </td>
      <td>&nbsp;</td>
    </tr>
  </table> </td>
  </tr>
</table>
</body>
</html>

vaaaska

I'm not sure why you have two queries...I'm pretty sure you can get all your data in just one query. You might however, if you have overlapping field names, need to specify them more appropriately.

Generally, and this is just my preference, I try to do all my PHP before I get to the actual html - and them simply echo it out. I'm told this is faster, but I'm not 100% sure about that. I also normally use an html class so I don't have to write any (or much) html...don't have that benefit here though. Anyways, this is how I would do the same:

<? 
include 'dbase.php';

$query = "SELECT * FROM keputusan,mohon WHERE mohon.id = '$id' AND keputusan.id = mohon.id"; 
$result = mysql_db_query($dbname,$query); 
$row = mysql_fetch_array($result);

$s = '';

foreach ($row as $out) {

$s. = "<table width='100%' border='0'>\n<tr>\n";
$s. = "<td width='29%'><strong><font color='#FF0033' size='2'>Nama : </font></strong></td>\n";
$s. = "<td width='71%'>".$out['nama']."</td>\n";
$s. = "</tr>\n<tr>\n";
$s. = "<td><strong><font color='#666666' size='2'>Keputusan Permohonan : </font></strong></td>\n";
$s. = "<td>".$out['keputusan']."</td>\n"; 
$s. = "</tr>\n<tr>\n";
$s. = "<td><strong><font color='#666666' size='2'>No Kenderaan :</font></strong></td>\n";
$s. = "<td>".$out['kenderaan']."</td>\n";
$s. = "</tr>\n<tr>\n";
$s. = "<td><font size='2'><strong><font color='#FF0033'>Nama Pemandu</font>: \n";
$s. = "</strong></font></td>\n";
$s. = "<td>".$out['pemandu']."</td>\n";
$s. = "</tr>\n<tr>\n";
$s. = "<td><strong><font color='#666666' size='2'>Nama Pegawai : </font></strong></td>\n";
$s. = "<td>".$out['pegawai']."</td>\n";
$s. = "</tr>\n<tr>\n";
$s. = "<td><strong><font color='#666666' size='2'>Jawatan Pegawai :</font></strong></td>\n";
$s. = "<td>".$out['jawatan']."</td>\n";
$s. = "</tr>\n<tr>\n";
$s. = "<td><strong><font color='#666666' size='2'>Tarikh / Masa :</font></strong></td>\n";
$s. = "<td>".$out['tarikh2']." / ".$out['masa2']."</td>\n";
$s. = "</tr>\n<tr>\n";
$s. = "<td>&nbsp;</td>\n";
$s. = "<td>&nbsp;</td>\n";
$s. = "</tr>\n</table>\n";

}

?>
<html> 
<head> 
<title>Untitled Document</title> 
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> 
</head> 

<body> 
<table width="100%" border="0"> 
<tr>  

<td>&nbsp;</td> 
</tr> 
<tr>  

<td>  

<?php echo $s; ?>

</td> 
</tr> 
</table> 
</body> 
</html>

There are probably errors in here, but it's pretty close. I'm can't guarantee that this will work...good luck...