[RESOLVED] converting inc files into linkable lists

rickaclark

I have a script that reads a directory, strips various parts of the name and creates a list that can be used as links. Unfortunately, the script gives me the following error when I run it:

Parse error: parse error, unexpected '.' in /home/hearnofg/public_html/temp/sermons/index.php on line 16

The follwoing is my code:

<?php
//include header information
include("header.inc");

print("<table width='100%' border='0'><tr>");

//the following cell display the list of links
print("<td valign='top'>);
Choose your article:<br />
<ul>;
//Open current directory

if ($handle = opendir(".")) {
   while (false !== ($file = readdir($handle))) {

   if ($file != "." && $file != ".." && $file != "header.inc" && $file != "footer.inc" && $file != "index.php") {

//replace each underscore ("_") with a blank space
$name = ereg_replace("_", " ", $file);

//strip off the .inc from the file name
$name = ereg_replace(".inc", "", $name);

//strip off the .inc from the file
$file= ereg_replace(".inc", "", $file);

//print link and name
print"<li><a href ='template.php?topic=$file'>"$name"</a></li>";
}
endfile;

//close the directory
closedir($dir_handle);
"</ul>
</td>");

// the following cell includes the requested content files
print("<td valign='top'>");

//if no topic selected, display the default content
if($topic == ""){
print "Welcome to our article archive";

//else the user clicked on a link, so include content related to that link
} else {
	include ("$topic.inc");
}
print ("</td></tr></table>");

//incude footer info
include ("footer.inc");

?>

Any help would be appreciated.

Rick

leatherback

Hi,

It would help if you showed us the line where the error occurs, especially since you seem to have edited it since?

I think this line:
print"<li><a href ='template.php?topic=$file'>"$name"</a></li>";
should be:
print"<li><a href =\"template.php?topic=$file\">".$name."</a></li>";

rickaclark

I appreciate the reply, I'm sorry, I thought I had put the code back to its original state. I made the correction to line 28:

print"<li><a href ='template.php?topic=$file'>"$name"</a></li>";

with the following code:

print"<li><a href =\"template.php?topic=$file\">$name</a></li>";

Now I am getting an error on line 16:

Parse error: parse error, unexpected '.' in /home/hearnofg/public_html/temp/sermons/index.php on line 16

if ($file != "." && $file != ".." && $file != "header.inc" && $file != "footer.inc" && $file != "index.php") {

I understand escaping the quotes in the <a> tag, but I'm not sure about what to do with the "." error.

Thank you in advance for additional help,

Rick

leatherback

You really have to be carefull in al lyour quotes.

here:

//the following cell display the list of links
print("<td valign='top'>);
Choose your article:<br />
<ul>;

should be:
//the following cell display the list of links
print("<td valign='top'>Choose your article:<br /><ul>");

or:
//the following cell display the list of links
echo "<td valign='top'>
Choose your article:<br />
<ul>";

rickaclark

I see this code is riddled with errers I hadn't anticipated. It was given to me by one of my professors as an example on how PHP works. Because this script is designed to handle a current need, I decided to dust it off an attempt to use it.

I appreciate you patience with me. I correct all of the print syntax. However, I am now getting the following error:

Parse error: parse error, unexpected $ in /home/hearnofg/public_html/temp/sermons/index.php on line 52

The only thing at line 52 is the closing tag: ?>

<?php
//include header information
include("header.inc");
[B]
print("<table width='100%' border='0'><tr>");[/B]

//the following cell display the list of links

[B]print("<td valign='top'>Choose your article:<br /><ul>");[/B]
//Open current directory

if ($handle = opendir(".")) {	
   while (false !== ($file = readdir($handle))) {

   if ($file != "." && $file != ".." && $file != "header.inc" && $file != "footer.inc" && $file != "index.php") {

//replace each underscore ("_") with a blank space
$name = ereg_replace("_", " ", $file);

//strip off the .inc from the file name
$name = ereg_replace(".inc", "", $name);

//strip off the .inc from the file
$file= ereg_replace(".inc", "", $file);

//print link and name
[B]	print("<li><a href =\"template.php?topic=$file\">$name</a></li>");[/B]
	}
endfile;

//close the directory
closedir($dir_handle);
[B]print("</ul></td>");
[/B]
// the following cell includes the requested content files
[B]print("<td valign='top'>");[/B]

//if no topic selected, display the default content
if($topic == ""){
[B]print("Welcome to our article archive");[/B]

//else the user clicked on a link, so include content related to that link
} else {
	include ("$topic.inc");
}
[B]print("</td></tr></table>");[/B]

//incude footer info
include ("footer.inc");

?>

Weedpacket

That would be because there is a { in there that's missing its matching }. You've got a { at the end of both if($handle=opendir(".")) and while(false!==($file=readdir($handle))), but only one } at the bottom. No doubt there should be two there.

rickaclark

Thanks,

Actually I discovered I needed 3 closing brackets. At least I'm getting closer, the page comes up now. However, I am getting the following error:

Warning: closedir(): supplied argument is not a valid Directory resource in /home/hearnofg/public_html/temp/sermons/index.php on line 32

<?php
//include header information
include("header.inc");

print("<table width='100%' border='0'><tr>");

//the following cell display the list of links

print("<td valign='top'>Choose your article:<br /><ul>");
//Open current directory

if ($handle = opendir(".")) {	
   while (false !== ($file = readdir($handle))) {

   if ($file != "." && $file != ".." && $file != "header.inc" && $file != "footer.inc" && $file != "index.php") {

//replace each underscore ("_") with a blank space
$name = ereg_replace("_", " ", $file);

//strip off the .inc from the file name
$name = ereg_replace(".inc", "", $name);

//strip off the .inc from the file
$file= ereg_replace(".inc", "", $file);

//print link and name
print("<li><a href =\"template.php?topic=$file\">$name</a></li>");
}}}
endfile;

[B]//Line 32- close the directory
closedir($dir_handle);[/B]


print("</ul></td>");

// the following cell includes the requested content files
print("<td valign='top'>");

//if no topic selected, display the default content
if($topic == ""){
print("Welcome to our article archive");

//else the user clicked on a link, so include content related to that link
} else {
	include ("$topic.inc");
}
print("</td></tr></table>");

//incude footer info
include ("footer.inc");

?>

rickaclark

Thank you everyone for helping me overcome obstacles on my first php project.

Rick