[RESOLVED] If statement not Else'ing

shifty18

I am having a bit of a problem with an order system of mine. I have an order form, where the details are tehn sent on to a page to calculate the maths. The problem is i have a drop down list that checks to see if you want something and if you dont then it adds £5 to the order but even if the user selects yes to agreeing to include this it still adds 5. Here is the code

if (isset($brand)) {
	if ($brand = 'No') {
		$brand = '5';
		}
	else {
		$brand = '0';
		}
}

So even if the user selects Yes it still makes $brand = £5. Can anyone see why this is happening.

Thanks
Chris

thorpe

= is an assignment operator. you want ==

laserlight

For the check if $brand is equal to 'No', you should use the == operator.

shifty18

ooohhh yeah, man some really fundermental code can really go out your head sometimes lol, thanks, you have also cured about 2-3 other problems with stem from roughly the same problem i think lol

Thanks
Chris

shifty18

hmm thats odd, i thought it would solve this problem

if ($ext = "jpg") 
		{ 
			echo '<a href = ' . $row['Link'] .'><img src = images/Banners/' . $row['ImageLink'] .'>';
		}
	if ($ext = "swf")
		{
			echo '<object classid=

as like that it displays both images and with the == it only displays an else message that jsut says sorry banner not returned and if i dont include an else message it displays nothing, nothing in the source. Know whats up with that

Thanks
Chris

leatherback

Again. You do need to use ==.

Changing it to = is not solving your problem. The problem comes from the way you retrieve $ext, I suppose. How do you do that? Where does it come from?

Did you do an echo $ext; before the line executes?

shifty18

here is the complete code of that section

while ($row = mysql_fetch_array($result))
{
	$ext = substr($imagelink, -3, 3);
	if ($ext == 'jpg') 
		{ 
			echo '<a href = ' . $row['Link'] .'><img src = images/Banners/' . $row['ImageLink'] .'>';
		}
	elseif ($ext == 'swf')
		{
			echo '<object classid="clsid:D27CDB6E-AE6D-11cf-96B8-444553540000" codebase=								"http://download.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=6,0,29,0" width="468" height="60">
  <param name="movie" value="images/Banners/' . $row['ImageLink'] . '">
  <param name="quality" value="high">
  <embed src="images/Banners/' . $row['ImageLink'] .'" quality="high" pluginspage="http://www.macromedia.com/go/getflashplayer" type="application/x-shockwave-flas\" width="468" height="60"></embed>
</object>';
		}
	else 
		{
			echo "Sorry, there was an error returning the Banner. Please refresh";
		}
}

$imagelink is defined at the start of the page as $imagelink = $row['ImageLink'];

the page does work it does get the pictures but the problem is it displays both i.e does both if statements doesnt select the if statement

View http://80.193.62.89/Ammobox/GetBanner.php you will see both the swf and jpg are there if you view the source, its getting a random entry from the DB and then displaying eitehr an <img> or <object> wetehre its swf opr jpg

Thanks

Edit: I forgot to metion this page is with = and not == as == just displays the else

leatherback

First:
Several people have told you now that in a comparison you need to use =. Why ignore that?

SET = to == in your IF statements

THEN
ECHO $imagelink."--".$ext;

BEFORE the if statements

Then tell us the output

shifty18

ok i did state that with == all i get is the error else message. If i include ==. like stated above i get a parse error message

if i do echo $imagelink."--".$ext; i get this message

--0Sorry, there was an error returning the Banner. Please refresh the text is from my else message

Thanks
Chris

edit: 0 is due to me setting the ext var at the start of the page to '0' but i do have anotehr line, let me check that

netlynx

As leatherback mentioned above you may want to add the line:
echo "Ext = $ext<br>\n";

Add it right above the first if statement, that will show you what the value of $ext is.

Another quick suggestion that might make the code a little tidier (instead of a bunch of if statements)

   $ext = substr($imagelink, -3, 3);
   select ($ext)   {
      case 'jpg':
         // insert echo here;
         break; // don't forget the break or it will keep processing the rest of the lines
      case 'swf':
         // insert echo here;
         break; // don't forget the break or it will keep processing the rest of the lines
      default:
         echo "Sorry, there was an error returning the Banner. Please refresh"; 
         echo "ext: $ext<br />\n";
   }

In the above example, you can easily add more 'extensions' easily and quickly. As well, if it comes across one that it doesn't understand (default🙂 it will kick back your error message and the extension that it is having problems understanding.

Hope this helps a little.

leatherback

The message you showed,m shows your problem: $imagelink is not defined.

shifty18

yeah i see that imagelink is undefined but i know it is due to the image being pulld and displayed. I tried the case statement and i know i should use it more then i do, and i tired it and i am erroring on 24 with parse error

19 while ($row = mysql_fetch_array($result))
20 {
21	echo "Ext = $ext<br>\n"; 
22 $ext = substr($imagelink, -3, 3);
23
24   select ($ext)   {
25      case 'swf':
26         echo '<object classid="clsid:D27CDB6E-AE6D-11cf-96B8-444553540000" codebase=

hmmmm

leatherback

Yeah. The select should be switch, I think:

switch ($ext) {

But..WHERE are you defining $imagelink?

IF it is from the database, it should be like:

$imagelink = $row[imagelink];

netlynx

I'm sorry, thats my fault.

should be:

   switch ($ext) {

not:

   select ($ext) {

another note, move the echo "ext: $ext" line down below where you are setting $ext (which is the next line down). No point displaying it until after you set it.

shifty18

yeah good point i thought there was somehting wrong there,

ok well that works but it still is not getting the imagelink as its empty, but the odd thing is, at first it did work it was getting the image just running though both the swf and img echo's from the If's and now the var is not set. The var is set at the very top here with the recordset

mysql_select_db($database_AmmoBox, $AmmoBox);
$query = "SELECT ImageLink, Link FROM Banners ORDER BY rand() LIMIT 1";
$result = mysql_query($query, $AmmoBox);
$row_result = mysql_fetch_assoc($result);
$totalRows_result = mysql_num_rows($result);

$imagelink = $row['ImageLink'];
$link = $row_result['Link'];

there is then a mysql error piece of code and then the while statement

shifty18

hmm now i get a blank page not even the echo of the $ext or the defult statement, this is very odd, i also included some or die statments on the recordset and no erros are returned

edit: i included 2 echo statements under the $imagelink =row...and $link = row... statments and they echo fine

netlynx

Ok, can you tell me what you are fetching on line 19 then? I am a little confused on the flow of your script here. You are fetching the imagelink above, then on line 19 you are fetching something else, but processing the something else with your imagelink data. Can you paste from the beginning to the end of the while section (that starts on line 19) for me. I am kinda lost.

leatherback

Well, you know what I am going to write..

Echo $imagelink. At any place where ANYTHING may affect it untill you find the spot where it is not set anymore. COULD it be there is a lot of empty records in the database?

Or.. you could change $row into $row_result

THat might help

😃

shifty18

here is the code, goto the bottom to see what everything to pick out what is needed as you obvislly dont want to surf though the whole thing

<?php 

require_once('w00t/Meh.php'); //Connection

//Recordset
mysql_select_db($database_AmmoBox, $AmmoBox);
$query = "SELECT ImageLink, Link FROM Banners ORDER BY rand() LIMIT 1";
$result = mysql_query($query, $AmmoBox) or die (mysql_error());
$row_result = mysql_fetch_assoc($result)  or die (mysql_error());
$totalRows_result = mysql_num_rows($result)  or die (mysql_error());

$imagelink = $row_result['ImageLink']; //Create local vars from DB
$link = $row_result['Link'];

echo $imagelink; // test echo's
echo $link;

if (!$row_result) 
{
  echo mysql_error(); 
  exit;
} 

while ($row_result = mysql_fetch_array($result))
{
	$ext = substr($imagelink, -3, 3);
	echo "Ext = $ext<br>\n";

   switch ($ext)   

   {
      case 'swf':
         echo '<object classid="clsid:D27CDB6E-AE6D-11cf-96B8-444553540000" codebase=																	"http://download.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=6,0,29,0" width="468" height="60">
		  <param name="movie" value="images/Banners/' . $row['ImageLink'] . '">
 		  <param name="quality" value="high">
 		  <embed src="images/Banners/' . $row['ImageLink'] .'" quality="high" pluginspage="http://www.macromedia.com/go/getflashplayer" 	type="application/x-shockwave-flas\" width="468" height="60"></embed>
		  </object>';
      break; // don't forget the break or it will keep processing the rest of the lines
      case 'jpg':
        echo '<a href = ' . $row['Link'] .'><img src = images/Banners/' . $row['ImageLink'] .'>'; 
      break; // don't forget the break or it will keep processing the rest of the lines
      default:
         echo "Sorry, there was an error returning the Banner. Please refresh"; 
         echo "ext: $ext<br />\n";
   }  

}

mysql_free_result($result);
mysql_close();
?>

ok that is the entier page we can see the record set, the change or DB vars to local vars a mysql error statement and then the switching statement. With this current statement all iget is the test echo's of the lcoa vars at the top

Thanks alot

Chris

leatherback

Hi,

Try this. Obviously not tested, since I do not hvae your DB:


<?php 

require_once('w00t/Meh.php'); //Connection

//Recordset
mysql_select_db($database_AmmoBox, $AmmoBox);


$query = "SELECT ImageLink, Link FROM Banners ORDER BY rand() LIMIT 1";
    $result = mysql_query($query, $AmmoBox) or die (mysql_error());
    if($result)
      {      

      while ($row_result = mysql_fetch_array($result))
        {
        $totalRows_result = mysql_num_rows($result);
        $imagelink = $row_result['ImageLink']; //Create local vars from DB
        $link = $row_result['Link'];
                echo $imagelink; // test echo's
                echo $link;


   $ext = substr($imagelink, -3, 3);
   echo "Ext = $ext<br>\n";



   switch ($ext)   

   {
      case 'swf':
         echo '<object classid="clsid:D27CDB6E-AE6D-11cf-96B8-444553540000" codebase=                                                                    "http://download.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=6,0,29,0" width="468" height="60">
          <param name="movie" value="images/Banners/' . $row['ImageLink'] . '">
          <param name="quality" value="high">
          <embed src="images/Banners/' . $row['ImageLink'] .'" quality="high" pluginspage="http://www.macromedia.com/go/getflashplayer"     type="application/x-shockwave-flas\" width="468" height="60"></embed>
          </object>';
      break; // don't forget the break or it will keep processing the rest of the lines


  case 'jpg':
    echo '<a href = ' . $row['Link'] .'><img src = images/Banners/' . $row['ImageLink'] .'>'; 
  break; // don't forget the break or it will keep processing the rest of the lines


  default:
     echo "Sorry, there was an error returning the Banner. Please refresh"; 
     echo "ext: $ext<br />\n";
  break;

}  




    }  // End of while
  }  // End of results

echo "Stupid fool! You did not find anything at ALL";


mysql_free_result($result);
mysql_close();
?>