[RESOLVED] String searching application not behaving correctly

[KrisG]

Hello,

I have a small CLI application that takes an array of keywords and an array of filenames. I then use two foreach loops to take each filename, implode the file, and search it by each of the keywords. The result is then output to one of two files. The problem is, I believe, that the implode function is only imploding the filename string instead of the file the filename points to. Here is the code:

<?php
$key = file("changes.txt");  //file containing keywords separated by line break
$file = file("sqrs2.txt");  //file containing filenames to index
$result = count($key);
     foreach ($file as $files)	{	
	$files = trim($files);			
	$filecontents = implode("", $file);			
 	     foreach ($key as $keys)  {		
		$keys = trim($keys);
	        if (stristr($filecontents, $keys)) 	{
		$content = $keys . " was found in file " . $files . "\r\n";	
		$filec = fopen("output1.txt", "a+");
		fwrite($filec, $content);
		fclose($filec);		}
	        else {
		$content = $keys . " was not found in file " . $files . "\r\n";
		$filec = fopen("output2.txt", "a+");
		fwrite($filec, $content);	
		fclose($filec);      } } } 
?>

Does anyone have an idea of how I can force the implode function to point to the file?

Thank you very much in advance!!
KrisG

[wilku]

As far as I understood your problem, you need to change the line with implode to

$filecontents = file_get_contents($files);

Why use implode?
Or you wanted to implode all the contents' of all the files? But then it wouldn't search in one file but all the files. Implode in that context doesn't make sense to me.

[KrisG]

Thank you very much Wilku!! That took care of the problem.

The program is now running correctly. While I have your attention let me run this one by you. I have been trying to make a change to the else statement that I have not been able to make work.

Right now, the script rights a line of text to the output2.txt file for each keyword that is not found in the file. In the else statement I would like to have it count the number of times the stristr() function is returned false. If the counter ever is equal to the number of keywords I would just like to write "The $file is clean."

Here is the code again for you:

$key = file("changes.txt");  

$file = file("sqrs2.txt");  

$result = count($key);
  foreach ($file as $files)	{	
	$files = trim($files);			
	$filecontents = file_get_contents($files);			
	   foreach ($key as $keys)  {		
	      $keys = trim($keys);
	        if (stristr($filecontents, $keys)) 	{
		$content = $keys . " was found in file " . $files . "\r\n";	
		$filec = fopen("output1.txt", "a+");
		fwrite($filec, $content);
		fclose($filec);		}
	       else {
		$content = $keys . " was not found in file " . $files . "\r\n";
		$filec = fopen("output2.txt", "a+");
		fwrite($filec, $content);	
		fclose($filec);  } } } 

Again thanks in advance for everyone's help!!!
KrisG.

[wilku]

$key = file("changes.txt");  

$file = file("sqrs2.txt");  

$result = count($key);
 foreach ($file as $files)    

{    

    $files = trim($files);            

    $filecontents = file_get_contents($files);
    $found = false;//this indicates whether some key was found in a file
    foreach ($key as $keys)  

   {        

        $keys = trim($keys);
        if (stristr($filecontents, $keys))     

        {
              $found = true;
              $content = $keys . " was found in file " . $files . "\r\n";    

              $filec = fopen("output1.txt", "a+");
              fwrite($filec, $content);
              fclose($filec);        

       }//if 
    }//foreach key
    if (!found)//if no key was found
    {
        $content = "No key was found in file " . $files . "\r\n";
        $filec = fopen("output2.txt", "a+");
        fwrite($filec, $content);    

        fclose($filec);  

    }//if 
}//foreach file 

Now if any key was found, nothing will be written to output2.

[KrisG]

I thank you again Wilku!

KrisG