Changing news feeds every six hours.

Sawan

$time = time("G-i");
if (0-00<$time && $time<6-00)
{
echo '<script type="text/javascript" src="http://news.scotsman.com/international.cfm?format=js&num=10&hf=Verdana%2C%20Arial%2C%20Helvetica%2C%20sans%2Dserif&hs=2&hc=%23000000&abs=1&dpos=2&dfor=2"></script>';
}
elseif (6-00<$time && $time<12-00)
{
echo '<script language="Javascript" src="http://www.freenewsfeed.com/headlines/?javasc=1&default=1"></script>
';
}
elseif (12-00<$time && $time<18-00)
{
echo '<script language="JavaScript" src="http://jade.mcli.dist.maricopa.edu/feed/feed2js.php?src=http%3A%2F%2Ftimesofindia.indiatimes.com%2Frssfeeds%2F-2128936835.cms&chan=y&desc=1&date=y" type="text/javascript"></script>

}

The above script is what i have used to change the news feeds every six hours, the javascript is tested and working. But when i get to the part 6-00 to 12-00, which is now, the news does not show. Could someone tell me what needs changing
thanks.

justsomeone

What steps have you taken so far to debug this?

Do your if statements work? I've never seen anyone compare times the way you're doing it... Does the right "script" line get echoed into your page? Is the URL correct?..

Sawan

Do you mean that i am comparing the times badly, well when i run the script there are no errors, and the urls are working.

Thanks.

Sawan

Anyone there

justsomeone

OK, first off you're calling time incorrectly:

$time = time("G-i");

makes no sense. the time function doesn't expect any arguments and will just return the current time, regardless of any arguments you pass in to it.

So when you then try to check:

6-00<$time

PHP compares 6-00 (which becomes 6 MINUS zero, which just becomes 6) with $time which will be a value something like 1123096706. 6 is a lot smaller than 1123096706, so this will always fail. In fact, all of your if's will fail for this reason.

You might want to try:

date("G-i", time());

But since you're only interested in the hour, why bother with the minutes? just use the hours...

date("G", time());

Now you have a simple integer which you can use as you like...

$time = date("G", time());

if (0 <= $time && $time<6)
{
echo '<script type="text/javascript" src="http://news.scotsman.com/international.cfm?format=js&amp;num=10&amp;hf=Verdana%2C%20Arial%2C%20Helvetica%2C%20sans%2Dserif&amp;hs=2&amp;hc=%23000000&amp;abs=1&amp;dpos=2&amp;dfor=2"></script>';
}
elseif (6 <= $time && $time<12)
{
echo '<script language="Javascript" src="http://www.freenewsfeed.com/headlines/?javasc=1&default=1"></script>
';
}
elseif (12<= $time && $time<18)
{
echo '<script language="JavaScript" src="http://jade.mcli.dist.maricopa.edu/feed/feed2js.php?src=http%3A%2F%2Ftimesofindia.indiatimes.com%2Frssfeeds%2F-2128936835.cms&chan=y&desc=1&date=y" type="text/javascript"></script>

<noscript>
<a href="http://jade.mcli.dist.maricopa.edu/feed/feed2js.php?src=http%3A%2F%2Ftimesofindia.indiatimes.com%2Frssfeeds%2F-2128936835.cms&chan=y&desc=1&date=y&html=y">View RSS feed</a>
</noscript>
';
}
elseif (18<= $time && $time<24)
{
echo '<script language="JavaScript" src="http://jade.mcli.dist.maricopa.edu/feed/feed2js.php?src=http%3A%2F%2Fwww.sabcnews.com%2FSyndication%2FRSS%2FRSS_news_by_category_XML%2F0%2C2325%2CAfrica%2C00.xml&chan=y&desc=1&date=y" type="text/javascript"></script>

<noscript>
<a href="http://jade.mcli.dist.maricopa.edu/feed/feed2js.php?src=http%3A%2F%2Fwww.sabcnews.com%2FSyndication%2FRSS%2FRSS_news_by_category_XML%2F0%2C2325%2CAfrica%2C00.xml&chan=y&desc=1&date=y&html=y">View RSS feed</a>
</noscript>';
}

How's that?

Sawan

Much apprecited, coudl you tell me how to compare minutes and hours, not just minutes.

dalecosp

Have a look at things like [man]date[/man], and my favorite, [man]strtotime[/man]. AAMOF, there is a whole group of date/time functions that are real helpful for stuff like this....

Also, get familiar with the idea of the UNIX Epoch, which was midnight on January 1, 1970. PHP (and most computer systems) keep track of that date/time as "zero" ... this is why the php [man]time/man returns a pretty big integer ... it's the number of seconds since the Epoch.

dalecosp

[edit]Probably should have said "UNIX Timestamp", which is generally what such a number is called.[/edit]

Also, could you put your code in [ PHP] tags? It would save scrolling all over the place to read this thread....