[RESOLVED] Uploading Multiple Files

obrienkev

Hi again,

I want to upload multiple files from one form.

Each file is to go into a separate database table.

So any ideas how this is done? My code so far is below but it can get very large and messy. Could I use an array or something to make the code easier to use??

Here's my textfields...

<label for="splits">Splits:</label>
<input type="file" name="splits" id="splits" size="22" />
<br />

<label for="mergers">Mergers:</label>
<input type="file" name="mergers" id="mergers" size="22" />
<br />

<label for="spin_offs">Spin Offs:</label>
<input type="file" name="spin_offs" id="spin_offs" size="22" />
<br />

Here's my rather bulky php code...

// Declare Split Variables
$fileName = $_FILES['splits']['name'];
$tmpName = $_FILES['splits']['tmp_name'];
$fileSize = $_FILES['splits']['size'];
$fileType = $_FILES['splits']['type'];

$fp = fopen($tmpName, 'r');
$content = fread($fp, $fileSize);
$content = addslashes($content);
fclose($fp);

// Declare Merger Variables
$fileName1 = $_FILES['mergers']['name'];
$tmpName1 = $_FILES['mergers']['tmp_name'];
$fileSize1 = $_FILES['mergers']['size'];
$fileType1 = $_FILES['mergers']['type'];

$fp1 = fopen($tmpName1, 'r');
$content1 = fread($fp1, $fileSize1);
$content1 = addslashes($content1);
fclose($fp1);

// Declare Spin Off Variables
$fileName2 = $_FILES['spin_offs']['name'];
$tmpName2 = $_FILES['spin_offs']['tmp_name'];
$fileSize2 = $_FILES['spin_offs']['size'];
$fileType2 = $_FILES['spin_offs']['type'];

$fp2 = fopen($tmpName2, 'r');
$content2 = fread($fp2, $fileSize2);
$content2 = addslashes($content2);
fclose($fp2);.....etc...

Cheers,

Kevin.

leatherback

Yeah,

Use a foreach loop:

foreach ($_FILES as $key => $value)
{
echo $key;
print_r($value);
}

obrienkev

But how do I insert into separate database tables?

For example the file from mergers field is to go into mergers table.
The file from spin_off field is it go into the spin_off table.
etc...

Here is my query so far...

$query = "INSERT INTO mergers (name, size, type, content ) ".
                 "VALUES ('$fileName', '$fileSize', '$fileType', '$content')";

Each table has the same field names/types.

Any ideas how this is done??

thanks,

Kevin.

leatherback

Hi,

TRhis makes me wonder whether your setup is correct..

You should consider using one table for the images, with a colum for the type. Makes life easier when editing the setup.

But how about this:

$tables = array(
"mergers" => "mergers",
"spin_offs" => "spin_offs");

insert into $tables[$key] ...

obrienkev

OK. I have this but nothing is inserted into database tables...

foreach ($_FILES as $key => $value)
{
echo $key.'<br /><br />';
print_r($value);
echo '<br /><br />';
}

$tables = array(
"splits" => "splits",
"mergers" => "mergers",
"spin_offs" => "spin_offs",
"rights" => "rights");

$query = "INSERT INTO $tables[$key] (name, size, type, content) ".
                 "VALUES ('$fileName', '$fileSize', '$fileType', '$content')";

$result = mysql_query($query) or die(mysql_error());

I tried changing the loop but no success. What am I doing wrong? Doesn't give any error anyway.

thanks.

edcellgavin

check the files, if they really are uploaded.

obrienkev

Where and how should these variables be declared???

$fileName, $fileSize, $fileType, $content

My form fields are...

<label for="splits">Splits:</label>
<input type="file" name="splits" id="splits" size="22" />

<label for="mergers">Mergers:</label>
<input type="file" name="mergers" id="mergers" size="22" />

<label for="spin_offs">Spin Offs:</label>
<input type="file" name="spin_offs" id="spin_offs" size="22" />
<br />

thanks.

leatherback

Hi,

add this line:

Print_r($_FILES);
at the start ofyour upload script, to tell what is being submittted to the script.

so:

print_r($_FILES);
 foreach ($_FILES as $key => $value)
{
echo $key.'<br /><br />';
print_r($value);
echo '<br /><br />';
$fileName = $value[name];
$fileType = $value[type];

$tables = array(
"splits" => "splits",
"mergers" => "mergers",
"spin_offs" => "spin_offs",
"rights" => "rights");

// sometimes, PhP / MySQL is ickie:
$table = $tables[$key];

$query = "INSERT INTO $table (name, size, type, content) ".
                 "VALUES ('$fileName', '$fileSize', '$fileType', '$content')";

echo $query."<br>";
$result = mysql_query($query) or die(mysql_error()); 
}

Please let us know what this gives.

obrienkev

Thanks very much. Almost working right now. The query printed looks correct as do the arrays. Only problem now is the content.

How do I get this into the tables??

The query displays this for each relevant field/table...

INSERT INTO splits (name, size, type, content) VALUES ('Movement Proof.xls', '143360', 'application/vnd.ms-excel', '')

$fp = fopen($tmpName, 'r');
$content = fread($fp, $fileSize);
$content = addslashes($content);
fclose($fp);


$fileName = $value[name];
$fileType = $value[type];
$fileSize = $value[size];
$fileContent = $value[content];

What do I have to change the above code to to be used for all fields??

thanks again.

leatherback

You'll have to open the file, and read it into a variable. I would personally upload the file as file, copy it to a directory, and only story the location & name in the database.

obrienkev

OK, Im having no luck messing with loops, trying to get $fileContent.

Here's what I've done...

foreach ($_FILES as $key => $value)
{
 	 foreach ($_FILES as $key => $value)
   {
      $fp = fopen($tmpName, 'r');
      $content = fread($fp, $fileSize);
      $content = addslashes($content);
      fclose($fp);
   }

 $fileName = $value[name];
   $fileType = $value[type];
	 $fileSize = $value[size];
	 $fileContent = $value[content];

etc.....
}

any ideas? I want to stick with uploading the file to database.

thanks,

Kevin.

leatherback

Now why do you have these two foreach loops nested?

Have you looked at the manual at foreach, so you kow the logic behind it?

nested loop.

You need:

 $fileName = $value[name]; 
 $fileType = $value[type]; 
 $fileSize = $value[size]; 
 $fileContent = $value[content]; 

  $fp = fopen($value[tmpName], 'r'); 
  $content = fread($fp, $fileSize); 
  $content = addslashes($content); 
  fclose($fp);

obrienkev

This is what I have now...

foreach ($_FILES as $key => $value)
{
 		echo $key.'<br /><br />';
    print_r($value);
    echo '<br /><br />';

           // How do I loop through this???
	$fp = fopen($tmpName, 'r');
	$content = fread($fp, $fileSize);
	$content = addslashes($content);
	fclose($fp);

	// Set variables
	$fileName = $value[name];
            $fileType = $value[type];
	$fileSize = $value[size];
	$fileContent = $value[content];

$tables = array(
            "splits" => "splits",
            "mergers" => "mergers",
            "spin_offs" => "spin_offs",
            "rights" => "rights");

$table = $tables[$key];

$query = "INSERT INTO $table (name, size, type, content) ".
             "VALUES ('$fileName', '$fileSize', '$fileType', '$fileContent')";

echo $query."<br />";
$result = mysql_query($query) or die(mysql_error());

leatherback

Why do you do everything different then I suggest, and then complain it doesn't worK? You swapped :

$fileName = $value[name];
$fileType = $value[type];
$fileSize = $value[size];
$fileContent = $value[content];

$fp = fopen($value[tmpName], 'r');
$content = fread($fp, $fileSize);
$content = addslashes($content);
fclose($fp);

for:

        $fp = fopen($tmpName, 'r');
        $content = fread($fp, $fileSize);
        $content = addslashes($content);
        fclose($fp);

    // Set variables
    $fileName = $value[name];
            $fileType = $value[type];
    $fileSize = $value[size];
    $fileContent = $value[content];

And yues. It does make a difference.

Also. I suggested to look at the manual, which is located at php.net.
Look at: fread , foreach .

All you need is in the file & the manual. I am not going to spell it out. THe idea is that next time you encounter these issues, that you can solve them yourself.

obrienkev

Sorry I had the code you gave previously but still doesn't insert the content.

I have already looked at fread and foreach but I'm still unable to get this going.

I really appreciate your help.

obrienkev

Using this and it works...

// Show what is being submitted
print_r($_FILES);
echo '<br /><br />';

// Loop through each form field
foreach ($_FILES as $key => $value)
{
 		echo $key.'<br /><br />';
    print_r($value);
    echo '<br /><br />';

	// Set variables
	$fileName = $value[name];
$fileType = $value[type];
	$fileSize = $value[size];


	$fp = fopen($value[tmp_name], 'rb');
$content = fread($fp, $fileSize);
  $content = addslashes($content);
	fclose($fp);


$tables = array(
            "splits" => "splits",
            "mergers" => "mergers",
            "spin_offs" => "spin_offs",
            "rights" => "rights");

$table = $tables[$key];

$query = "INSERT INTO $table (name, size, type, content, file_date) ".
             "VALUES ('$fileName', '$fileSize', '$fileType', '$content', NOW())";

//echo $query."<br />";
$result = mysql_query($query) or die(mysql_error());

} // end foreach clause