Can any one tell my why this code puts two entries into the database?

[avantbard]

Hi,
I've got this code here for entering data from a flash form into a mysql database - which works fine except that it puts 2 entries into the data base one just with the date and eveything else blank and one which has all the relevant infomation?
Any one tell me what is wrong?

Many Thanks in advance.
R.

require 'incLoc.php';
$Connect = mysql_connect($DBhost,$DBuser,$DBpass);
mysql_select_db("$DBName");

$joindate = date("m/d/Y H:i:s");

$fname=$POST['fname'];
$lastname=$POST['lname'];
$bname=$POST['bname'];
$type=$POST['type'];
$ad=$POST['ad'];
$count =$POST['count'];
$pcode=$POST['pcode'];
$mail=$POST['mail'];
$telno=$POST['telno'];
$website=$POST['website'];
$det=$POST['det'];
$password=$POST['pass1'];
$online=$_POST['online'];

$query = "SELECT * FROM members WHERE Email = '$mail'";
$result = mysql_query($query);
//
$numR = mysql_num_rows($result);

//

if ($numR == 1) {
print "answer=This email address is already registered, if you have forgotten your password click below";
}
else {
$query = "INSERT INTO members (No, Name, LastName, BandName, Type, Address, County, PostCode, Email, Tel, WebSite, Details, JoinDate, Paid, Password, Online, Visits, VisitDate) VALUES ('', '$fname', '$lastname','$bname', '$type', '$ad', '$count', '$pcode', '$mail', '$telno', '$website', '$det', '$joindate', '', '$password', '$online', '1','$joindate')";
$result = mysql_query($query);

// Gets the number of rows affected by the query as a check.
$numR = mysql_affected_rows($Connect);

if ($numR == 0) {
print "answer=Sorry a technical error has occurred Please Fill out all Fields Again";
}
else if ($numR == 1) {
print "answer=Thankyou you are now a member of 'The Avant Guilds Performing Arts Society'. You will receive an e-mail shortly with confirmation of your password and details.";
require 'mailform.php';
}

else { print "answer=General Error - Sorry - Try Again";
}

}

[leatherback]

Do you also use this code to load a form oid? I mean: THis code will always execute an insert if no form has been posted.

[avantbard]

Forgive my ignorance - Why is that?

[leatherback]

Because you do a query on the database, assuming that a form was posted, without checking. If no form is posted, the query will result in

SELECT * FROM members WHERE Email = ''"
and $numR will return 0 => You go to the else part of the if statement, and insert a record. You need to check for a know variable ( e.g. $_POST['fname']; ) and test whether it isset() before going to the query statement.

J.

[topsub]

You call this page when u submit a form right? I hope so because if u do include it on the same page as the form then when the page runs it will see that there is no record and try to insert a blank record into the database,

I am trying to follow your code but you have alot of extra stuff in there you dont need. I know everyone will code differently,

To start i might try and put a "mysql_close" after the instert statemtn

<?

mysql_close();

?>

[avantbard]

Hi,

I just tried the mysql close() statement and it didn't work still got two entries - where do i put the isset() statement
is it something like this?

if (isset($fname)) {- mysql insert statemet
}

[avantbard]

Hey,
The isset() thing worked - thankyou very much for your help and speady response.
R.

[leatherback]

Directrly after the require() statement:

if(isset($_POST[fname]))
{

and after all the code you placed in your first post:

}

and perhaps:

else
{

// any code you need to show if no form was submitted here

}