Looping through an array

[Studebaker]

I am having a problem with formatting and displaying content from a database. All the queries are fine, but when I create an array and loop through it to display the contents, nothing appears. Here is a snippet of the code

// Returns an array of information corresponding to current linkid
function get_page_content($linkid)
{
   // query database for the books in a category
   if (!$linkid || $linkid=='')
     return false;

   $conn = db_connect();
   $query = "select * from pagecontent where linkid='$linkid'";
   $result = @mysql_query($query);
   if (!$result)
     return false;
   $result = @mysql_num_rows($result);
   if ($result ==0)
      return false;

   $result = db_result_to_array($result);
   return $result;
}

// Loops through the array to display the contents
function display_page_contents($page_array)
{
  if(!is_array($page_array))
  {
  	echo 'Currently no page content.';
  }
  else
  {
  	foreach ($page_array as $row)
    {
      echo $row['pagetext'];
    }
  }
}

// Function that converts a MySQL result identifier into an array of results
function db_result_to_array($result)
{
   $res_array = array();

   for ($count=0; $row = @mysql_fetch_array($result); $count++)
     $res_array[$count] = $row;

   return $res_array;
}

The above code corresponds to the query, identifier conversion to an array, and the foreach{} that displays the information. Like I said before, nothing is appearing when I run these scripts.

Help, anyone?

[leatherback]

Hi,

I am not sure whether you can pass a result variable that way. And I am not sure whether
for ($count=0; $row = @mysql_fetch_array($result); $count++)
makes sense.

Why did you split the database query, and the placing into an array into two functions? Wouldn't it simpify things enourmously of you'd combine them?

J.

[kburger]

Why should anything be displayed? This is simply 3 function definitions. They never get called in this script.

Also, why in the world do people supress error messages with '@' when they're having trouble getting things to work? 😕

[devinemke]

<?php
function get_page_content($linkid)
{ 
   if (!$linkid) {return false;}
	 db_connect();
	 $result = @mysql_query("SELECT * FROM pagecontent WHERE linkid = '$linkid'"); 
   if (!$result) {return false;} 
   if (!mysql_num_rows($result)) {return false;}
	 $result = db_result_to_array($result); 
   return $result;
} 

function display_page_contents($page_array)
{ 
  if (!is_array($page_array) || !$page_array) {echo 'Currently no page content.';}
  else {foreach ($page_array as $row) {echo $row['pagetext'] . '<br>';}}
} 

function db_result_to_array($result)
{ 
   $array = array();
	 while ($row = mysql_fetch_assoc($result)) {$array[] = $row;}
   return $array;
}

// call the functions:
display_page_contents(get_page_content(123));
?>

[Studebaker]

For one thing, this is a tutorial that I got from a book (where there is no accompanying support site or disc) Also, there are no calls to these functions because those are on another page which includes these functions in an include() call.

So if I combine the two functions, (db_result_to_array() and get_page_contents() things will display more easily? Would removing the second condition from the foreach() statement, placing the mysql_fetch_array($result) bit further on up in the function change anything?

[leatherback]

Use the code posted by devinemke. I have not gone through it, but she knows whats happening in PhP, as far as I can tell.

[Studebaker]

Thanks for the code, Devinemike. It really helped me out.