[RESOLVED] PHP 5.0.4 Issues

ppowell

Environment:
PHP 5.0.0
Windows XP

I am having issues with the array_push() function, due to its rather nasty behavior in PHP 5.0+ particularly using Windows XP.

$array = array();
array_push($array, 'banana'); // produces ('banana')
array_push($array, 'apple'); // produces ('apple', 'apple') - SURPRISE!!
array_push($array, 'orange'); // produces ('orange', 'orange', 'orange')

// EVEN THIS FAILS
$array[] = pear; // produces ('pear', 'pear', 'pear', 'pear');

I read online that this is an actual PHP bug that is being looked into, but in the meantime to try this:

$array = array();
$array[] = clone 'banana'; // produces ('banana')
$array[] = clone 'apple'; // produces ('banana', 'apple')

Problem is that I have about 5 web applications with about 20 - 30 PHP scripts, class libraries and includes/templates, about 1000 lines average/script, and changing every instance of array_push() is, at best, problematic.

So I devised this:

if (!function_exists('array_push') || version_compare(phpversion(), '5.0.0', '>=')) {
 /**
  * Perform a more efficient "array_push()" than the built-in PHP gives for versions 5.0+
  *
  * @access public
  * @param array $array (reference)
  * @param mixed $item
  * @return int $sizeof array_push normally returns an integer
  * @link http://groups-beta.google.com/group/mailing.www.php-dev/browse_thread/thread/bbc88aadf10712d9/52ae899d71134902?lnk=st&q=array_push+problem+php5&rnum=1&hl=en#52ae899d71134902
  * @see link regarding bug in PHP version 5.0+ with array_push "pushing" by reference and not by clone
  */
  function array_push(&$array, $item) {
  	$array[] = clone $item;
	return @sizeof($array);
  }
}

Well, you can guess how far that went. 🙁 Problem is that array_push exists in the PHP core and I'm reattempting to redeclare array_push().

I WANT to do this, however!! How can I accomplish this simple change and keep from having to hack apart thousands upon thousands of lines of code, just for a new version of PHP?

Thanx
Phil

Merve

Write a php script to both get the contents of the file and replace array_push() with your function (name it something else). Although, for this method, you'd either have to add a function declaration in the script or else have an include.

hitman6003

There is no 5 minute fix...the easiest thing I can think of is to add an include with your new function to the top of each page, and then do a find and replace in all your pages.

As far as a function that would do the same thing as array_push()....

function new_array_push(&$array, $var) {
    $cnt = count($array) + 1;
    $array[$cnt] = $var;
    return true;
}

Weedpacket

Your original code works for me in PHP 5.0.3 (which reminds me I probably should upgrade). (Incidentally, there's not a lot of point trying to clone strings, because strings aren't objects.)

ppowell

Weedpacket wrote:
Your original code works for me in PHP 5.0.3 (which reminds me I probably should upgrade). (Incidentally, there's not a lot of point trying to clone strings, because strings aren't objects.)

In a philosophical sense, yes, strings are objects, although not all objects are strings, but I digress..

Apparently array_push only exhibits this bizarre behavior if you are adding an object (i.e. a class object) into what will be an object array. I too was not able to duplicate this behavior by trying out strings, integers, booleans, etc.

Probably I will just write a function that handles array_push for version 5.0+ for adding objects, but that will still require changing hundreds of lines of code in up to about 50 different scripts per application I've written!

Phil

ppowell

I'm having a couple of issues wih PHP 5.0.4 that I simply cannot work around.

array_push($array, $obj); // PUSHING AN OBJECT INTO AN ARRAY

In PHP 4+ this is of course just fine as you will have an array of objects, however, in PHP 5.0.4 I would have the last stacked object $obj as every element in $array, like if I did this:

 $fruit1->name = 'apple';
 $fruit2->name = 'banana';
 $fruit3->name = 'pear';

 $fruitObjArray = array();
 array_push($fruitObjArray, $fruit1);
 array_push($fruitObjArray, $fruit2);
 array_push($fruitObjArray, $fruit3);

 @rewind($fruitObjArray);
 foreach ($fruitObjArray as $obj) print_r($obj->name); // YOU JUST SEE "pear"

The other one was in the use of fopen(). Using PHP 4+ I am able to do the following:

// A LINE IN install.php
$fileID = fopen('install.csv'); // install.csv IS IN THE SAME FOLDER AS install.php

However, in PHP 5.0.4 I got the following warning:

Warning: fopen(install.csv): failed to open stream: No such file or directory

Both "install.csv" and "install.php" exist and have equal permissions and are in the same folder. However, one can't find the other using PHP 5.0.4. This does not occur in PHP 4+ (we're using 4.3.2, 4.1.2 and 4.3.8).

Bottom line: Has anyone else run into any "features" while using PHP 5.0.4?

Thanks
Phil

devinemke

my box:
WinXP
Apache 2.0.50
PHP 5.0.4

the array code works as expected on my machine. it ouputs "applebananapear"
[man]fopen[/man] requires at least 2 parameters, you are only feeding it 1

ppowell

fails for me constantly outputs pearpearpear every time.

WinXP, Apache 2.0.50, PHP 5.0.4

2) I made a mistake, changed to

$fileID = fopen('install.csv', 'r');

And I get the exact same warning "no such file or directory" even though it is in the same folder as install.csv. We rolled back to PHP 4.3.2 and it works like a charm.

You tell me

Phil

Weedpacket

ppowell wrote:
You tell me

Works for me too. "applebananapear". Maybe it's something in your code you're not showing us. You tell us.

ppowell

Ok, sorry but this is going to be rather long, but since you wanted to see the code, the code you shall see, as much as I'm allowed legally to produce.

class EditResultGenerator extends MethodGenerator {

/**
 * Set result within the existing section array
 * 
 * @access private
 * @param object result reference array of objects
 * @param array $sectionArray
 */
function &setResultWithSectionArray(&$result, $sectionArray) {			// STATIC VOID METHOD
	global $section;
	if (is_array($result) && @sizeof($result) > 0 && is_array($sectionArray) && @sizeof($sectionArray) > 0 &&
	    @sizeof(array_keys(get_object_vars($result[0]))) > 0
	   ) {
	 $tempResult = array();
	 // SORT INTO ALPHA ORDER SINCE YOU CAN'T SORT THIS BY ANY OTHER (NO METADATA!)
	 $sectionArray = array_values($sectionArray); 
	 @usort($sectionArray, create_function('&$a,&$b', 'return strcmp(strtolower($a), strtolower($b));'));
	 @reset($sectionArray); // GO TO BEGINNING
	 foreach ($sectionArray as $sectionFileName) {
	  $obj = EditResultGenerator::getResultObject($result);
	  $obj->{$section . '_path'} = $sectionFileName;
	  $obj->{$section . '_name'} = substr($sectionFileName, strrpos($sectionFileName, '/') + 1, strlen($sectionFileName));
	  print_r("obj = "); print_r($obj); print_r("<P>"); // OUTPUT BELOW
	  array_push($tempResult, $obj);
	  print_r("tempResult = "); print_r($tempResult); print_r("<P>"); // OUTPUT BELOW
	  $obj = null;
	 }
	}
	$result = (@sizeof($tempResult) > 0) ? array_merge($tempResult, $result) : $result;
}
}

obj = stdClass Object
(
[id] =>
[image_name] => banner.jpg
[image_path] => C:/Program Files/Apache Group/Apache2/htdocs/images/banner.jpg
[image_creation_date] =>
[image_location_city] =>
[image_location_state] =>
[image_location_country] =>
)
tempResult = Array
(
[0] => stdClass Object
(
[id] =>
[image_name] => banner.jpg
[image_path] => C:/Program Files/Apache Group/Apache2/htdocs/images/banner.jpg
[image_creation_date] =>
[image_location_city] =>
[image_location_state] =>
[image_location_country] =>
)

)
obj = stdClass Object
(
[id] =>
[image_name] => banner_oops.jpg
[image_path] => C:/Program Files/Apache Group/Apache2/htdocs/images/banner_oops.jpg
[image_creation_date] =>
[image_location_city] =>
[image_location_state] =>
[image_location_country] =>
)
tempResult = Array
(
[0] => stdClass Object
(
[id] =>
[image_name] => banner_oops.jpg
[image_path] => C:/Program Files/Apache Group/Apache2/htdocs/images/banner_oops.jpg
[image_creation_date] =>
[image_location_city] =>
[image_location_state] =>
[image_location_country] =>
)
[1] => stdClass Object
 (
 [id] => 
 [image_name] => banner_oops.jpg
 [image_path] => C:/Program Files/Apache Group/Apache2/htdocs/images/banner_oops.jpg
 [image_creation_date] => 
 [image_location_city] => 
 [image_location_state] => 
 [image_location_country] => 
 )
)
obj = stdClass Object
(
[id] =>
[image_name] => CorpPortCopy1.jpg
[image_path] => C:/Program Files/Apache Group/Apache2/htdocs/images/CorpPortCopy1.jpg
[image_creation_date] =>
[image_location_city] =>
[image_location_state] =>
[image_location_country] =>
)
tempResult = Array
(
[0] => stdClass Object
(
[id] =>
[image_name] => CorpPortCopy1.jpg
[image_path] => C:/Program Files/Apache Group/Apache2/htdocs/images/CorpPortCopy1.jpg
[image_creation_date] =>
[image_location_city] =>
[image_location_state] =>
[image_location_country] =>
)
[1] => stdClass Object
 (
 [id] => 
 [image_name] => CorpPortCopy1.jpg
 [image_path] => C:/Program Files/Apache Group/Apache2/htdocs/images/CorpPortCopy1.jpg
 [image_creation_date] => 
 [image_location_city] => 
 [image_location_state] => 
 [image_location_country] => 
 )

[2] => stdClass Object
 (
 [id] => 
 [image_name] => CorpPortCopy1.jpg
 [image_path] => C:/Program Files/Apache Group/Apache2/htdocs/images/CorpPortCopy1.jpg
 [image_creation_date] => 
 [image_location_city] => 
 [image_location_state] => 
 [image_location_country] => 
 )
)

Phil

ppowell

Ok a much MUCH simpler example that produces the same problem:

<?

  class Obj {

   var $name;

   function Obj() {}

   function &getName() {
    return $this->name;
   }

   function &setName($name) {
    $this->name = $name;
   }

  }


  $objArray = array();
  $obj = new Obj();
  $obj->setName('apple');
  array_push($objArray, $obj);
  print_r($objArray); print_r("<P>");
  $obj->setName('banana');
  array_push($objArray, $obj);
  print_r($objArray); print_r("<P>");
  $obj->setName('pear');
  array_push($objArray, $obj);
  print_r($objArray); 

?>

This is your result:

Array ( [0] => Obj Object ( [name] => apple ) )

Array ( [0] => Obj Object ( [name] => banana ) [1] => Obj Object ( [name] => banana ) )

Array ( [0] => Obj Object ( [name] => pear ) [1] => Obj Object ( [name] => pear ) [2] => Obj Object ( [name] => pear ) )

Now, the EXACT SAME CODE.. this time, in PHP 4.3.2, does THIS:

Array ( [0] => obj Object ( [name] => apple ) )

Array ( [0] => obj Object ( [name] => apple ) [1] => obj Object ( [name] => banana ) )

Array ( [0] => obj Object ( [name] => apple ) [1] => obj Object ( [name] => banana ) [2] => obj Object ( [name] => pear ) )

Phil

Weedpacket

Oh, well, there's your problem, then. In PHP 5 objects are passed by reference (as they are in most other languages that allow passing objects to functions; people wanted to be able to modify an object's properties in a function without having to use & to pass it by reference all the time). This is noted in the manual's guide to migrating from PHP 4 to PHP 5 as one of the biggest changes in the PHP object model.

This only applies to objects, not other PHP types, like strings, which are still passed by value.

$string = "A string";echo (is_object($string)) ? 'Strings are objects' : 'Strings are not objects';

So what you're doing is creating an object ($obj), setting a property, and inserting it into the array. Then you're changing its property, and inserting it into the array, and then you're changing its property and inserting it into the array.

Upshot: you end up with three references to the same object (which has had its property set three times). If you want three objects you need to create three objects.

<?

  class Obj {

   var $name;

   function Obj() {}

   function getName() {
    return $this->name;
   }

   function setName($name) {
    $this->name = $name;
   }

  }

  $objArray = array();
  $obj = new Obj();
  $obj->setName('apple');
  array_push($objArray, $obj);
  print_r($objArray); print_r("<P>");
  $obj = new Obj();
  $obj->setName('banana');
  array_push($objArray, $obj);
  print_r($objArray); print_r("<P>");
  $obj = new Obj();
  $obj->setName('pear');
  array_push($objArray, $obj);
  print_r($objArray); 

?>

In future, if you provide code to illustrate your problem, it may be a good idea to provide code that illustrates your problem.

ppowell

In future, if you provide code to illustrate your problem, it may be a good idea to provide code that illustrates your problem.

I did that.

I realized the same thing about PHP 5 now passing objects by reference as a default. This, however, will be a distinct code scalability issue if you're trying to retrofit your code to work with OO PHP for PHP 4 and PHP 5 because if the user is attempting to do what I did it will only work in one or the other, except in this case:

foreach ($array as $element) {
 if ((int)$phpVersionInt >= 500) {
   eval('$obj = clone EditResultGenerator::getResultObject($result);');
  } else {
   $obj = EditResultGenerator::getResultObject($result);
  }
 }

Phil

Weedpacket

ppowell wrote:
I did that.

You might think you had, but it didn't. That's why all your responses were "Works for me". The code you supplied didn't have the problem you were claiming (perhaps you should have tested it first).

ppowell

The code I supplied did illustrate the problem for me and yes, I tested it first before I posted it, otherwise, I wouldn't have posted it. Perhaps it behaved differently on your machine, but then again, your environment might also be different from mine.

Nevertheless, I did illustrate the problem, I did post the problem, I posted the code (two different examples), and I cannot do anything more other than physically fly you out to Washington, DC, having you pass a security clearance, be funded for the project as a developer and be given permission to view my environment, otherwise, sorry, that's about it.

And, BTW, a local DC-based PHP developers group helped me solve the problem inasmuch as redesigning the EditResultGenerator::setResultWithinSectionArray() method so that it won't ever have an instance of potentially setting an object by reference if using PHP 5.0.4.

Phil