[RESOLVED] Query Error

obrienkev

Hi all,

Why does this print an error? The problem is with $value.

Thanks.

$query   = "SELECT name, type, size, content FROM ". $value ." WHERE id = '$id'";
$result  = mysql_query($query) or die(mysql_error());

Roger_Ramjet

I'll bet $value is a string so it does not get concatenated into your query as a table name but is treated as a literal sting value

$query = "SELECT name, type, size, content FROM 'table' WHERE id = '$id'";

If you try echoing out your query when you get an eror this would be obvious. Try this construction for runing your queries when in development or debugging errors.

$result = mysql_query($query) or die($query . '<br />' .mysql_error());

obrienkev

I'm using echo $result, die(mysql_error), etc..

It can't find the table, which should be set in the <body> section...

$tables = array(
            "splits" => "splits",
            "mergers" => "mergers",
            "spin_offs" => "spin_offs",
            "rights" => "rights");

//$table = $tables[$key];

foreach($tables as $value)
{
$query = "SELECT id, name FROM ". $value;
$result = mysql_query($query) or die(mysql_error());
echo '<b>' . $value . '</b><br />';

Any ideas?

Roger_Ramjet

As I said, what does the actual query string say when it is printed out on the screen - I just know it's going to have string delimiters around the table name.

edwardp

use this:


$query   = "SELECT name, type, size, content FROM '".$value."' WHERE id = '$id'";

notice there is a ' (quote) after the FROM and before the where

this may also work


$query   = "SELECT name, type, size, content FROM '$value' WHERE id = '$id'";

edwardp

just realised you have already done it to the $id in the query but missed on $value

obrienkev

Why won't it set $value in the query??

Here is my error report...

SELECT name, type, size, content FROM '' WHERE id = '1'

You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near ''' WHERE id = '1'' at line 1

The id value is passed like this...

 while ($row = mysql_fetch_assoc($result))
 {
 	  echo '<a href="index.php?id='.$row['id'].'">'.$row['name'].'</a><br />';

 }

edwardp

what happens if you do:

$tables = array( 
            "splits" => "splits", 
            "mergers" => "mergers", 
            "spin_offs" => "spin_offs", 
            "rights" => "rights"); 



foreach($tables as $value) 
{ 
$query = "SELECT id, name FROM ". $value; 
echo $query."<br>";
}

i'm getting:

SELECT id, name FROM splits
SELECT id, name FROM mergers
SELECT id, name FROM spin_offs
SELECT id, name FROM rights

obrienkev

I get this...

SELECT id, name FROM splits
SELECT id, name FROM mergers
SELECT id, name FROM spin_offs
SELECT id, name FROM rights

Weedpacket

Are you sure $value has the value you think it does? If this bit is accurate:

foreach($tables as $value)
{

then $tables would appear to be an empty array.

obrienkev

After realising that $value isn't passed as a variable. D'oh!

How do I pass it??

Here's the <body> code...

$tables = array(
            "splits" => "splits",
            "mergers" => "mergers",
            "spin_offs" => "spin_offs",
            "rights" => "rights");

//$table = $tables[$key];

foreach($tables as $value)
{
 $query = "SELECT id, name FROM ". $value;
 $result = mysql_query($query) or die(mysql_error());
 echo '<b>' . $value . '</b><br />';
 while ($row = mysql_fetch_assoc($result))
 {
 	  echo '<a href="index.php?id='.$row['id'].'">'.$row['name'].'</a><br />';

 }
 echo '<br />';
}

Then once the links are clicked on...

if(isset($_GET['id']))
{

	// Connect to database
	@ $db = mysql_pconnect('localhost', 'user', 'pword');

	if (!$db)
	{
 			echo '<p>Could not connect to database</p>';
 			exit;
	}

	// Select Database
	mysql_select_db('team') or die(mysql_error());


$id      = $_GET['id'];

$query   = "SELECT name, type, size, content FROM ".$value." WHERE id = '$id'";
echo $query;
		$result  = mysql_query($query) or die(mysql_error());
    list($name, $type, $size, $content) = mysql_fetch_array($result);

header("Content-Disposition: attachment; filename=$name");
header("Content-length: $size");
header("Content-type: $type");
echo $content;

exit;
}

So how can I set $value??

Thanks guys!

edwardp

so what is the problem? u now have the sql

Weedpacket

What do you mean "how do you pass it"? You know your code better than anyone else here[*] - we don't even know where it is now, so how are we supposed to tell you how to get it or where to get it from?

[*]Which means that if you don't understand your own code then you are in big trouble.[/size]

edwardp

you could include it into the query string in the first script and

isset($_GET['value']) etc...

obrienkev

The code is all on one php page(index.php).

In the first part of the code the link is created, which passes $row['id'] to index.php

foreach($tables as $value)
{
 $query = "SELECT id, name FROM ". $value;
 $result = mysql_query($query) or die(mysql_error());
 echo '<b>' . $value . '</b><br />';
 while ($row = mysql_fetch_assoc($result))
 {
 	  echo '<a href="index.php?id='.$row['id'].'">'.$row['name'].'</a><br />';

 }

In the second part of the code(as above, which is at the top of the php page) the $row['id'] is retrieved by $GET['id'] and set to variable $id.

$id= $_GET['id'];
$query   = "SELECT name, type, size, content FROM ".$value." WHERE id = '$id'";

So basically how do I do this with the tablename?
I want to set a value for $value.

As you can see it has a value in the foreach loop but isn't sent as variable in the link...

oreach($tables as $value)
{
 $query = "SELECT id, name FROM ". $value;
 $result = mysql_query($query) or die(mysql_error());
 echo '<b>' . $value . '</b><br />';
 while ($row = mysql_fetch_assoc($result))
 {
 	  echo '<a href="index.php?id='.$row['id'].'">'.$row['name'].'</a><br />';

 }
 echo '<br />';
}

And $row['id'] is sent as variable via the link so can I send $value like this?

Hope this makes sense. I understand my own code and apoligies if I haven't been explaining very clearly.

thanks.

Weedpacket

obrienkev wrote:
And $row['id'] is sent as variable via the link so can I send $value like this?

The same way?!

'<a href="index.php?id='.$row['id'].'&value='.$value.'">'.$row['name'].'</a><br />'

obrienkev

Thank You!