[RESOLVED] My query is only showing one from the database - why is this?

[werx]

I have my own modular system and would say that on a scale of 1 - 10 in PHP coding I'm atleast an 8 - not the best, but good enough to practically anything I want with it. Anyways, again I have my own modular system - templating from the database, languages seperated from the html, and all that good stuff.

Anyways, look at my coding - you'll be able to figure out what's going on obviously if you know your stuff, but basically I can't get it to show more than one row in the database. I've used this same coding elsewhere in the site and it works wonderfully, there's a bug somewhere that I just can't smoosh - could you help?

       function get_list() {

	 $user = $this->user['user_id'];


	 $notification_count_t = $this->db->query("SELECT COUNT(*) FROM hw_notifications WHERE no_userid=$user");
	 $notification_count = mysql_result($notification_count_t, 0);


 	       if ($notification_count) {

	 	$notification_t = $this->db->query('SELECT * FROM hw_notifications WHERE no_userid="'.$user.'" ORDER BY no_id ASC LIMIT 0, 10');
 	  		$notification = $this->db->nqfetch($notification_t);
     	  	while ($notifications = $notification) {
         	  return eval($this->template('NOTIFICATIONS_MINILIST'));	
     		} 

       } else {
 	     		  return eval($this->template('NOTIFICATIONS_NONE'));
         }


   } 

[Roger_Ramjet]

Dunno what nqfetch is supposed to do - fetch an array I suppose - but my guess is that it's just fetching the first row from $notification_t so your while only itterates once.

[werx]

Yes NQfetch gets fetches the array. Although why would it only pull the first one, and do you know how I would fix this? I'm just so frustrated with this seeing as it's the same coding that I've used elsewhere on the site.

[Roger_Ramjet]

Seems to be completely redundant to me 😕

I guess nqfetch is a method you've coded yourself: don't recognise it anyway. :o

The fix is obvious though

while ($notification = $this->db->nqfetch($notification_t)) {
          while ($notifications = $notification) {
                   return eval($this->template('NOTIFICATIONS_MINILIST'));    

                 }
}  

[werx]

I agree, it looks like the obvious solution but doesn't fix the situation. It's something more complex than that of something I can fix obviously. 🙂

NQfetch - is just the codename for a function in my globally used mysql.php

	function nqfetch($query)
	{
		return mysql_fetch_array($query, MYSQL_ASSOC);
	}

Anyways - it's odd - I used your replacement method and still no resolve.

       function get_list() {

	 $user = $this->user['user_id'];


	 $notification_count_t = $this->db->query("SELECT COUNT(*) FROM hw_notifications WHERE no_userid=$user");
	 $notification_count = mysql_result($notification_count_t, 0);


 	       if ($notification_count) {

	 	$notification_t = $this->db->query('SELECT * FROM hw_notifications WHERE no_userid="'.$user.'" ORDER BY no_id ASC LIMIT 0, 10');

		while ($notification = $this->db->nqfetch($notification_t)) {
   		   while ($notifications = $notification) {
          	     return eval($this->template('NOTIFICATIONS_MINILIST'));    
          	   }
		}  

       } else {
 	     		  return eval($this->template('NOTIFICATIONS_NONE'));
         }


   } 

[werx]

I came to the conclusion - sometimes it's easier to just work with the coding in a manner of noremorse that you're a good coder. If you can't find the bug, don't sweat it - redo it all. I redid the complete thing, in a much different way and did it as such.

	function getDefault()
      {
       	$this->tree($this->lang->notifications_notifications);
		$this->set_title($this->lang->notifications_notifications);

	$out = null;
	$order = 'no_id';
	$min = '0';
	$n = '100';
	$topics  = $this->getTopics($min, $n);

	if (!$topics) {
		$topics = eval($this->template('NOTIFICATIONS_NONE'));
	}

	return eval($this->template('NOTIFICATIONS_MAIN'));

}

function getNotifications($min, $n)
{
	$out = null;
	$order = 'no_id';
	$min = '0';
	$n = '100';


	$query = $this->db->query("
	SELECT
	    no_id, no_name, no_description
	FROM
	    {$this->pre}notifications
	WHERE
	    no_userid = {$this->user['user_id']}
	ORDER BY
	    $order
	LIMIT
	    $min, $n");

	while ($row = $this->db->nqfetch($query))
	{
		$out .= eval($this->template('NOTIFICATIONS_NOTIFICATION'));
	}

   return $out;

}

All is working the way it is supposed to now. Thanks.