Checkbox problem.. (read other posts! need help!)

xingeh

Basically if the user selects a news item(s) to be deleted then this processes through and sets the checkbox value to the value of the news id, then deletes from where that id = news id

// The delete news section!
if($action == del) {

if(!$_SESSION['averify'] == 1 || $_SESSION['averify'] == 2) {

echo("You have no right to go to this link!");
} else {

$del_news = "SELECT * FROM news ORDER BY id ASC";
$del_news1 = safe_query($del_news);
while($row5 = mysql_fetch_array($del_news1)) {
$id = $row5['id'];
$title = $row5['title'];
$date = $row5['date'];
$author = $row5['author'];
?>

<form action="" method="post" name="dell_news">
<input type="checkbox" value="<? echo("$id"); ?>" name="select_del">
<? echo("$id - $title - $date - $author"); ?>
<br><br>
<? } ?>
<input type="submit" name="dell_news" value="Del selected">

<?
}}

and the processing code is

// The delete news thing
if(isset($_REQUEST['select_del'])) {

$news_id = $_POST['id'];

$del_news = "DELETE FROM `news` WHERE `id` = '$news_id' LIMIT 1";
safe_query($del_news);

echo("News deleted!");

?>

<META HTTP-EQUIV="Refresh" CONTENT=";URL=./index.php?">

<?

}

Thanks in advance all!

Roger_Ramjet

And the question is ???

xingeh

How to get it to work... lol

LoganK

I'm sorry, as much I would like to help you stemming from our previous PM conversations, I don't know an exact error. What exactly is going wrong, and why/how is it different from your expected result (i.e., what's happening that's different than what you want to happen?)?

xingeh

Ok.. From the

// The delete news section!
if($action == del) {

if(!$_SESSION['averify'] == 1 || $_SESSION['averify'] == 2) {

echo("You have no right to go to this link!");
} else {

$del_news = "SELECT * FROM news ORDER BY id ASC";
$del_news1 = safe_query($del_news);
while($row5 = mysql_fetch_array($del_news1)) {
$id = $row5['id'];
$title = $row5['title'];
$date = $row5['date'];
$author = $row5['author'];
?>

<form action="" method="post" name="dell_news">
<input type="checkbox" value="<? echo("$id"); ?>" name="select_del">
<? echo("$id - $title - $date - $author"); ?>
<br><br>
<? } ?>
<input type="submit" name="dell_news" value="Del selected">

<?
}}

this shows the form right? It shows a checkbox and next to it the id, title, date and author of the news post. Im trying to get it so you can click either 1 of the posts, or multiple ones using checkboxes, with this code

<?
// The delete news thing
if(isset($_REQUEST['select_del'])) {

$news_id = $_POST['id'];

$del_news = "DELETE FROM `news` WHERE `id` = '$news_id' LIMIT 1";
safe_query($del_news);

echo("News deleted!");

?>

<META HTTP-EQUIV="Refresh" CONTENT=";URL=./index.php?">

<?

}

if you need to see visually whats happening, i can boost you to an admin on:
http://www.xing-designs.com/XD-Clansite/index.php?site=news

LoganK

Boost me to an admin as you call it (username: LoganK; I tried registering but it didn't work).

But from the looks of it, you've already got some bad problems.

A) You don't define anything for the action of your form.
😎 You re-declar "<form ...>" in every iteration of the while statement.
C) You don't have any form field named "id".
D) If you want to delete via checkboxes, the names have to be in this format: name[]

xingeh

Ok mate, your in, password = password

LoganK

Allright; I'll check out the site, and please pay attention to my 4 points when you post the new code.

xingeh

Ok, well, I have already been looking..
The action doesn't need to be defined because it's the same page, same page by defualt in forms.
Dont understand the second point.. :p
Form field named id? Thought that I could just value the checkbox as id (never used check's before..)
4th points.. never used checks before lol. Sorry! ... :$

LoganK

In your while loop, you have "<form action='' method='post' ...etc...>". That means that the HTML code for the beginning of the form is being sent with each iteration of the loop, so you have to move it to outside of the loop. Now, instead of the checkboxes being named what they already are, set them to do this:

echo "<input type='checkbox' name='delete[]' value='$id' />";

Allright, you're almost done. In the part of the script that actually processes and deletes things, you need to do this:

foreach ($_POST['delete'] as $key => $id)
{
$sql = "DELETE FROM table WHERE id='$id'";
safe_query($sql) or die("Error!");
}

And it will iterate through all the checked boxes and delete them from the DB. It's confusing at first - it took me a while to get the hang of checkboxes in PHP too. But once you understand it, it's really simple 😃

xingeh

Warning: Invalid argument supplied for foreach() in /home/xingeh/public_html/XD-Clansite/news.php on line 3

<?
// The delete news thing
foreach($_POST['delete'] as $key => $id)
{
$sql = "DELETE FROM table WHERE id='$id'";
safe_query($sql) or die("Error!");

echo("News deleted!");

?>

<META HTTP-EQUIV="Refresh" CONTENT=";URL=./index.php?">

<?

}

// The delete news section!
if($action == del) {

if(!$_SESSION['averify'] == 1 || $_SESSION['averify'] == 2) {

echo("You have no right to go to this link!");
} else {

$del_news = "SELECT * FROM news ORDER BY id ASC";
$del_news1 = safe_query($del_news);
while($row5 = mysql_fetch_array($del_news1)) {
$id = $row5['id'];
$title = $row5['title'];
$date = $row5['date'];
$author = $row5['author'];
?>

<form action="" method="post" name="dell_news">
<?
echo "<input type='checkbox' name='delete[]' value='$id' />"; 
echo("$id - $title - $date - $author"); ?>
<br><br>
<? } ?>
<input type="submit" name="dell_news" value="Del selected">

<?
}}

?>

LoganK

I didn't mean a literal table name of "table" - replace it with your own. As for the error, A) you forgot to close your foreach brackets, and 😎 before foreach, try print_r($_POST) and post the output here.

ScottyDog

Hey,

i am posting on behalf of xingeh.

The Code is now

<?
// The delete news thing
print_r($_POST);
foreach($_POST['delete'] as => $id)
{
$sql = "DELETE FROM news WHERE id='$id'";
safe_query($sql) or die("Error!");
}
echo("News deleted!");

?>

The value of the print_r($_POST); is

array()

But it displays that on the main news page, not just the delete page.

Also what i want to ask is where does $key come into this?

LoganK

No offense, but RTFM. Foreach takes an array as an argument and assigns the key/value pair of the current array point into the variables you specify. So, the foreach loop goes through each key/value pair in the array, assigns the key to variable "$key" and the value to variable "$id". These can be referenced from within the foreach loop; every new iteration overwrites the previous. So, no, that would not be half the problem.

<?
// The delete news thing
print_r($POST);
foreach($POST['delete'] as => $id)
{
$sql = "DELETE FROM news WHERE id='$id'";
safe_query($sql) or die("Error!");
}
echo("News deleted!");

Thank you for deleting $key. It's exactly what I reccomended to do. :mad:

Put $key back in, and change the action of the form to the PHP script. Obviously PHP isn't getting an POST data some something's going wrong with the POST itself.

Roger_Ramjet

$key => $val means for each entry in an associative array ie index and value

If you had paid attention to Logan's post and copied his code correctly you would be getting the checkbox values submitted

Also, the print_r() should be within the delete section ie within the IF. At the moment it is empty because nothing has been submitted

LoganK

I'm glad someone understands me here...

ScottyDog

argh sorry lads. the $key is actually in there. That was a mistake that i actually posted there. The $key value was bought to my attention when i realised it was missing. Dont get pissy it was simply a question

OK new update, sorry about the confusion earlier.
The checkboxes are now deleting the news articles as requred 😃

The final code used was

<?
// The delete news thing
if(isset($dell_news)) {
foreach($_POST['delete'] as $key => $id)
{
$sql = "DELETE FROM news WHERE id='$id'";
safe_query($sql) or die("Error!");
}
echo("News deleted!");
}
?>

Thanks so much to every1 who helped especially LoganK

xingeh

OK, thanks everyone for the help, this now works fine! I kinda fully understand it too 🙂 Thanks LoganK!

Also, SpottyDog, you missed a second } making the whole thing a loop of redirecting to the main page 🙂

Thanks all!

LoganK

Allright, glad everything worked out. Two things:

A) Please mark this as resolved,

-and-

😎 Xingeh, what is this clan site for? I don't really participate in clans because I'm not into that whole "online gamer community" thing, but I do enjoy Halo quite a bit on the PC and I've been looking for a clan to join...or does it have nothing to with videogames at all?