[RESOLVED] $var (apparently) un-set

shifty18

I am trying to update something in my DB, but my problem is everything but 1 piece of infomation is set and so it cannot put the message with the correct ID. Basically, the user selects a story to update, it passees the ID tothe next page, this words as the url is id=1 and even on my page i echo $id and it clearly states 1. But it wont go in to my function..here is some code

First my function. Here we can see $resolved which is from a form and i changed from $POST['resolved'] to a localvar a few lines up and $id which is set via a $GET['id'] ealier on but i know this is set due it me echoing it in to the page. the echo statements are for debuggng and the rest as you see

function resolve($id,$resolved)
{
	global $db;
	echo "id is $id";
	echo "message is $resolved";
	$sql = "UPDATE NetworkStats SET resolved = '$resolved' WHERE id = '$id'";
	$result = mysql_query($sql,$db);
	return;
}

a few lines down is my main HTML page and here id is echoed and its echoed correct

<th width="90%" scope="col"><div align="left"><?php echo $id; ?></div></th>

at the very top of the page I have a recordset that gathers some more infomation according to the id which we will update in the function. I know here id works as the 2 peices of infomation are correctly pulled

$sql = "SELECT * FROM NetworkStats WHERE id = '$id'";

so it works at the top, at the bottom but not in the function even though the var $resolved does

any one see whats wrong

Thanks
Chris

Weedpacket

And where are you calling the function?

toplay

To help you find the problem, display any errors.

$result = mysql_query($sql,$db) or die("SQL: $sql<br>Error: " . mysql_error());

shifty18

No I get no errors just the debuggin message of id is message is and then the message that i wrote. So the message passes butnoit the ID as its not present in my echo. My function is the alst piece of PHP code after my session auth, record set, setting local vars and checking the url to see when to call the function

if (isset($_GET['action'])) //If the varible action is set 
{ 
	if ($_GET['action'] == 'resolve') //And the varible is 'resolve' 
	{	 
	resolve($id,$resolved); // Run the 'resolve' function 
	} 
}

just after that and just befor the HTML of the webpage of the form etc

toplay

I hope you are not relying on register_globals being on. Keep it off for security reasons and program accordingly. Example:

if ((isset($_GET['action'])) && ('resolve' == $_GET['action'])) {

$id = isSet($_GET['id']) ? $_GET['id'] : 0;  // Set to a default
$resolved = isSet($_GET['resolved']) ? $_GET['resolved'] : '';  // Set to a default

resolve($id, $resolved); // Run the 'resolve' function
}

I hope you put in the error check at or after the query.

🙂

shifty18

I have no idear about register globals, i belive i have them turned off but I always change my $GET/POST vars to local vars when they are needed in functions etc. Ok first of all, and i dont want to sound patronising i am simply asking, shouldnt first if statement be && $GET['action'] == 'resolve' as its the var action that needs to be checked for resolve. Also the two vars, i dont understand what you are trying do with with isSet($GET['resolved']) ? $GET['resolved'] : ''; what does the ? and : '' do, is that saying if its set then use the data in teh var $_GET['resolved'] and if tehre is nothing set, set the var to ''??

Thanks
Chris

shifty18

ok that kind of works the $resolve var has the right message but now ID is jsut set to 0 so its sending the var into the function and a var is going though buts its 0 and not the var of the message which in this case is 1 (the case of this message, there are multiple messages)

Thanks
Chris

toplay

shifty18, we really need to see all relevant code snippets exactly as is (copy and paste into this forums php tags).

In your original post here, you show us where you display (echo) out the $id. But we don't see where id is coming from. Like is it in the URL (...script.php?id=23) or do you have it in a HTML form (... name='id' ...) ?

Yes, the "?" and ":" is the ternary comparison operator. If $id in the function is zero, then the $_GET['id'] is not being set/empty.

Let's see all the code, ok?

LoganK

Try (in the function) to echo $sql, to see what MySQL is receiving.

shifty18

ok in statusindex.php i have

 <td><a href=\"resolvestatusindex.php?id=$id\">Resolve Issue</a></td>

which sends on the $id to the next page, the id is sent on correctly

in resolvestatus.php i have all of this, its easy to understand and i have commented it out

<?php
session_start();
if (@$auth != "yes")
{
	header ("Location: MemberLogin.php");
	exit();
}
require_once('ConnPageHere.php');
$_GET['action'] = $_GET['action']; //url action
$id = $_GET['id']; //the id comes from statusindx.php via a url .php?id=1 for example

$db = mysql_connect($hostname_AmmoBox, $username_AmmoBox, $password_AmmoBox) or die(mysql_error() . ' found on line: ' . __LINE__);
mysql_select_db($database_AmmoBox,$db) or die(mysql_error() . ' found on line: ' . __LINE__);
$sql = "SELECT * FROM NetworkStats WHERE id = '$id'"; //here is ID and its obvsilly got an ID as in hte page the correct data is returned from the DB
$result = mysql_query($sql,$db) or die(mysql_error() . ' found on line: ' . __LINE__);
$row = mysql_fetch_array($result);

$title = $row['title']; // change data from DB to local vars
$message = $row['message'];
$resolved = $_POST['resolved']; //this is from the table

if ((isset($_GET['action']))  && ('resolve' == $_GET['action'])) //If the varible action is set and is equeal to action
{ 
	$id = isSet($_GET['id']) ? $_GET['id'] : 0;  // Set to a default
	$resolved = isSet($_POST['resolved']) ? $_POST['resolved'] : '';  // Set to a default 
	resolve($id,$resolved); // Run the 'resolve' function 
}

function resolve($id,$resolved) //functionto resolve the message
{
	global $db;
	echo "id is $id"; //test echos
	echo "message is $resolved";
	$sql = "UPDATE NetworkStats SET resolved = '$resolved' WHERE id = '$id'";
	$result = mysql_query($sql,$db) or die("SQL: $sql<br>Error: " . mysql_error());;
	return;
}

?>
<style type="text/css">
<!--
.style1 {font-size: 9px}
.style2 {font-size: 10px}
-->
</style>



<form action="resolvestatusindex.php?action=resolve" method="post" name="resolveissue" id="resolveissue">
  <table width="29%"  border="0">
    <tr>
      <th width="10%" scope="col"><div align="left"><strong>ID:</strong></div></th>
      <th width="90%" scope="col"><div align="left"><?php echo $id; ?></div></th>
    </tr>
    <tr>
      <td><div align="left"><strong>Title:</strong></div></td>
      <td><?php echo $title; ?></td>
    </tr>
    <tr>
      <td><div align="left"><strong>Message:</strong></div></td>
      <td><?php echo $message; ?></td>
    </tr>
    <tr>
      <td><strong>Resolved:</strong></td>
      <td><textarea name="resolved" rows="3" wrap="VIRTUAL" id="resolved"></textarea></td>
    </tr>
  </table>
  <p>
    <input type="submit" name="Submit" value="Resolve">
<span class="style1"><br>
<span class="style2">B
by clicking resolve you are chanign the status back to &quot;Online&quot; and adding the resolved message </span></span>  </p>
</form>
<?php
mysql_free_result($result);
?>

chears
chris

toplay

This doesn't make much sense, so delete it:
$GET['action'] = $GET['action']; //url action

Right underneath that line you have:
$id = $_GET['id'];

which should be like you have it further down in the code as:
$id = isSet($GET['id']) ? $GET['id'] : 0; // Set to a default

Basically, where ever you use $GET or $POST, it's recommend to use isSet(). Change that.

After the fetch, you should check if data was returned and not just assume that it found the row. Example:

$row = mysql_fetch_array($result);
if (!$row) {
// No data found - handle condition
$title = '';
$message = '';
} else {
$title = $row['title']; // change data from DB to local vars
$message = $row['message'];
}

Your main problem is that you don't pass the id again in your "action" URL. Change this:

<form action="resolvestatusindex.php?action=resolve"

to this:

<form action="resolvestatusindex.php?action=resolve&id=<?PHP echo $id; ?>"

🙂

LoganK

Nice catch toplay!

shifty18

some very good tips there which I thank you for and yes that worked its a problem I have had befor. But maybe now you could help me out with another strange problem. On statusindex.php there is the section to view the records or to add a new one, but everytime the page loads of is refresh a record is added for no reason.

The code is fairly easy to understand but i can't see why it adds it as it should only add it when the url is .php?action=add the while loop command might seam strange it doesnt work as its meant to return all records from the DB but i cant work it out so ignore that if you think it looks strange, its just becuse it isnt done correctly

<?php
session_start();
if (@$auth != "yes")
{
	header ("Location: MemberLogin.php");
	exit();
}
require_once('MyConnPage');
$db = mysql_connect($hostname_AmmoBox, $username_AmmoBox, $password_AmmoBox) or die("Unable to connect to server.");
mysql_select_db($database_AmmoBox,$db) or die("Unable to connect to site database.");
$sql = "SELECT * FROM NetworkStats" or die(mysql_error());
$result = mysql_query($sql,$db) or die(mysql_error());
$row = mysql_fetch_assoc($result) or die(mysql_error());
$totalrow = mysql_num_rows($result) or die(mysql_error());

$id = $row['id'];
$title = $row['title'];

while($row = mysql_fetch_array($result, MYSQL_NUM)) 
	{ 
		list($id,$title) = $row;
		$table = "<table width=\"100%\"  border=\"0\">
  <tr class=\"content\">
    <th scope=\"col\">ID</th>
    <th scope=\"col\">Title</th>
    <th scope=\"col\">Action</th>
  </tr>
    <tr class=\"content\">
     <td>$id</td>
    <td>$title</td>
    <td><a href=\"resolvestatusindex.php?id=$id\">Resolve Issue</a></td>
  </tr>
 </table>";
	} 

$_GET['add'];

if ((isset($_GET['action'])) && ('add' == $_GET['action']));
	{
		$service = isSet($_POST['service']) ? $_POST['service'] : '';  // Set to a default
		$title1 = isSet($_POST['title']) ? $_POST['title'] : '';  // Set to a default
		$status = isSet($_POST['status']) ? $_POST['status'] : '';  // Set to a default
		$message = isSet($_POST['message']) ? $_POST['message'] : '';  // Set to a default
		addticket($service,$title1,$status,$message);
	}

function addticket($service,$title1,$status,$message)
{
	global $db;
	$sql = "INSERT INTO networkstats (service,title,status,message) VALUES ('$service','$title1','$status','$message')";
	$result = mysql_query($sql,$db) or die("SQL: $sql<br>Error: " . mysql_error());;
	return;
}
?>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<title>Admin - Status Index</title>
<link href="../other/main.css" rel="stylesheet" type="text/css" />
<style type="text/css">
<!--
.style2 {font-size: 12px}
-->
</style>
</head>

<body>
<p align="left"><span class="section_title">Staus Index</span></span></p>
<p align="left" class="style2">Add Content</p>
<form action="statusindex.php?action=add" method="post" name="AddContent" id="AddContent">
  <div align="left"></div>
  <div align="left">
    <table width="42%"  border="0">
      <tr>
        <td class="content">Service:</td>
        <td class="standard"><select name="service" id="service">
          <option value="DNS">DNS</option>
          <option value="Network">Network</option>
          <option value="Teamspeak">Teamspeak</option>
          <option value="Website">Website</option>
        </select></td>
      </tr>
      <tr>
        <td width="10%" class="content">Status:</td>
        <td width="90%" class="standard"><div align="left">
          <select name="status" id="status">
              <option value="Online">Online</option>
              <option value="Offline">Offline</option>
          </select>
        </div></td>
      </tr>
      <tr>
        <td class="content">Title:</td>
        <td class="standard"><div align="left">
          <input name="title" type="text" id="title" />
        </div></td>
      </tr>
      <tr>
        <td class="content">Message:</td>
        <td class="standard"><div align="left">
          <textarea name="message" cols="50" rows="5" wrap="VIRTUAL" id="message"></textarea>
        </div></td>
      </tr>
    </table>
    <br />
    <br />
    <input type="submit" title="Submit" />
  </div>
</form>
<p align="left" class="style2">Edit Content</p>
<?php echo $table; ?>
</body>
</html>

Thanks alot

LoganK

I'm confused...are you saying that when the user reloads the page a duplicate record is created?

shifty18

no the page loads with a form and some text boxes with a submit button and when you press submit a record is created, so that works, BUT if you just load the page without pressing submit or anything it creates an empty record, so its submitting a record even when i dont press submit. Imagine its like this <body onload=insert record> obvislly its not like that but thats what its doing in effect, when the page loads a record is inserted

LoganK

Enclose the PHP code which is creating the record within an if/else block:

if (isset($_POST['submit_button_name']))
{
     // Code for creating record
}

shifty18

i do here

if ((isset($_GET['action'])) && ('add' == $_GET['action'])); 
    { 
        $service = isSet($_POST['service']) ? $_POST['service'] : '';  // Set to a default 
        $title1 = isSet($_POST['title']) ? $_POST['title'] : '';  // Set to a default 
        $status = isSet($_POST['status']) ? $_POST['status'] : '';  // Set to a default 
        $message = isSet($_POST['message']) ? $_POST['message'] : '';  // Set to a default 
        addticket($service,$title1,$status,$message); 
    } 

function addticket($service,$title1,$status,$message) 
{ 
    global $db; 
    $sql = "INSERT INTO networkstats (service,title,status,message) VALUES ('$service','$title1','$status','$message')"; 
    $result = mysql_query($sql,$db) or die("SQL: $sql<br>Error: " . mysql_error());; 
    return; 
}

LoganK

You already have ternary operators setting the values to blank (null) if the post don't exist. You even say "Set to a default". So what's the problem?!?!?

shifty18

ooo so basically what that means is if there is no value, set them to a 0 value, but in any case the url is only statusindex.php and not statusindex.php?action=add so it still shouldnt add it as it states

if ((isset($GET['action'])) && ('add' == $GET['action']));

IF the value in the url is add do the function

LoganK

My question now is: why are you using a separate function to insert the data into your DB? You're not doing any validation or anything...so it's quite silly.