Can anybody help me to simplify this source code?

bbmak

Actually this script is fine, but i feel like the source is too bucky, so i want to simplify it because I feel frustrated when i have to do all these code lines by lines. I feel like i am doing html, so i wonder if any experts can help me to simplify some source for me instead of typing out all these lines again.

Can you simplify this part, but i think you should look at my full source first at the bottom because some variables are needed to query out the schedule.

$date = $_GET['date'];
$tomorrow = $date + 86400; 
$tomorrow2 = $date + (86400*2); 
$tomorrow3 = $date + (86400*3); 
$tomorrow4 = $date + (86400*4);

$d1 = date(l, $date);          $day1 = date(d, $date);       $month1 = date(m, $date);
$d2 = date(l, $tomorrow);      $day2 = date(d, $tomorrow);   $month2 = date(m, $tomorrow);
$d3 = date(l, $tomorrow2);     $day3 = date(d, $tomorrow2);  $month3 = date(m, $tomorrow2);
$d4 = date(l, $tomorrow3);     $day4 = date(d, $tomorrow3);  $month4 = date(m, $tomorrow3);
$d5 = date(l, $tomorrow4);     $day5 = date(d, $tomorrow4);  $month5 = date(m, $tomorrow4);

this part need to simplify too. Full source are down at the bottom.

$query = "SELECT * FROM schedule WHERE date = '$date' AND time = '".$i."AM-".$j."AM' ORDER BY time asc";
} elseif ($j == 12) {
$query = "SELECT * FROM schedule WHERE date = '$date' AND time = '".$i."AM-".$j."Noon' ORDER BY time asc";
} elseif ($i == 12) {
$query = "SELECT * FROM schedule WHERE date = '$date' AND time = '".$i."Noon-".$j."PM' ORDER BY time asc";
} else {
$query = "SELECT * FROM schedule WHERE date = '$date' AND time = '".$i."PM-".$j."PM' ORDER BY time asc";
}
$result=mysql_query($query) or die(mysql_error()); 
$row=mysql_fetch_array($result);


echo "<tr><td valign=\"center\" align=\"center\">".$i.":00 - ".$j.":00</td><td valign=\"center\" align=\"center\">";
echo $row['task'];
echo "<br>";
echo $row['host'];
echo "</td><td valign=\"center\" align=\"center\">";

here is the full source. See if you can help me simplify anything here.

<?

include ('connect.php');
?>
<html>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">

<?

$date = $_GET['date'];


$tomorrow = $date + 86400; 
$tomorrow2 = $date + (86400*2); 
$tomorrow3 = $date + (86400*3); 
$tomorrow4 = $date + (86400*4);

$d1 = date(l, $date);          $day1 = date(d, $date);       $month1 = date(m, $date);
$d2 = date(l, $tomorrow);      $day2 = date(d, $tomorrow);   $month2 = date(m, $tomorrow);
$d3 = date(l, $tomorrow2);     $day3 = date(d, $tomorrow2);  $month3 = date(m, $tomorrow2);
$d4 = date(l, $tomorrow3);     $day4 = date(d, $tomorrow3);  $month4 = date(m, $tomorrow3);
$d5 = date(l, $tomorrow4);     $day5 = date(d, $tomorrow4);  $month5 = date(m, $tomorrow4);

echo "<table height=\"100%\" border=\"1\" align=\"center\" valign=\"center\" align=\"center\">";
echo "<tr><td><table width=\"100\" valign=\"center\" align=\"center\"><tr><td valign=\"center\" align=\"center\">Time</td></tr></table>";
echo "</td><td><table width=\"125\" valign=\"center\" align=\"center\"><tr><td valign=\"center\" align=\"center\">$d1 <br> $month1/$day1</td></tr></table>";
echo "</td><td><table width=\"125\" valign=\"center\" align=\"center\"><tr><td valign=\"center\" align=\"center\">$d2 <br> $month2/$day2</td></tr></table>";
echo "</td><td><table width=\"125\" valign=\"center\" align=\"center\"><tr><td valign=\"center\" align=\"center\">$d3 <br> $month3/$day3</td></tr></table>";
echo "</td><td><table width=\"125\" valign=\"center\" align=\"center\"><tr><td valign=\"center\" align=\"center\">$d4 <br> $month4/$day4</td></tr></table>";
echo "</td><td><table width=\"125\" valign=\"center\" align=\"center\"><tr><td valign=\"center\" align=\"center\">$d5 <br> $month5/$day5</td></tr></table></td></tr>";


$i=1;
$j=2;


while($i<=23) 
while($j<=24)
{
{

if ($i<12) {
$query = "SELECT * FROM schedule WHERE date = '$date' AND time = '".$i."AM-".$j."AM' ORDER BY time asc";
} elseif ($j == 12) {
$query = "SELECT * FROM schedule WHERE date = '$date' AND time = '".$i."AM-".$j."Noon' ORDER BY time asc";
} elseif ($i == 12) {
$query = "SELECT * FROM schedule WHERE date = '$date' AND time = '".$i."Noon-".$j."PM' ORDER BY time asc";
} else {
$query = "SELECT * FROM schedule WHERE date = '$date' AND time = '".$i."PM-".$j."PM' ORDER BY time asc";
}
$result=mysql_query($query) or die(mysql_error()); 
$row=mysql_fetch_array($result);


echo "<tr><td valign=\"center\" align=\"center\">".$i.":00 - ".$j.":00</td><td valign=\"center\" align=\"center\">";
echo $row['task'];
echo "<br>";
echo $row['host'];
echo "</td><td valign=\"center\" align=\"center\">";

if ($i<12) {
$query1 = "SELECT * FROM schedule WHERE date = '$tomorrow' AND time = '".$i."AM-".$j."AM' ORDER BY time asc";
} elseif ($j == 12) {
$query1 = "SELECT * FROM schedule WHERE date = '$tomorrow' AND time = '".$i."AM-".$j."Noon' ORDER BY time asc";
} elseif ($i == 12) {
$query1 = "SELECT * FROM schedule WHERE date = '$tomorrow' AND time = '".$i."Noon-".$j."PM' ORDER BY time asc";
} else {
$query1 = "SELECT * FROM schedule WHERE date = '$tomorrow' AND time = '".$i."PM-".$j."PM' ORDER BY time asc";
}
$result1=mysql_query($query1) or die(mysql_error()); 
$row1=mysql_fetch_array($result1);


echo $row1['task'];
echo "<br>";
echo $row1['host'];
echo "</td><td valign=\"center\" align=\"center\">";

if ($i<12) {
$query2 = "SELECT * FROM schedule WHERE date = '$tomorrow2' AND time = '".$i."AM-".$j."AM' ORDER BY time asc";
} elseif ($j == 12) {
$query2 = "SELECT * FROM schedule WHERE date = '$tomorrow2' AND time = '".$i."AM-".$j."Noon' ORDER BY time asc";
} elseif ($i == 12) {
$query2 = "SELECT * FROM schedule WHERE date = '$tomorrow2' AND time = '".$i."Noon-".$j."PM' ORDER BY time asc";
} else {
$query2 = "SELECT * FROM schedule WHERE date = '$tomorrow2' AND time = '".$i."PM-".$j."PM' ORDER BY time asc";
}
$result2=mysql_query($query2) or die(mysql_error()); 
$row2=mysql_fetch_array($result2);


echo $row2['task'];
echo "<br>";
echo $row2['host'];
echo "</td><td valign=\"center\" align=\"center\">";

if ($i<12) {
$query3 = "SELECT * FROM schedule WHERE date = '$tomorrow3' AND time = '".$i."AM-".$j."AM' ORDER BY time asc";
} elseif ($j == 12) {
$query3 = "SELECT * FROM schedule WHERE date = '$tomorrow3' AND time = '".$i."AM-".$j."Noon' ORDER BY time asc";
} elseif ($i == 12) {
$query3 = "SELECT * FROM schedule WHERE date = '$tomorrow3' AND time = '".$i."Noon-".$j."PM' ORDER BY time asc";
} else {
$query3 = "SELECT * FROM schedule WHERE date = '$tomorrow3' AND time = '".$i."PM-".$j."PM' ORDER BY time asc";
}
$result3=mysql_query($query3) or die(mysql_error()); 
$row3=mysql_fetch_array($result3);


echo $row3['task'];
echo "<br>";
echo $row3['host'];
echo "</td><td valign=\"center\" align=\"center\">";







if ($i<12) {
$query4 = "SELECT * FROM schedule WHERE date = '$tomorrow4' AND time = '".$i."AM-".$j."AM' ORDER BY time asc";
} elseif ($j == 12) {
$query4 = "SELECT * FROM schedule WHERE date = '$tomorrow4' AND time = '".$i."AM-".$j."Noon' ORDER BY time asc";
} elseif ($i == 12) {
$query4 = "SELECT * FROM schedule WHERE date = '$tomorrow4' AND time = '".$i."Noon-".$j."PM' ORDER BY time asc";
} else {
$query4 = "SELECT * FROM schedule WHERE date = '$tomorrow4' AND time = '".$i."PM-".$j."PM' ORDER BY time asc";
}
$result4=mysql_query($query4) or die(mysql_error()); 
$row4=mysql_fetch_array($result4);


echo $row4['task'];
echo "<br>";
echo $row4['host'];
echo "</td>";



$i++;
$j++;

}
}
echo "</tr>";
echo "</table>";



echo "</html>";



?>

kburger

Yeah, that's pretty ugly. To be honest, I wouldn't want to touch it unless I did a complete re-write. If nothing else, proper indention would help. One thing that jumped out at me, though.

<?
while($i<=23) 
while($j<=24)
{
{ 
?>

I'm actually surprised this even works. Don't you mean

<? 
while($i<=23) 
{
	while($j<=24)
	{
?>

Not to mention the fact that you've got 23*24 plus database queries going on.

bbmak

yes this is working, but please help. I know the script is bucky

kburger wrote:
Yeah, that's pretty ugly. To be honest, I wouldn't want to touch it unless I did a complete re-write. If nothing else, proper indention would help. One thing that jumped out at me, though.
<?
while($i<=23) 
while($j<=24)
{
{ 
?>
I'm actually surprised this even works. Don't you mean
<? 
while($i<=23) 
{
	while($j<=24)
	{
?>
Not to mention the fact that you've got 23*24 plus database queries going on.

laserlight

I'm actually surprised this even works.

It does, just like one can use:

if (condition1)
	if (condition2) {
		//code
	}

But yeah, indentation and the use of braces helps, but in the first place you should always state what you are trying to do (not simplify the source, but what the source itself is supposed to do).

LoganK

laserlight wrote:
It does, just like one can use:
if (condition1)
	if (condition2) {
		//code
	}

I noticed that too...if you look you'll see I had a small thread about that a while back.