Efficient Code - using loop?

[obrienkev]

Morning all,

How can I make the below code more efficient? How do I place it in loop?

thanks,

Kevin.

// inserting to archive from rights
$query1 = "INSERT INTO archive(name, type, size, content, file_date) SELECT name, type, size, content, file_date FROM rights WHERE CURDATE() >= DATE_ADD(file_date, INTERVAL 1 DAY)";
$result1 = mysql_query($query1) or die(mysql_error());

// inserting to archive from spin offs
$query2 = "INSERT INTO archive(name, type, size, content, file_date) SELECT name, type, size, content, file_date FROM spin_offs WHERE CURDATE() >= DATE_ADD(file_date, INTERVAL 1 DAY)";
$result2 = mysql_query($query2) or die(mysql_error());

// inserting to archive from splits
$query3 = "INSERT INTO archive(name, type, size, content, file_date) SELECT name, type, size, content, file_date FROM splits WHERE CURDATE() >= DATE_ADD(file_date, INTERVAL 1 DAY)";
$result3 = mysql_query($query3) or die(mysql_error());

[mrhappiness]

$tables = array('rights', 'spin_offs', 'splits');

foreach ($tables as $table) {
  $query = "INSERT INTO archive(name, type, size, content, file_date) SELECT name, type, size, content, file_date FROM ".$table." WHERE CURDATE() >= DATE_ADD(file_date, INTERVAL 1 DAY)";
  $result = mysql_query($query) or die(mysql_error());
}

why do you have 4 tables that look exactly the same?

[obrienkev]

why do you have 4 tables that look exactly the same?

Because I want to separate the data into relevant tables. Any more efficient way of using the tables?

Basically I had 4 file options for the user to upload relevant files so I thought having 4 tables would be right?

Any way that I could insert a unique id or something to identify if file is a spin_off or merger, etc.?

thanks,

Kevin.

[mrhappiness]

obrienkev wrote:

Because I want to separate the data into relevant tables. Any more efficient way of using the tables?[/b]

only one table with an additional column called the_type being one of spin_offs, rights, ...

Any way that I could insert a unique id or something to identify if file is a spin_off or merger, etc.?

see above 🙂