Functions within Classes, IPB1.3 Related

[DrDre]

Im using IPB 1.3.. and trying to code a module, except im having some issues, Like im including a file into the skin file which is working fine, except I cant make any functions.

I need to make a function, but if i put it in the file im including, the page stops loading and stays white, Now if i remove the function, itll still be white until i comment out all the calls to the function...

Now of course the error is saying 'unknown function blah blah', but i dont see this on my screen, ive even changed the error_reporting stuff in index.php yet still doesnt show.

Anyone know how I can show errors? And anyone care to help with classes & functions.

in skin_ffxi.php i have

class skin_ffxi {
  function main(){

global $ibforums;
@include ("/home/wwwfane/www/eov/ffxi.php");
return "
	<table cellspacing=0 cellpadding=0 width='100%'>
  	<tr>
     <!------ ---- ---------->
     <!------ MENU ---------->
	   <td id=ucpmenu valign=top>
		 	$thelinks
		 </td>
     <!---             -->
     <!--- ENDMENU     -->

     <td style='padding:.5px'><!-- --></td>
		 	<!-- Start main CP area -->
			<td id=ucpcontent valign=top>
			<div class='maintitle'>FFXi - $pagetitle</div>

			<table width='100%' border=0 cellspacing=0 cellpadding=4>
				<tr> 
    		  <td width=100%>
      		$output	  
      		</td>
				</tr>
			</table>
 	  </td>
      </tr>

      </table>
      <!-- end main CP area -->
      <br clear=all />

		  </div>";
  }

}

the function im needing to use:

  function CheckValue($x){
    $x=eval("return $x;");
    if (preg_match ("/[^0-9]/",$x)){
      if($x > 106 || $x < 0){
    	  return false;
      }else{
  	    return true;
      }
    }else{
    return false;
    }
	}

the file im including, well a chunk of it where my problem is:

if($show == 'profile'){
	$output="";
	$tst=mysql_query("SELECT * FROM `ibf_ffxi` WHERE `id`='$mid'");
	if(mysql_num_rows($tst) == 0)  { mysql_query("INSERT INTO `ibf_ffxi` SET `id`='$mid'");}
	$output .= mysql_error();
	if($mgroup == 1 || $mgroup == 2){ $output=$redirectlogin;exit;}
	if($profile == 'editcrafting'){
	$pagetitle="Editing Crafting Info";
		if($_POST[Alchemy]  || $_POST[Bonecraft]    || $_POST[Clothcraft]   || 
			 $_POST[Cooking]  || $_POST[Goldsmithing] || $_POST[Leathercraft] || 
			 $_POST[Smithing] || $_POST[Woodworking]  || $_POST[Fishing]){
			 $errormsg="<font color=red>Invalid Ammount: Must be 0-106 or xxx+x, Max value of 106.</font>";
			 /*if(CheckVar($_POST[Alchemy])){ $error1=$errormsg;}
 			 if(CheckVar($_POST[Bonecraft])){ $error2=$errormsg;}
 			 if(CheckVar($_POST[Clothcraft])){ $error3=$errormsg;}
 			 if(CheckVar($_POST[Cooking])){ $error4=$errormsg;}
 			 if(CheckVar($_POST[Goldsmithing])){ $error5=$errormsg;}
 			 if(CheckVar($_POST[Leathercraft])){ $error6=$errormsg;}
 			 if(CheckVar($_POST[Smithing])){ $error7=$errormsg;}
 			 if(CheckVar($_POST[Woodworking])){ $error8=$errormsg;}
 			 if(CheckVar($_POST[Fishing])){ $error9=$errormsg;}
			 */
			 

How Can i be able to use this function inside this file? Should it be in a class and I need to call the class some how?

[Roger_Ramjet]

Read up on SCOPE. Generally speaking, in any language, a function in a class only has scope within that class. To call it from outside you need to make it a method with public scope. Can't be any more specific cos I don't much use classes and objects in PHP and I don't know a thing about IBP.

[drew010]

as for the errors,

ini_set('display_errors', 1);
error_reporting(E_ALL);

[DrDre]

drew010 wrote:

as for the errors,

ini_set('display_errors', 1);
error_reporting(E_ALL);

Thats not my problem, Every other file works normal, its something with invision ;x

Like, if you edit a source file and accidently add whitespace at end (thanks to some editors >.>) if using a header redirect, anytime the board tries to redirect it just gives a white page, due to the Headers already sent message. Any time a Critical Error is flagged, its not shown, but just displays a white page... Even with Error reporting set to All.

About the functions, ill try to look up into it, if someone could modify my code and show me an example of how to do it it would be great, Im pretty good with PHP, with classes being my weak point ._.

edit: lol i just noticed one problem, i used CheckVar in code, and CheckValue as function name, ima fix that and see if itll work.

Really hard to debug problems when you dont see the error's ; ;\

edit2: /cheer

adding that code into the ffxi.php file is now showing me errors for this file at least, i guess that option is set somewhere in the ipb core to not show them.. and im overwriting. Now to debug.

Fatal error: Call to undefined function: checkvar() in /home/wwwfane/public_html/eov/ffxi.php on line 83

Edit 3:

rofl.. i feel stupid now.because i was including the file twice, the error was cannot redeclare the function... i think I have it working now.

Thanks for help guys. I just tossed the function into skin_ffxi file.

[DrDre]

Now one more final help request..

  function CheckVar($x){
    $x=eval("return $x;");
    if (preg_match ("/[^0-9]/",$x)){
      if($x > 106 || $x < 0){
    	  return false;
      }else{
  	    return true;
      }
    }else{
    return false;
    }
	}

My Regex usage must be wrong.. as the check isnt working, its letting me enter non numbers :x

What would be a proper regex that checks to make sure the value is between 0 and 106?

[DrDre]

Well im all good now, messed around with it and got

  function CheckVar($x){
    $x=eval("return $x;");
    if (preg_match ("/[0-9]/",$x)){
      if($x > 106 || $x < 0){
    	  return false;
      }else{
  	    return true;
      }
    }else{
    return false;
    }
	}

and its working now.

Thanks for help everyone.

[drew010]

just a quick note on the regex, im guessing you are trying to check if its a number, if so you can use [man]ctype_digit[/man] instead. it will be quicker. also though, the pattern /[0-9]/ would match for a number like 123, but also works for hello9953text because its just checking for one number.
the proper pattern for all digits would be /^\d+$/ (you could use [0-9]+ instead of \d+ , same thing. the reason for the ^ is that indicates the beginning of the string, and the $ means end of the string. so its checking for the beginning, 1 or more digits, and then end. doesnt allow for any letters, symbols or spaces.

[DrDre]

ah thanks, i dunno how i skipped testing digit+number, but you was right, thanks for the correction, that works.