[RESOLVED] php generated table error. need help!

trendMM

Hi,

I was working on a clothing site and I was looking to organize the shirts in a table generated from the DB. I got it working fine going in columns and rows like i wanted, but for some reason it's not pulling all of the posts in that table. Right now there is 9 shirts in the table and it's only displaying 8. I looked at my coding and can't seem to figure out what the problem may be.

<table border="0" cellpadding="4" cellspacing="0" width="100%">
<?

// Define database connection details
$dbHost = "localhost";
$dbUser = "xxx";
$dbPass = "xxx";
$dbName = "xxx";
$table = "xxx";


// Attempt to connect to MySQL server
$link = @mysql_connect($dbHost, $dbUser, $dbPass);

// If the connection was unsuccessful...
if (!$link)
{
    // Report error to browser and exit
    print ("Could not connect to server");
    exit;
}

// Attempt to select database. If unsuccessfull...
if (!@mysql_select_db($dbName))
{
    // Report error to the browser and exit
    print ("Could not select $dbName database");
    exit;
}

// Build query to fetch shirts from database
$query = "SELECT * FROM shirts ORDER BY title";

// Execute query
$result = @mysql_query($query);

// If query was okay AND we have at least 1 shirt item...
if ($result && @mysql_num_rows($result) > 0)
{

// For each updates item returned from query...
while($row = mysql_fetch_array($result))
{




 $i = 0; 
echo "<tr>\n"; 
while($row = mysql_fetch_array($result)) 
{ 
    $i++; 
	echo "<td align=\"center\" valign=\"top\"><table border=\"0\" cellpadding=\"0\" cellspacing=\"0\" width=\"10\" height=\"10\"><tr><td align=\"center\" valign=\"top\"><a href=\"?id=shirts&shirtID=".$row['shirtsID']."\" title=\"More Info\"><img src=\"cms/uploads/thumb.php?file=photos/".$row['pic1']."&size=240\" border=\"0\"><br><font class=\"reg1\"><img src=\"files/images/layout/bttn_more.gif\" border=\"0\" hspace=\"2\" vspace=\"2\"></a><br></font></td></tr></table></td>\n"; 
    if($i%3==0) 
    { 
        echo "</tr>\n<tr>"; 
    } 
}


}

}
else
{
// Tell the browser no shirts were found
print ("No shirts found in the database.<br>") ;
}

mysql_close();

?>
</table>

By looking at the code above I don't see anything wrong. If someone could please point out what I'm doing wrong I'd really appreciate it. Thanks in advance!

Evan

rebelo

You've got the $i++ increment operator in the wrong place. You should move it to AFTER you display the code. Basically you're immediately changing your index to 1 before starting the loop (after initializing it to 0).

trendMM

where exactly in my code am i going to want to move it to?

rebelo

Change this:


while($row = mysql_fetch_array($result)) 
{ 
    $i++; 
    echo "<td align=\"center\" valign=\"top\"><table border=\"0\" cellpadding=\"0\" cellspacing=\"0\" width=\"10\" height=\"10\"><tr><td align=\"center\" valign=\"top\"><a href=\"?id=shirts&shirtID=".$row['shirtsID']."\" title=\"More Info\"><img src=\"cms/uploads/thumb.php?file=photos/".$row['pic1']."&size=240\" border=\"0\"><br><font class=\"reg1\"><img src=\"files/images/layout/bttn_more.gif\" border=\"0\" hspace=\"2\" vspace=\"2\"></a><br></font></td></tr></table></td>\n"; 
    if($i%3==0) 
    { 
        echo "</tr>\n<tr>"; 
    } 
}

To this:


while($row = mysql_fetch_array($result)) 
{ 
    echo "<td align=\"center\" valign=\"top\"><table border=\"0\" cellpadding=\"0\" cellspacing=\"0\" width=\"10\" height=\"10\"><tr><td align=\"center\" valign=\"top\"><a href=\"?id=shirts&shirtID=".$row['shirtsID']."\" title=\"More Info\"><img src=\"cms/uploads/thumb.php?file=photos/".$row['pic1']."&size=240\" border=\"0\"><br><font class=\"reg1\"><img src=\"files/images/layout/bttn_more.gif\" border=\"0\" hspace=\"2\" vspace=\"2\"></a><br></font></td></tr></table></td>\n"; 
    if($i%3==0) 
    { 
        echo "</tr>\n<tr>"; 
    } 
    $i++;
}

trendMM

no good 🙁. i tried it. tried to move it to other areas and it still only showed 8 and it moved everything around....🙁

rebelo

Well, for starters, do this before the while loop:


echo "<br>DEBUG: The number of returned rows is ".mysql_num_rows($result)."<br>";

Make sure there are actually 9 rows being returned.

Also, the fact that you're starting with a value of 0 instead of 1 now will affect your modulus check. You will need to re-evaluate the way you're checking the row.

I have to head out now, so good luck.

trendMM

i ran that code. says there are 9 returned but only displays 8. i changed 0 to 1 and it didn't do anything. i'll see what i can do. thanks a lot for your help so far...

trendMM

does anyone have any idea of what i can do to make this thing work?

trendMM

oh wow. i got it fixed. the while loop was in there twice and i didnt even notice it. thanks for your help!