[RESOLVED] Wrong id number showing for id 10 only

[mAGOO]

Hi,

I've been trying to work out what the hell is wrong with the code, but I can't find anything. I've changed the id values to 0 and others and all results are as to be expected. The actual code works fine and I get everyone's correct id number, all except for id 10. 10 always returns as 9 eventhough it is 10 the the DB. MySQL DB.

/* Select all pilots */
$query = "SELECT * FROM reports ORDER BY report_id DESC limit 50";
$result = mysql_query($query);

/* Determine the number of pilots */
$number = mysql_numrows($result);

if ($number > 0) {
	/* Print roster header 
	   Change this HTML to fit your webpage layout */
	print "<table align=center>";
	print "<tr>";
	print "<td class=FSACARS3>ID</td>";	
	print "<td class=FSACARS3>PILOT ID</td>";
	print "<td class=FSACARS3>DATE</td>";
	print "<td class=FSACARS3>CALLSIGN</td>";
	print "<td class=FSACARS3>FROM</b></td>";
	print "<td class=FSACARS3>TO</td>";	
	print "<td class=FSACARS3>REG</td>";
	print "<td class=FSACARS3>EQUIPMENT</td>";
	print "<td class=FSACARS3>DURATION</td>";	
	print "<td class=FSACARS3>FUEL</td>";
	print "<td class=FSACARS3>DISTANCE</td>";
	print "<td class=FSACARS3>DETAILS</td>";	
	print "</tr>";

/* Get report info */
for ($i=0; $i<$number; $i++) {
 		$ireport = mysql_result($result,$i,"report_id");
 		$id = mysql_result($result,$i,"id");
		$date = mysql_result($result,$i,"date");
 		$time = mysql_result($result,$i,"time");
 		$fsacars = mysql_result($result,$i,"fsacars_rep_url");
 		$report = mysql_result($result,$i,"report_id");
		$callsign = mysql_result($result,$i,"callsign");
 		$origin = mysql_result($result,$i,"origin_id");
 		$destination = mysql_result($result,$i,"destination_id");
     	$registration = mysql_result($result,$i,"registration");
 		$equipment = mysql_result($result,$i,"equipment");
 		$duration = mysql_result($result,$i,"duration");
		$fuel = mysql_result($result,$i,"fuel");
 		$distance = mysql_result($result,$i,"distance");
		$id = $id-1;
//			$id = $id-1;

		/* Calculate flight hours */
		$query_hours = "SELECT sec_to_time(sum(time_to_sec(t2.duration))) AS duration_sum FROM pilots t1, reports t2 WHERE t1.id=$id AND t1.id=t2.id";
		$result_hours = mysql_query($query_hours);

		if (mysql_numrows($result_hours) > 0) {
		$time = mysql_result($result_hours,0,"duration_sum");
	}

?>

I have also tested to see if it would happen on 100, and guess what? 100 showed as 100.

I am lost for this one. Can anyone see what is wrong or why this is happening?

Cheers
Steph.

[Drakla]

What's that $id = $id - 1 for?

And did you inherit that code from somewhere?

[mAGOO]

the $id = $id - 1 is the offset for some reason. If I take this out it returns the ID plus 1. eg 10 will show as 11, 22 will show as 23. This is the confusing part too, when I play with these offsets, the 10 works properly in that it gives the correct offset.

eg if I set $id = $id - 2
then 10 will show as 8

Yes I did get this from FSACARS system via another person who sent me the file. I'm not a php person which doesn't help. But I'm learning .

[Drakla]

Looks like you'll have to show more of that code, as you're echoing out rows as you go along I take it, so you might have to post more of it so we can see what's going on.

The subtracting from the ID would seemingly make the 2nd query off track, as you're not putting in the ID of the data you just pulled back.

I know it's not your fault but I find that entire piece of code really awful, mostly because of its use of mysql_result as to fetch every field means you're calling a function when it could have all been called into an array with mysql_fetch_assoc().

[mAGOO]

There's actually not too much more of it. But here it is.

Thanks for looking at this too.

<div align="center">Last 50 reports filed  

  <?php
/* Constants */
@define ("MYSQL_CONNECT_INCLUDE", "connect_db.php");		// MySQL database connection (a sample file is included)


/* Database connection */
include(MYSQL_CONNECT_INCLUDE);

/* Select all pilots */
$query = "SELECT * FROM reports ORDER BY report_id DESC limit 50";
$result = mysql_query($query);

/* Determine the number of pilots */
$number = mysql_numrows($result);

if ($number > 0) {
	/* Print roster header 
	   Change this HTML to fit your webpage layout */
	print "<table align=center>";
	print "<tr>";
	print "<td class=FSACARS3>ID</td>";	
	print "<td class=FSACARS3>PILOT ID</td>";
	print "<td class=FSACARS3>DATE</td>";
	print "<td class=FSACARS3>CALLSIGN</td>";
	print "<td class=FSACARS3>FROM</b></td>";
	print "<td class=FSACARS3>TO</td>";	
	print "<td class=FSACARS3>REG</td>";
	print "<td class=FSACARS3>EQUIPMENT</td>";
	print "<td class=FSACARS3>DURATION</td>";	
	print "<td class=FSACARS3>FUEL</td>";
	print "<td class=FSACARS3>DISTANCE</td>";
	print "<td class=FSACARS3>DETAILS</td>";	
	print "</tr>";

/* Get report info */
for ($i=0; $i<$number; $i++) {
 		$ireport = mysql_result($result,$i,"report_id");
 		$id = mysql_result($result,$i,"id");
		$date = mysql_result($result,$i,"date");
 		$time = mysql_result($result,$i,"time");
 		$fsacars = mysql_result($result,$i,"fsacars_rep_url");
 		$report = mysql_result($result,$i,"report_id");
		$callsign = mysql_result($result,$i,"callsign");
 		$origin = mysql_result($result,$i,"origin_id");
 		$destination = mysql_result($result,$i,"destination_id");
     	$registration = mysql_result($result,$i,"registration");
 		$equipment = mysql_result($result,$i,"equipment");
 		$duration = mysql_result($result,$i,"duration");
		$fuel = mysql_result($result,$i,"fuel");
 		$distance = mysql_result($result,$i,"distance");
		$id = $id-1;
//			$id = $id-1;

		/* Calculate flight hours */
		$query_hours = "SELECT sec_to_time(sum(time_to_sec(t2.duration))) AS duration_sum FROM pilots t1, reports t2 WHERE t1.id=$id AND t1.id=t2.id";
		$result_hours = mysql_query($query_hours);

		if (mysql_numrows($result_hours) > 0) {
		$time = mysql_result($result_hours,0,"duration_sum");
	}

?>
</div>
<div align="center"></div>
<table height="15" align="center">
  <tr align="center" valign="middle">
    <td class="FSACARS2"><? echo $report; ?></td>
    <td class="FSACARS2"><? if ($id<10) 
					{ echo "AN"; echo $id; } else { echo "AN"; echo $id +1; } ?></td>
    <td class="FSACARS2"><? echo $date; ?></td>
    <td class="FSACARS2"><? echo $callsign; ?></td>
    <td class="FSACARS2"><? echo $origin; ?></td>
    <td class="FSACARS2"><? echo $destination; ?></td>
    <td class="FSACARS2"><? echo $registration; ?></td>
    <td class="FSACARS2"><? echo $equipment; ?></td>
    <td class="FSACARS2"><? echo $duration; ?></td>
    <td class="FSACARS2"><? echo $fuel; ?></td>
    <td class="FSACARS2"><? echo $distance; ?></td>
    <td class="FSACARS2"><a href="<? echo $fsacars; ?>" target="_blank">REPORT</a></td>
  </tr>
</table>
<?
	}

print "</table>";
}


/* Close the database connection */
mysql_close();
?>
<?php include('footer.php'); ?>

[mAGOO]

Thanks for looking at it but I ended up starting from scratch using the way suggested.

Here's the code I used. Remeber, i'm onlyb starting php so the code won't be the best, but it's simple and does what it's meant to.

I'm still curious as to why the original code did that, so if anyone can tell me, that would be great.

<div align="center">
<form name="form1" method="post" action="">
  <p align="center">Enter a pilot NUMBER: 
    <input name="pilot" type="text" id="pilot" size="5"> 
    &nbsp;
    <input type="submit" name="Submit" value="By Pilot Number">
</p>
</form>
<p>Last 50 reports filed <br>
  <link rel="stylesheet" type="text/css" href="/css/css.css">
  <?php
/* Constants */
@define ("MYSQL_CONNECT_INCLUDE", "connect_db.php");		// MySQL database connection (a sample file is included)
/* Database connection */
include(MYSQL_CONNECT_INCLUDE);

$query = "SELECT * FROM reports WHERE id='$pilot' ORDER BY report_id DESC";
//$query = "SELECT * FROM reports ORDER BY report_id DESC limit 50";
$result = mysql_query($query);

	print "<table align=center>";
	print "<tr>";
	print "<td class=FSACARS5 width=30>ID</td>";	
	print "<td class=FSACARS5 width=50>PILOT ID</td>";
	print "<td class=FSACARS5 width=70>DATE</td>";
	print "<td class=FSACARS5 width=70>TIME</td>";
	print "<td class=FSACARS5 width=70>CALLSIGN</b></td>";
	print "<td class=FSACARS5 width=50>ORIG</td>";	
	print "<td class=FSACARS5 width=50>DEST</td>";
	print "<td class=FSACARS5 width=70>REG</td>";
	print "<td class=FSACARS5 width=70>EQUIPMENT</td>";	
	print "<td class=FSACARS5 width=70>DURATION</td>";
	print "<td class=FSACARS5 width=50>FUEL</td>";
	print "<td class=FSACARS5 width=50>DIST</td>";	
	print "<td class=FSACARS5 width=50>REPORT</td>";	
	print "</tr>";

while($row = mysql_fetch_assoc($result))
{
		print "<table align=center><tr>";
		print "<td class=FSACARS4 align=center width=30>{$row['report_id']}</td>";
		print "<td class=FSACARS4 align=center width=50>AN{$row['id']}</td>";
		print "<td class=FSACARS4 align=center width=70>{$row['date']}</td>";
		print "<td class=FSACARS4 align=center width=70>{$row['time']}</td>";
		//         "<td width=50>{$row['fsacars_rep_url']}</td>" .
		//         "<td width=20>{$row['report_id']}</td>" .
		print "<td class=FSACARS4 align=center width=70>{$row['callsign']}</td>";
		print "<td class=FSACARS4 align=center width=50>{$row['origin_id']}</td>";
		print "<td class=FSACARS4 align=center width=50>{$row['destination_id']}</td>";
		print "<td class=FSACARS4 align=center width=70>{$row['registration']}</td>";
		print "<td class=FSACARS4 align=center width=70>{$row['equipment']}</td>";
		print "<td class=FSACARS4 align=center width=70>{$row['duration']}</td>";
		print "<td class=FSACARS4 align=right width=50>{$row['fuel']}</td>";
		print "<td class=FSACARS4 align=right width=50>{$row['distance']}</td>";
		print "<td class=FSACARS4 align=center width=50><a href={$row['fsacars_rep_url']}>Report</a></td></tr></table>";
} 

/* Close the database connection */
mysql_close();
?>
  <?php include('footer.php'); ?>

Cheers
Steph