Downloading File From Server

[obrienkev]

Hi all,

The below code is used to download a excel file from the server.
However, my problem is that it won't open the file - In IE6 it gives the 'Unable to read file' error.
I believe this line is the problem...

list($name, $type, $size) = mysql_fetch_array($result);

$size doesn't seem to be set. When the pop-up download window appears asking me if I want to open or save the file it doesn't show the file size.

Tried moving that line into the while loop but only made a mess. The code works fine if getting file from database thus without the while loop.

Any ideas? Thanks.

// perform query
$query   = "SELECT name, type, size FROM financial_statements ".
                              "WHERE id = '$id'";
$result  = mysql_query($query) or die(mysql_error());
list($name, $type, $size) = mysql_fetch_array($result);

$num_results = mysql_num_rows($result);

if ($num_results > 0)
{
   while($file = mysql_fetch_array($result))
    {
    // filepath
    $uploaddir = 'admin/uploads/images/';
    $uploadfile = $uploaddir . basename($file['name']);
    echo 'Filename ('.$uploadfile.') '.$file['name'].'....<br />';
    }

// Set Headers
if(isset($_SERVER['HTTP_USER_AGENT']) && preg_match("/MSIE/", $_SERVER['HTTP_USER_AGENT']))
{
// IE Bug in download name workaround
 ini_set( 'zlib.output_compression','Off' );
}   

header('Content-type: ' . $type);
header('Content-length: '. $size);
header("Pragma: public");
header("Cache-Control: must-revalidate, post-check=0, pre-check=0");
header('Content-Disposition: attachment; filename="' . $name . '"');
print($uploadfile);

exit;
}

[obrienkev]

Hi all,

Think my problem is that mysql_fetch_array($result)
is set twice.

Any ideas how to get around this?

[Weedpacket]

Read your code. You fetch fields from the result and then you check to see if there were any results. Then you forget you've already fetched your fields and then try to fetch them again. After that you dither between one set of fetched fields and the other. It looks like two people trying to write the same piece of code simultaneously and refusing to talk to each other.

Since you're only going to be getting at most one result at a time, and hence there's no point using a while to loop through all the results:

if ($num_results > 0)
{
   list($name, $type, $size) = mysql_fetch_array($result);

[obrienkev]

It seems to have the right file path anyway based on the output below.

Output: 1
Filename (admin/uploads/images/finance8.jpg) finance8.jpg....

However, the image still does not open. Maybe a header issue??? I can save the image to my desktop and it opens fine. On the download window - asking me if I want to save/open the image it doesn't state the image size either while it does if file comes from database. That help any bit??

Here's my download code updated...

		// Connect to database
		include('db_connect.php'); 

	// set variable for link
$id    = $_GET['id2'];
	//$value = NOW();
	//echo '<br />'.$value.'<br /><br />';

	// perform query
$query   = "SELECT name, type, size FROM simple_tbl ".
					 	 "WHERE id = '$id'";
	$result  = mysql_query($query) or die(mysql_error());
//list($name, $type, $size) = mysql_fetch_array($result);

	$num_results = mysql_num_rows($result);
	echo $num_results;
	if ($num_results > 0)
	{
	 	 list($name, $type, $size) = mysql_fetch_array($result);

		 // filepath
		 $uploaddir = 'admin/uploads/images/';
		 $uploadfile = $uploaddir . basename($name);
		 echo 'Filename ('.$uploadfile.') '.$name.'....<br />';


	// Set Headers
if(isset($_SERVER['HTTP_USER_AGENT']) && preg_match("/MSIE/", $_SERVER['HTTP_USER_AGENT'])) 
  {
   // IE Bug in download name workaround
   ini_set( 'zlib.output_compression','Off' );
}    

header('Content-type: ' . $type);
  header('Content-length: '. $size);
header("Pragma: public");
header("Cache-Control: must-revalidate, post-check=0, pre-check=0");
header('Content-Disposition: attachment; filename="' . $name . '"');
//print($uploadfile);

exit;
	} // end if ($num_results)

[obrienkev]

The download window doesn't read in the $size variable. Any ideas why this is. I think it affects the displaying of the file.