Some kind of problem in my php coding

Reality15

I've attached my code for a ratings/reviews script. Can anyone tell me what's wrong with it? (login info deleted)

<?php
$type = $_GET['type'] ;
$id = $_GET['id'] ;
$ip = $_SERVER['REMOTE_ADDR'] ;

$link=mysql_connect(HOST','USERNAME','PASSWORD')
or die('Could not connect: ' . mysql_error());
mysql_select_db('DATABASE') or die('Could not select database');


$result = mysql_query("SELECT *  FROM `reviews` WHERE `type` = '$type' AND `attractionid` = '$id' AND `ip` = '$ip'");
if (!$result) { 
	$final = mysql_query("SELECT * FROM `reviews` WHERE `attractionid` = '$id' AND `type` = '$type'");
	if (!$final) { 
	echo mysql_error(); 
	exit; 
	}
	while ($array = mysql_fetch_array($final)) {
	extract($array);
	}
echo "
                          <table border='0' width='300' cellspacing='0' bgcolor='#000000'>
                            <tr>
                              <td width='100%'>
                                <table border='0' width='100%' cellspacing='0' cellpadding='5' bgcolor='#FFFFFF'>
                                  <tr>
                                    <td width='175'><b><font size='2' face='Arial'>$author</font></b></td>
                                  </center>
                                  <td width='125'>
                                    <p align='right'><b><font size='2' face='Arial'>Rating
                                    : $rating / 10</font></b></td>
                                </tr>
                                <tr>
                                  <td width='300' colspan='2' bgcolor='#000000' height='1'></td>
                                </tr>
                                <tr>
                                  <td width='300' colspan='2'><font face='Arial' size='1'>$review</font></td>
                                </tr>
                              </table>
                            </td>
                          </tr>
                          </table> 
				<br>
"; 




?>
                        </div>
                 <form method="POST" action="addreview.php">
                  <table border="0" width="300" bgcolor="#000000" cellspacing="0">
                    <tr>
                      <td width="100%">
                        <table border="0" width="100%" bgcolor="#EF9E20" cellspacing="0" cellpadding="5">
                          <tr>
                            <td width="100%">
                              <p align="center"><b>Add Your Review</b></td>
                          </tr>
                        </table>
                      </td>
                    </tr>
                    <tr>
                      <td width="100%">
                        <table border="0" width="100%" bgcolor="#FFFFFF" cellspacing="0" cellpadding="5">
                          <tr>
                            <td width="100%">
                              <p align="center"><font face="Arial" size="2">Your
                              Name : <input type="text" name="author" size="20"><br>
                              Rate this Attraction : <select size="1" name="rating">
                                <option value="10">10 - Great</option>
                                <option value="9">9</option>
                                <option value="8">8</option>
                                <option value="7">7</option>
                                <option value="6">6</option>
                                <option value="5">5</option>
                                <option value="4">4</option>
                                <option value="3">3</option>
                                <option value="2">2</option>
                                <option value="1">1 - Terrible</option>
                              </select><br>
                              Your Review<br>
                              <textarea rows="5" name="review" cols="20"></textarea>
<input type="hidden" name="ip" value="<?php echo $ip ?>">
<input type="hidden" name="type" value="<?php echo $type ?>">
<input type="hidden" name="id" value="<?php echo $id ?>">
</font></td>
                          </tr>
                        </table>
                      </td>
                    </tr>
                    <tr>
                      <td width="100%">
                        <table border="0" width="100%" bgcolor="#EF9E20" cellspacing="0" cellpadding="5">
                          <tr>
                            <td width="100%">
                              <p align="center">
<input type="submit" value="Submit" name="B1"></p>
                            </td>
                          </tr>
                        </table>
                      </td>
                    </tr>
                  </table>
                  &nbsp;
                 </form>
<?php
	}
else {



$final = mysql_query("SELECT * FROM `reviews` WHERE `attractionid` = '$id' AND `type` = '$type'");
if (!final) { 
echo mysql_error(); 
exit; 
}
while ($array = mysql_fetch_array($final)) {
extract($array);
}
echo "
                          <table border='0' width='300' cellspacing='0' bgcolor='#000000'>
                            <tr>
                              <td width='100%'>
                                <table border='0' width='100%' cellspacing='0' cellpadding='5' bgcolor='#FFFFFF'>
                                  <tr>
                                    <td width='175'><b><font size='2' face='Arial'>$author</font></b></td>
                                  </center>
                                  <td width='125'>
                                    <p align='right'><b><font size='2' face='Arial'>Rating
                                    : $rating / 10</font></b></td>
                                </tr>
                                <tr>
                                  <td width='300' colspan='2' bgcolor='#000000' height='1'></td>
                                </tr>
                                <tr>
                                  <td width='300' colspan='2'><font face='Arial' size='1'>$review</font></td>
                                </tr>
                              </table>
                            </td>
                          </tr>
                          </table> 
				<br>
"; 




?>
                        </div>
                 <p align="center"><font face="Arial" size="2">Thank you for
                 reviewing this attraction!</font>
<?php
}

mysql_close($link);

?>

To whomever helps me with this, thank you SO MUCH!

~ Reality15
Owner of MIRollerCoast.com

leatherback

What is the problem you are having (Seriously, you don't expect us to just talke a guess here?)

Drakla

'Some kind of problem' is nothing to go on. It's about as useful as me saying "Oh, there's like - something wrong with it".

Specifics, dear, specifics.

Reality15

When I include this in a page, it displays a blank review box and the "thank you for adding your review" text, instead of no review box (the database is empty) and the Add Review box.

Sorry, didn't mean to be so vague. :bemused:

leatherback

Well, you need to test whether there are reviews in the database, which you not do:

if(A RECORD)
{
DISPLAY RECORDS
}
else
{
DISPLAY ADD REVIEW
}

Reality15

No, if there's no reviews it should not show at all. Here's how it would work:

If there are reviews in the database {
show reviews
}
if not {
don't show reviews
}
If you have already submitted a review (there's a review with the same type, attraction id, and ip address in the database) {
"Thanks for submitting your review!"
if not {
show add review box
}

Does that make any sense? Is that what my original code reflects?

leatherback

It makes sense, but it is not what your code reflects. There is no if / then / else / structure anywhere. in your code, it will just go from each portion to the next. You need to place the {} around the sections you want to show after the if / else conditions are met.

Reality15

Could you give me a sample of what the if/than structure would look like? I tried to do it (there are if/than statements in there, I believe), but must be it's not working right.

leatherback

if(A RECORD)
{
DISPLAY RECORDS
}
else
{
DISPLAY ADD REVIEW
}

Reality15

So it would be (say variables are pre-determined by what they say)

if $record = TRUE
{
SHOW THE RECORDS
}
else {
DON'T SHOW THE RECORDS
}
if $ipalreadyreviewed = TRUE
{
"You have already reviewed this attraction."
}
else {
DISPLAY ADD REVIEW BOX
}

The part I'm confused with is how I determine if there are any entries in the database. If I call up the mySQL query and there's nothing in it, what happens with the array?

leatherback

The function mysql_num_rows will tell you how many rows are in a resulting recordset:

$query = SOMEQUERY
$result = mysql_query($query);
$rows = mysql_num_rows($result);

if($rows == 0)
{
...
}
else
{
. .
}

madwormer2

$link=mysql_connect(HOST','USERNAME','PASSWORD')

?? missing ' ? or just accidentally deleted when removing hostname?

leatherback

Reality15 wrote:
(login info deleted)

So just a typo, likely

halojoy

Some kind of problem in my php coding
I've attached my code for a ratings/reviews script. Can anyone tell me what's wrong with it? (login info deleted)

maybe
you should consider
my way
to avoid mysql issues, problems and ERRORS in my php scripts
when
using a sql
database

USE PHP Functions: fwrite fread

otherewise
I am afraid
you will be dependent on
letherback or other help

for rest of your life[right]you do better
depend on
halojoy

wise advice[/right]

🙂

thorpe

halojoy... why are you so scared of mysql?

leatherback

Thorpe,
don't even ask. We had thgat discussion before.

[rant]
He thinks that databases are too complicated to be used, requiore too many resources and cause trouble. He fails to realize that all data retrieval procedures in the end need toi be coded, and that one method is not better or worse then the other. Unfortunately, he feels like he has to convince everybody that is just starting that using a database is close to a crime. It is fine to give somebody an alternative. But to constantly keep nagging that people using databases are stupid, living on the dark side and will require help fo rthe rest of their lives is a bit silly.

Also, there seems to be a problem with his key-board, since he constantly switches alignment. But I suppose that is an other way of him to show that he thinks to be different, instead of actually showing people how to do things different. If asked directly, the reply is "I have my ways", instead of a direct answer.
[/rant]

Drakla

I'd love to see some benchmarks of this flatfile database, and know how well it scales. Is it indexed? Does it allow joins, standard and left. Grouping and NULL values? Foreign keys? Cascades, triggers, views?

Does the fact it uses php make it quicker than an already compiled and optimised executable?

Does it allow for clustering and replication?