Cookies

[NZ_Kiwis]

Hey,

I have a few questions. I have a log in script which starts a session. I have to keep using this but I also want to have a feature were if a user ticks a box it saves a cookie on their computer for ever (until the "log out")

I've never used cookies.... how would I set a cookie with no time limit???

[Drakla]

Go DAFT. The book in my sig is mostly excellent.

[NZ_Kiwis]

Okay so do I write something like this

if ($remember == '1') {
$value = 'My Website';
setcookie("TestCookie", $value, time()[phone]);

} else {
}

[Drakla]

Yup. Remember it's got to be written before any output, [man]setcookie[/man] has a list of common pifalls. Write a page that sets a cookie to a random value, or lets you input something to set it to, and also has

echo '<pre>'; print_r($_COOKIE); echo '</pre>';

in the page.

[NZ_Kiwis]

Drakla wrote:

Yup. Remember it's got to be written before any output, [man]setcookie[/man] has a list of common pifalls. Write a page that sets a cookie to a random value, or lets you input something to set it to, and also has

echo '<pre>'; print_r($_COOKIE); echo '</pre>';

in the page.

So I would need to change this then would I??

<?php
session_start();


// dBase file
include "dbConfig.php";

if ($redirect == "") {
$redirect = "http://www.site.com";
} 

if ($_GET["op"] == "login")
{
if (!$_POST["username"] || !$_POST["password"])
{
Header("Location: error.php");
}

// Create query 
$q = "SELECT * FROM `members` "			."WHERE `username`='".$_POST["username"]."' "
			."AND `password`='".$_POST["password"]."' "
			." LIMIT 1";

// Run query
$r = mysql_query($q);
if ( $obj = @mysql_fetch_object($r) )
{
// Login O.K., create session variables
$_SESSION["valid_id"] = $obj->id;
$_SESSION["valid_user"] = $_POST["username"];
$_SESSION["valid_time"] = time();


// Redirect to member page
require("../includes/currentdatetime.php"); 
$result6 = mysql_query ("SELECT * FROM members where username = '" . $_SESSION["valid_user"] . "';");
$row6 = mysql_fetch_array($result6);

$pre = $row6[lastlogin_stamp];
$total = $row6[login_times] + 1;
$result3 = mysql_query ("UPDATE members set login_times = '$total', prelogin_stamp = ' $pre' WHERE username = '" . $_SESSION ["valid_user"] . "';") or die("INSERT error: ".mysql_error());

$result = mysql_query ("UPDATE members set last_log_date = '$date', last_log_time = '$time', lastlogin_stamp = '$nowtime' WHERE username = '" . $_SESSION["valid_user"] . "';") or die("INSERT error: ".mysql_error());

// Set Cookie to remember this person next time.
if ($auto == '1') {
$value = 'TEST';
setcookie("RLNZ", $value, time()[phone]);  

}


Header("Location: $redirect");
}
else
{
// Login not successful
Header("Location: error.php");
}
}
else
{
Header("Location: error.php");
}
?>

[Drakla]

Not by the look of it, as I don't see any output there. But the value you're adding to the cookie time is stupidly big, it might even drive your value negative killing the cookie straight away - use something sensible like time() + 24 60 60 for a day, or 30 times that for 30 days.

[NZ_Kiwis]

OKay I've made it 3600,

when I add your line I get this error

Array
(
[PHPSESSID] => a1cb8ea7b1f668a1c55cc9b74c4a51d7
)

Warning: Cannot modify header information - headers already sent by (output started at /home/httpd/vhosts/site.com/httpdocs/login/auth.php:48) in /home/httpd/vhosts/site.com/httpdocs/login/auth.php on line 52

Why??

[Drakla]

Is auth the script above? And what's on line 52? I can't help you if you don't help me.

It could be an error message, an echo - anything. You are putting the print_r stuff AFTER all the cookie setting is done, yes?

[NZ_Kiwis]

Drakla wrote:

Is auth the script above? And what's on line 52? I can't help you if you don't help me.

It could be an error message, an echo - anything. You are putting the print_r stuff AFTER all the cookie setting is done, yes?

Yeah auth.php is the code above.... line 52 is the
Header("Location: $redirect");
line

yes it is after setting the cookie. so it looks like this

if ($auto == '1') {
$value = 'Rugby League in New Zealand';
setcookie("RLNZ", $value, time()+3600);

echo '<pre>'; print_r($_COOKIE); echo '</pre>';

}

[Weedpacket]

And what's on line 48 (you know, the line in the error message where the output started)?