how to reduce a repetitive code ?

graziano

I have following code to check the port status of a domain name
$domaintocheck on following ports
80,21,25,135,53

I wish to add some other port to check . Instead to repeat the code for every port
increasing the code , do you know any way to use the code 1 time to check all these ports 80,21,25,135,53 ?

Thank you
Graziano

# port 80
$fp = @fsockopen ($domaintocheck, 80, $errno, $errstr, 1);

if (!$fp) { 

     $problemping = 1;
    }

    }

} else { 
      $problemping = 0;
      fclose($fp);
}

# port 21
$fp = @fsockopen ($domaintocheck, 21, $errno, $errstr, 1);

if (!$fp) { 

     $problemping = 1;
    }

    }

} else { 
      $problemping = 0;
      fclose($fp);
}


# port 25
$fp = @fsockopen ($domaintocheck, 25, $errno, $errstr, 1);

if (!$fp) { 

     $problemping = 1;
    }

    }

} else { 
      $problemping = 0;
      fclose($fp);
}


# port 53
$fp = @fsockopen ($domaintocheck, 53, $errno, $errstr, 1);

if (!$fp) { 

     $problemping = 1;
    }

    }

} else { 
      $problemping = 0;
      fclose($fp);
}


# port 135
$fp = @fsockopen ($domaintocheck, 135, $errno, $errstr, 1);

if (!$fp) { 

     $problemping = 1;
    }

    }

} else { 
      $problemping = 0;
      fclose($fp);
}

laserlight

A simple idea would be to use arrays, e.g.

function checkPortStatus($domain, $ports) {
	$ret = array();
	$size = count($ports);
	for ($i = 0; $i < $size; $i++) {
		if (($fp = @fsockopen($domain, $ports[$i], $errno, $errstr, 1)) === true) {
			$ret[$i] = 0;
			fclose($fp)
		} else {
			$ret[$i] = 1;
		}
	}
	return $ret;
}

//example use
$problempings = checkPortStatus($domaintocheck, array(53, 135));

graziano

Thanks a lot !

graziano

regarding array ..

If I have

array(1,2,3,4,5,6,7,8,9,10)

may I write it in a different way for example

array(1-10)

Thank you

laserlight

Check out [man]range/man

graziano

thanks a lot!