[RESOLVED] Dropdown in search function

[codegirl42]

Hi All...

I've added a dropdown of states from the database into a search query....but it's still not pulling those users who are listed in that specific state...maybe you can help....

elseif (isset($GET["act"]) && $GET["act"]=="search") {
//$keyword = trim($GET["keyword"]);
$states = trim($GET["states"]);
echo "
<table width='450' align='center'><form action='members.php' method='get'>
<input type='hidden' name='act' value='search'>
<tr><td>Keyword(first name,last name)<input type='text' name='keyword'></td><td><input type='submit' value='Search'></td></tr>
<tr><td>State:</td><td><select name='state'>";
$query = "SELECT * FROM state";
$result = mysql_query($query);
while ($data = mysql_fetch_array($result)) {
$states = $data['name'];
echo "<option value='$states'";
if ($state == $states)
echo " selected";
echo ">$states</option>";
}
echo "</select></td></tr>";

		echo "</form></table></br></br></br>
		";

		/*if ($keyword=="") {
			echo "Invalid keyword";
		}*/
			include('db.php');
			$query = "select * from users where state like '".$states."'";
			$result = mysql_query($query) or die(mysql_error());

			$num = mysql_num_rows($result);

			if ($num == 0) {
				echo "No match found!";
			}
			else {
				$i=1;
				echo "<table width='450' align='center'";
				while ($row = mysql_fetch_array($result)) {
					echo "<tr><td>".$i++.". <a href='members.php?act=more_info&id=".$row["id"]."' title='Click for details on ".$row["first_name"]." ".$row["last_name"]."'>".$row["username"]."</a></td></tr";
				}
				echo "</table></br></br></br>";
			}
			mysql_free_result($result);
			mysql_close();
		}

[leatherback]

$query = "select * from users where state ='$states' ";

[codegirl42]

It's echoing no match found when there IS a match.

[leatherback]

Echo the query, and check whether what you think is passed to the database, is actually what it should be looking for.

Post here: the querystring in PhP, and the echoed querystring.

[codegirl42]

echo "$query";

select * from users where state ='Rhode Island'

which is weird because even when i select "California'...it echos this....

[codegirl42]

and RhodeIsland is the last entry in the state table ...FYI

[leatherback]

No it is not.

In your data retrieval from the database you use the same variable name.

Be careful in naming, and get some convention.

e.g. use $selected_state for the input, and $this_state for the currently showing, and $states_list for all states.

[codegirl42]

you lost me just that quickly...

that table in the database is "state".

the only time "state" is used is here:

<select name='state'>";

and

$query = "select * from users where state ='$states' ";

[leatherback]

:
$states = trim($_GET["states"]); <---
AND:

$query = "SELECT * FROM state";
$result = mysql_query($query);
while ($data = mysql_fetch_array($result)) {

$states = $data['name']; // <--- This is where the harm gets done

and..

$query = "select * from users where state = '$states' "; <---

[codegirl42]

but that's STATES with an "S"...

[codegirl42]

maybe i'm missing something....

you're saying that EVEN IF, there is an "S" at the end...the query statement will still "confuse" things?

[codegirl42]

i went ahead and changed all of the stateS to state_list

but that didnt solve anything....

[codegirl42]

This did it

elseif (isset($GET["act"]) && $GET["act"]=="search") {
$keyword = trim($GET["keyword"]);
$states = trim($GET["states"]);
echo "
<table width='450' align='center'><form action='members.php' method='get'>
<input type='hidden' name='act' value='search'>
<tr><td>Keyword<input type='text' name='keyword'></td><td><input type='submit' value='Search'></td></tr>
<tr><td>State:</td><td>
<select name='state'>";
$query = "SELECT * FROM state";
$result = mysql_query($query);
while ($row = mysql_fetch_array($result)) {
$states = $row['name'];
echo "<option name='state' value='$states'";
echo ">$states</option>";
}
echo "</select></td></tr>";

echo "</form></table></br></br></br>
";

/if ($keyword=="") {
echo "Invalid keyword";
}/
include('db.php');
$query = "select * from users where state ='$state'";

[leatherback]

Hi Codegirl,

I have the suspicion that uyou have register_globals set to on. Otherwise the code you posted WON't work properly. Because you are retrieving $states from the $_GET array:

$states = trim($_GET["states"]);

I pointed out the problem to you. You overwrite the $states variable in your query. The reason your fix works, is because now a different value holds the selected value, namely, $state. Still, I recommend you kepping a less similar coding convention. It will safe you a lot of headaches.

J.

PS: Please remember I was trying to help you write better code. you came for help. Don't be arrogant, and look at what I wrote. It will safe you a lot of coding trouble