Display Errors

treeleaf20

All:
I have the following set of queries:

$queryid = "SELECT user_id from users where user_name='$_SESSION[Username]'";
$resultid = mysql_query($queryid);
$userid = mysql_fetch_array($resultid);
$userid = $userid[0];

$querysub = "SELECT subject from mail where user_id='$userid' AND status='Unread' OR status='Read' ORDER BY message_id DESC LIMIT 0, 14";
$resultsub = mysql_query($querysub);
$querydate = "SELECT date from mail where user_id='$userid' AND status='Unread' OR status='Read' ORDER BY message_id DESC LIMIT 0, 14";
$resultdate = mysql_query($querydate);
$querystatus = "SELECT status from mail where user_id='$userid' AND status='Unread' OR status='Read' ORDER BY message_id DESC LIMIT 0, 14";
$resultstatus = mysql_query($querystatus);
$querymailid = "SELECT message_id from mail where user_id='$userid' AND status='Unread' OR status='Read' ORDER BY message_id DESC LIMIT 0, 14";
$resultmailid = mysql_query($querymailid);
$queryfrom = "SELECT sentbyname from mail where user_id='$userid' AND status='Unread' OR status='Read' ORDER BY message_id DESC LIMIT 0, 14";
$resultfrom = mysql_query($queryfrom);
$resultfrom = mysql_query($queryfrom);
$queryfromfriend = "SELECT friend_id from mail where user_id='$userid' AND status='Unread' OR status='Read' ORDER BY message_id DESC LIMIT 0, 14";
$resultfriendid = mysql_query($queryfromfriend);
$friendid = mysql_fetch_array($resultfriendid);
$friendid = $friendid[0];
$querypic = "SELECT users.pic FROM mail, users WHERE users.user_id = mail.friend_id AND mail.friend_id = '$friendid'";
$query = "SELECT * from mail where user_id = '$userid' AND status='Unread' OR status='Read' ORDER BY message_id DESC LIMIT 0, 14";
$result = mysql_query($query) or die("select failed");

To display these I then have the following code:

if (mysql_num_rows($result) > 0) {			
for ($j = 0; $j<mysql_num_rows($result); $j++) {
echo "<tr valign=\"top\">";
echo "<td width=62 bgcolor=\"E8F1FA\"><input type=\"checkbox\" name=\"column[]\" value=\"".mysql_result($resultmailid,$j)."\"></td>";
echo "<td width=104 bgcolor=\"E8F1FA\">";
echo "<span class=\"text\">". mysql_result($resultdate,$j) ."</span>";
echo "</td>";
echo "<td width=362 bgcolor=\"E8F1FA\">";
echo "<table width=\"150\" border=\"0\" cellspacing=\"0\" cellpadding=\"0\">";
echo "<tr><td>";
echo "<a href=\"../profile/viewprofile.php?id=" . mysql_result($resultfriendid,$j) . "\">";
echo "<img src=\"http://www.website.com/upload/images/".mysql_result($resultpic, $j). "\" width=\"75\" height=\"75\">";																		   

echo "</a></td>";
echo "<td><span class=\"text\"><a href=\"../profile/viewprofile.php?id=" . mysql_result($resultfriendid,$j) . "\">" . mysql_result($resultfrom,$j) . "</a></span>";
echo "<br><DIV style=\"width:80px;height:20px;\"></div>";
echo "</td></tr>";
echo "</table>";
echo "</td>";
echo "<td width=108 bgcolor=\"E8F1FA\">";
echo "".mysql_result($resultstatus,$j)."";
echo "</td>";
echo "<td width=495 bgcolor=\"E8F1FA\"><a class=\"mailtext\" href=\"readmessage.php?id=" . mysql_result($resultmailid,$j) . "\">" . mysql_result($resultsub,$j) . "</a></td>";
echo "</tr>";				
}		
}

This code works good if I'm only trying to view one row, when there is more then one row it gives me the error: Warning: mysql_result(): Unable to jump to row 1 on MySQL result index 15 in /home/website/public_html/mail/getmail.php on line 294.

Line 294 is this one:

echo "<img src=\"http://www.webiste.com/upload/images/".mysql_result($resultpic, $j). "\" width=\"75\" height=\"75\">";

Can someone please help me fix this. The first row will display good and then the second row I get that error. Please help!

Thanks

justsomeone

I haven't used the mysql_result() function before, but the manual suggests that the first parameter should be a result set, and the second should be a row number.

string mysql_result ( resource result, int row [, mixed field] )

$resultpic isn't your resultset, $result is.

so shouldn't you be using something like mysql_result ($result, $j, N), where N is the field number you want to display? eg if you want to display the first field in the row, use
mysql_result($result, $j, 0)

TheDefender

Whoa treeleaf20, why are you querying the DB so much? Why not combine all of your fields into one query?!?

$query = "SELECT * from mail where user_id='$userid' AND status='Unread' OR status='Read' ORDER BY message_id DESC LIMIT 0, 14"; 
$result = mysql_query($query);

while($resultset = mysql_fetch_array($result)) {
echo $resultset['subject']." ".$resultset['date']." ".$resultset['status']; //Etc...  Build your table around your data.
}

One call to the database... And you can avoid the hassles of trying to output in a for loop like you're trying to do.

Post back if you need more help restructuring your code.

Oh, one other thing: Since you are storing the UserName in the session, why not store the User_ID aas well? That way, you don't have to query the DB to get the User_ID later...

That's my 2 cents worth. Don't spend it all in one place though. 😉

treeleaf20

If you could help restructure my code I would greatly appreciate it, this the only way I know how to do things. I like your suggestion about the UserID as well and storing that as I session I will take care of that. If you could assist in helping me restrcuture the code that would be greatly appreciated. I never used a while loop in PHP before.

Thanks in advance.

TheDefender

<?php
$query = "SELECT * from mail where user_id='$userid' AND status='Unread' OR status='Read' ORDER BY message_id DESC LIMIT 0, 14";  

$result = mysql_query($query); 

echo "<table>";
while($resultset = mysql_fetch_array($result)) { 
echo "<tr valign=\"top\">"; 
echo "<td width=62 bgcolor=\"E8F1FA\"><input type=\"checkbox\" name=\"column[]\" value=\"". resultset['mailid'] ."\"></td>"; 
echo "<td width=104 bgcolor=\"E8F1FA\">"; 
echo "<span class=\"text\">". resultset['date'] ."</span>"; 
echo "</td>"; 
echo "<td width=362 bgcolor=\"E8F1FA\">"; 
echo "<table width=\"150\" border=\"0\" cellspacing=\"0\" cellpadding=\"0\">"; 
echo "<tr><td>"; 
echo "<a href=\"../profile/viewprofile.php?id=" . resultset['friend'] . "\">"; 
echo "<img src=\"http://www.website.com/upload/images/". resultset['pic']. "\" width=\"75\" height=\"75\">";                                                                            

echo "</a></td>"; 
echo "<td><span class=\"text\"><a href=\"../profile/viewprofile.php?id=" . resultset['friend_id'] . "\">" . resultset['sentbyname'] . "</a></span>"; 
echo "<br><DIV style=\"width:80px;height:20px;\"></div>"; 
echo "</td></tr>"; 
echo "</table>"; 
echo "</td>"; 
echo "<td width=108 bgcolor=\"E8F1FA\">"; 
echo "". resultset['status'] .""; 
echo "</td>"; 
echo "<td width=495 bgcolor=\"E8F1FA\"><a class=\"mailtext\" href=\"readmessage.php?id=" . resultset['message_id'] . "\">" . resultset['subject'] . "</a></td>"; 
echo "</tr>";
}
echo </table>
?>

This should give you the idea. You'll have to tweak to get the friend and pic indexes, which will probably require an extra query or two, like you have, but you should be able to get it from here...

Jasp182

Also, you don't need to have so many successive echo statements. Try something like this instead:

while($resultset = mysql_fetch_array($result)) {  ?>

<tr valign="top">
<td width=62 bgcolor="E8F1FA"><input type="checkbox" name="column[]" value="<?=$resultset['mailid'];?>"></td>  

.
.
.
<? } ?>

treeleaf20

I have the following code from what you gave me.

$query = "SELECT * from mail where user_id='$_SESSION[Userid]' AND (status='Unread' OR status='Read') ORDER BY message_id DESC LIMIT 0, 14";  

$result = mysql_query($query); 

$queryfromfriend = "SELECT friend_id from mail where user_id='$_SESSION[Userid]' AND (status='Unread' OR status='Read') ORDER BY message_id DESC LIMIT 0, 14";
$resultfriendid = mysql_query($queryfromfriend);
$friendid = mysql_fetch_array($resultfriendid);
$friendid = $friendid[0];
$querypic = "SELECT users.pic FROM mail, users WHERE users.user_id = mail.friend_id AND mail.friend_id = '$friendid'"; 
$resultpic = mysql_query($querypic);
$resultsetpic = mysql_fetch_array($resultpic);
echo "<table>";
if (mysql_num_rows($result) > 0) { 
while($resultset = mysql_fetch_array($result)) {
while($resultsetpic = mysql_fetch_array($resultpic)) { 
echo "<tr valign=\"top\">"; 
echo "<td width=62 bgcolor=\"E8F1FA\"><input type=\"checkbox\" name=\"column[]\" value=\"". $resultset['message_id'] ."\"></td>"; 
echo "<td width=104 bgcolor=\"E8F1FA\">"; 
echo "<span class=\"text\">". $resultset['date'] ."</span>"; 
echo "</td>"; 
echo "<td width=362 bgcolor=\"E8F1FA\">"; 
echo "<table width=\"150\" border=\"0\" cellspacing=\"0\" cellpadding=\"0\">"; 
echo "<tr><td>"; 
echo "<img src=\"http://www.website.com/upload/images/". $resultsetpic['pic']. "\" width=\"75\" height=\"75\">";                                                                            

echo "</a></td>"; 
echo "<td><span class=\"text\"><a href=\"../profile/viewprofile.php?id=" . $resultset['friend_id'] . "\">" . $resultset['sentbyname'] . "</a></span>"; 
echo "<br><DIV style=\"width:80px;height:20px;\"></div>"; 
echo "</td></tr>"; 
echo "</table>"; 
echo "</td>"; 
echo "<td width=108 bgcolor=\"E8F1FA\">"; 
echo "". $resultset['status'] .""; 
echo "</td>"; 
echo "<td width=495 bgcolor=\"E8F1FA\"><a class=\"mailtext\" href=\"readmessage.php?id=" . $resultset['message_id'] . "\">" . $resultset['subject'] . "</a></td>"; 
echo "</tr>";
}
}
}

The problem is that I can't get the pics to display yet. A user can have more then one piece of mail from the same user so the while loop for the picture will only run twice because of the distinct friend_id's but it needs to do it for each piece of mail. I just can't get the pics to display. Can someone please help I would really appreicate it.

Thanks!