Upload script corrupts .doc!

mitchm

So I have a file upload script which works great with .gif, .jpg and .txt files. I've tried storing the files on server and as a BLOB (longblob & mediumblob), but I get the same result both times. When i try to fetch/download the file stored on the server, the file downloads correctly(correct mime/ext), but when WORD tries to open the .doc, it syas it can not and fails.

I'm not sure if the error is when i upload the file or when i download the file, but something is going on.

I've seen people have the same problem, but no one knows how to fix it.

please help.

oh, and I'm on a linux server.

this is the code i use to upload. my html form is setup correctly, and as far as the 'addslashes' goes, I tried mysql_escape_string, and both with the same result.

$tempFile = fopen($_FILES['resume']['tmp_name'], "rb");
$data = (fread($tempFile, fileSize($_FILES['resume']['tmp_name'])));
fclose();

$data = addslashes($data);

nemonoman

don't add slashes.

mitchm

With all the special characters formatted in a word doc you have to or else mySQL will generate an error on insert.

nemonoman

Listen, be smart and learn from gentle advice what others have learned tje hard way: DON'T TRY TO STORE FILES in a database BLOB. The file is (apparently) already stored on the server -- why not just leave it there? Just keep the file name and info in the database.

mitchm

ok ok, maybe i didnt explain this clearly.

I originally tried to just store the file on the server, NOT in a BLOB. That didnt work. Everytime I would try and retrieve the file, it became corrupt. So, I decided to try to store it in a BLOB. same result.

I dont mind storing it as a file, i actually prefer it.

I'm asking for help, b/c I have no idea what the problem would be. Could it be a server configuration? I can post the original upload script (that stores it as a file) if that would help.

cyberlew15

to upload a wor doc just use this

<HTML>

<HEAD>

<TITLE> Example Upload Form upload.phtml </TITLE>

</HEAD>

<BODY>

<?php 

if ( $userfile ) 

{ 

@$res=copy($userfile,"$userfile_name"); 

if ( !$res ) 

print "Upload failed! \n"; 

else 

print "Upload of $userfile_name successful \n"; 

} 

?>

File to Upload

</FORM>

</BODY>

</HTML>

i got this from http://help.websiteos.com/support/uploading_a_file_with_php.htm after a similar problem with flash files in my own upload script also you can check to see if a file is uploaded through the

is_uploaded

you can also do multiple uploads through a for statement so that php generates the form to upload

mitchm

cyberlew15, thanks.

After some more testing, I notice that the file is stored on the server OK. the error must be caused when i prompt the user to download the file. I'll mess around with it some more and get back to you guys.

cyberlew15

oh yeah and you can also use this method to insert into a blob on a msql databse with no problems. yeas blobing files causes problems but only when ppl start faffing around creating intricate upload scripts i've never known anyone to have a problem blobbing files

mitchm

OK, this is the code i'm using to retrive the file. If i FTP into my account and download the file, its perfect, but when PHP prompts the user for download the .doc becomes corrupt.


//filename = long name (with path)
//file = base name

			if( file_exists( $filename ) ){
			  $size = filesize( $filename ); 
			  header("Content-Type: application/msword"); 
			  header("Content-Disposition: attachment; filename=$file"); 
			  $fh = readfile("$filename"); 
			  fpassthru($fh);
			  }

i've tried fopen, and setting the content-type to application/save, application/octet-stream, still same result.

these were the full headers i used, same result:

header("Pragma: public");
header("Expires: 0");
header("Cache-Control: must-revalidate, post-check=0, pre-check=0");
header("Cache-Control: private",false);
header("Content-Type: application/msword"); 
header("Content-Disposition: attachment; filename=$file"); 
header("Content-Transfer-Encoding: binary");
header("Content-Length: ".$size);

cyberlew15

stop doing this you do not need to use file headers I thought you were uploading it to a file now just do a header redirect to the file on your server. you may want to add some anti-leeching protocols to your site like an out.php check the HTTP_REFERER against allowed usage and output the file

mitchm

THANK YOU!

holy crap that worked. I have to know, why do errors get caused when you try and output the file with content headers?

cyberlew15

a lot of php is designed to be implemented in a linux environment for line spacing etceterra because linux and windows handle data differently and store it in different ways having php spit the file back to you with headers more than likely outputted for a different OS can wreak havoc with a file. As an analogy think of it this way the headers are like the visual representation of a file if you cannot see something how do you know what it is so if a file has no headers or toomany headers the server is functionally blind to what to do with that file

cyberlew15

if you just use this header it may work it's the only header needed

header("Content-Type: application/msword");

but i'm not recommending it if itaint broke why fix it