Was there an easier way???

[SJones]

Hi can someone look at this code and tell me if there was an easier way to go about this. -------
<?php
if (isset($GET)) {
if (strlen($size) > 0) {
$size = strtolower($GET['size']); // Changes the code to lower case
} else {
echo "You forgot to enter a size";
}
if (strlen($color) > 0) {
$color = strtolower($GET['color']); // Changes the code to lower case
} else {
echo "You forgot to choose a color!";
}
if (strlen($logo) > 0) {
$logo = strtolower($GET['logo']); // Changes the code to lower case
} else {
echo "You need to choose if you would like a logo on your bag";
}
if (strlen($voltage) > 0) {
$voltage = strtolower($_GET['voltage']); // Changes the code to lower case
} else {
echo "You did not choose the electrical voltage that you require";
}
} else {
header ('Location: http://www.rediheat.com/failure.php');
}
$product = $size . $color . $logo . $voltage;
switch ($product) {
case '16_inchredno120';
header ('Location: http://cwptechnologies.com/Merchant2/merchant.mvc?Screen=PROD&Product_Code=HP101&Category_Code=PDB');
break;
case '18_inchredno120';
header ('Location: http://cwptechnologies.com/Merchant2/merchant.mvc?Screen=PROD&Product_Code=HP102&Category_Code=PDB');
break;
case '16_inchredno240';
header ('Location: http://cwptechnologies.com/Merchant2/merchant.mvc?Screen=PROD&Product_Code=HP105&Category_Code=PDB');
break;
case '18_inchredno240';
header ('Location: http://cwptechnologies.com/Merchant2/merchant.mvc?Screen=PROD&Product_Code=HP106&Category_Code=PDB');
break;
case '16_inchredyes120';
header ('Location: http://cwptechnologies.com/Merchant2/merchant.mvc?Screen=PROD&Product_Code=HP103&Category_Code=PDB');
break;
case '18_inchredyes120';
header ('Location: http://cwptechnologies.com/Merchant2/merchant.mvc?Screen=PROD&Product_Code=HP104&Category_Code=PDB');
break;
case '16_inchredyes240';
header ('Location: http://cwptechnologies.com/Merchant2/merchant.mvc?Screen=PROD&Product_Code=HP108&Category_Code=PDB');
break;
case '18_inchredyes240';
header ('Location: http://cwptechnologies.com/Merchant2/merchant.mvc?Screen=PROD&Product_Code=HP109&Category_Code=PDB');
break;
case '16_inchblackno120';
header ('Location: http://cwptechnologies.com/Merchant2/merchant.mvc?Screen=PROD&Product_Code=HP113&Category_Code=PDB');
break;
case '18_inchblackno120';
header ('Location: http://cwptechnologies.com/Merchant2/merchant.mvc?Screen=PROD&Product_Code=HP112&Category_Code=PDB');
break;
case '16_inchblackno240';
header ('Location: http://cwptechnologies.com/Merchant2/merchant.mvc?Screen=PROD&Product_Code=HP115&Category_Code=PDB');
break;
case '18_inchbalckno240';
header ('Location: http://cwptechnologies.com/Merchant2/merchant.mvc?Screen=PROD&Product_Code=HP117&Category_Code=PDB');
case '16_inchblackyes120';
header ('Location: http://cwptechnologies.com/Merchant2/merchant.mvc?Screen=PROD&Product_Code=HP114&Category_Code=PDB');
break;
case '18_inchblackyes120';
header ('Location: http://cwptechnologies.com/Merchant2/merchant.mvc?Screen=PROD&Product_Code=HP110&Category_Code=PDB');
break;
case '16_inchblackyes240';
header ('Location: http://cwptechnologies.com/Merchant2/merchant.mvc?Screen=PROD&Product_Code=HP116&Category_Code=PDB');
break;
case '18_inchblackyes240';
header ('Location: http://cwptechnologies.com/Merchant2/merchant.mvc?Screen=PROD&Product_Code=HP118&Category_Code=PDB');
break;
case '16_inchgreenno120';
header ('Location: http://cwptechnologies.com/Merchant2/merchant.mvc?Screen=PROD&Product_Code=HP119&Category_Code=PDB');
break;
case '18_inchgreenno120';
header ('Location: http://cwptechnologies.com/Merchant2/merchant.mvc?Screen=PROD&Product_Code=HP121&Category_Code=PDB');
break;
case '16_inchgreenno240';
echo "Not Available - please make another choice";
break;
case '18_inchgreenno240';
echo "Not Available - please make another choice";
break;
case '16_inchgreenyes120';
header ('Location: http://cwptechnologies.com/Merchant2/merchant.mvc?Screen=PROD&Product_Code=HP120&Category_Code=PDB');
break;
case '18_inchgreenyes120';
header ('Location: http://cwptechnologies.com/Merchant2/merchant.mvc?Screen=PROD&Product_Code=HP122&Category_Code=PDB');
break;
case '16_inchgreenyes240';
echo "Not Available - please make another choice";
break;
case '18_inchgreenyes240';
echo "Not Available - please make another choice";
break;
}
?>

[bbreslauer]

Two things:

1) You could create a function that would do the following, and then just pass it the variable name:

f (strlen($size) > 0) {
$size = strtolower($_GET['size']); // Changes the code to lower case
} else {
echo "You forgot to enter a size";
}

2) For the case statements, if you have multiple cases which will always have the same output (i.e. echo "Not Available..."), you can group them all together, as follows. They will fall through until they find a break.

case '16_inchgreenno240';
case '18_inchgreenno240';
case '16_inchgreenyes240';
case '18_inchgreenyes240';
echo "Not Available - please make another choice";
break; 

Also, this isn't something to make this easier, but I would be carful to just check to see if the $GET variable is set. The user could add ?a to the URL, and the $GET variable would be set, even though that's probably not what you'd want.