foreach not showing me all array elements

laurus

Hello,

I am simply trying to query a database then spit the results on the screen using foreach. I use PHP Version 5.0.4 on apache2 with winxp

My query brings back 18 lines (user_id) but in my foreach statement it only shows the first record 2x!!

$select_distinct = mysql_query("select distinct submissions.user_id from submissions, talent where submissions.talent_id = talent.talent_id and submissions.status='1' order by submissions.user_id desc");

	$results = mysql_fetch_array($select_distinct);
	$found3 = mysql_num_rows($select_distinct);

print "<p>".$found3." records found</p>";

if (is_array($results)) {print "<p>this is definitely an array</p>";}

foreach ($results as $value)
{
echo "Value: " . $value . "<br />";
}

the screen shows;

18 records found

this is definitely an array

Value: 1676
Value: 1676

Help would sure be appreciated. I would like to see al 18 user_id's

thanks!!

toplay

You need to keep repeating the fetch (a loop) in order to get all the rows. Example:

// Connect to MySQL server first – You can use variables instead of these literals
$db = mysql_connect('localhost', 'username', 'password');
if (!$db) {
    echo 'Could not connect to MySQL server. <br />Error # ', mysql_errno(), ' Error msg: ', mysql_error();
    exit;
}

// Select the database you want to use – You can use a variable here too instead
if (!mysql_select_db('DBname', $db)) {   // Did selection fail?
    // Handle error
    echo 'DB Selection failed. <br />Error # ', mysql_errno(), ' Error msg: ', mysql_error();
    exit;
}

$sql = "select distinct submissions.user_id from submissions, talent where submissions.talent_id = talent.talent_id and submissions.status='1' order by submissions.user_id desc";
$result = mysql_query($sql, $db);
if (!$result) {
    // Handle error
    echo 'Query failed. SQL: ', $sql, '<br />Error # ', mysql_errno(), ' Error msg: ', mysql_error();
    exit;
}
// The while loop stops when there's no data left; it might not even go in loop
// and echo anything when there's no data returned on the first call to
// mysql_fetch_assoc()
while($row = mysql_fetch_assoc($result)) {  // Retrieve data until no more
    echo 'Value: ', $row['user_id'], '<br />';
}

laurus

Thank you!!!!! That gets me moving again.

Is there a 'guide' so I can see how to put code in an Iframe like you did (very nice for the viewing)? Is there a forum etiquette page?

toplay

laurus wrote:
Thank you!!!!! That gets me moving again.

Is there a 'guide' so I can see how to put code in an Iframe like you did (very nice for the viewing)? Is there a forum etiquette page?

You're welcome.

It's the vB code link under the "Posting Rules" in the bottom left of a page. Here's the link to the tags allowed:

http://www.phpbuilder.com/board/misc.php?do=bbcode

🙂