pagination with form

Simplecat

Hi
Does any one know this one?
Have a form on a html page which collects search criteria from user and searches mysql table. When form is submitted results of search are shown on a php page. which contains php database connection sql query code using Where clause. This all works well.
Have some pagination code on this php page, and when either Next or Previous links are clicked original search criteria is lost and the code just displays unfiltered results from database table, scrolling through the rows

So what is the php code for collecting data from forms and keeping that data on pages that use pagination Sessions, Get or Post have tried them all..
Have read all the tutorials but they all just describe pulling unfiltered data from a table

Have been wrestling with this one for ages
Here is what i have for the pagination links
// Build Page Number Hyperlinks
echo "<center>Select a Page<br />";

// Build Previous Link
if($page > 1){
$prev = ($page - 1);
echo '<a href="'.$SERVER['PHP_SELF'].'?page=' .$prev. '&new_location='.$GET['location'].'&new_price_range='.$GET['price_range'].'&new_property_type='.$GET['property_type'].'">prev</a>';

}

for($i = 1; $i <= $total_pages; $i++){
if(($page) == $i){
echo "$i ";
} else {
echo "<a href=\"".$_SERVER['PHP_SELF']."?page=$i\">$i</a> ";

}
}

// Build Next Link
if($page < $total_pages){
$next = ($page + 1);

echo '<a href="'.$SERVER['PHP_SELF'].'?page=' .$next. '&new_location='.$GET['location'].'&new_price_range='.$GET['price_range'].'&new_property_type='.$GET['property_type'].'">next</a>';
}
echo "</center>";
?>

vaaaska

You could store the information in the URL (references). Or, you could $_POST the data using some hidden form fields (be sure you turn your Prev/Next link in a submit).

From the code you show here (please put your code in PHP tags to make it easier to deal with also) I don't see where your query is getting the information when a person hits Prev or Next. I'm sure you have something in there, but I don't see it here.

Take it one step at a time...pagination is complex but if you break it down to one problem at a time you'll get it worked out.

Simplecat

Thanks
Not sure how to store the info in the URL references

could you give me an example with a snippet of code

Sorry but i am new to all this

Your help is much appreciated

Thanks again

vaaaska

Bleh...why did I say 'references'? Sorry...rather tired today...more simple...but I think you already have this rolling...

echo '<a href="'.$_SERVER['PHP_SELF'].'?page=' .$next. '&new_location='.$_GET['location'].'&new_price_range='.$_GET['price_range'].'&new_property_type='.$_GET['property_type'].'">next</a>';
}

Assuming you are validating your $_GET values then all should be ok. These values also need to be passed into your query (via the URL as you have it here). But since you are missing portions of your code, we don't really know what you are doing...

Simplecat

OK I am sending you the rest of my code
and thanks for your help with this

Here is the HTML page containing the form

<form name ="search" id ="search" action = buying_2.php method=GET>
<p align="left" class="style24">Search >>> </p>
<p align="left">
<span class="style8"> Location:</span>       

<select name=location value="<? if(isset($GET['location'])) echo $GET['location']; ?>" >
<option value=Canterbury>Canterbury
<option value=Whitstable>Whitstable
<option value=Herne Bay>Herne Bay
<option value=Faversham>Faversham

</select>
</p>
<p align="left"> <span class="style8">Price range:</span>   
<select name=price_range value="<? if(isset($GET['price_range'])) echo $GET['price_range']; ?>" >

<option value=£100,000 to £200,000>£100,000 to £200,000
<option value=£200,000 to £300,000>£200,000 to £300,000
<option value=£300,000 to £400,000>£300,000 to £400,000
<option value=£400,000 to £500,000>£400,000 to £500,000
<option value=£500,000 to £600,000>£500,000 to £600,000
<option value=£600,000 to £700,000>£600,000 to £700,000
<option value=£700,000 to £800,000>£700,000 to £800,000
<option value=£800,000 to £900,000>£800,000 to £900,000
<option value=£900,000 to £1000,000>£900,000 to £1000,000
<option value=£1000,000 and Above>1000,000 and Above

</select>
 </p>
<p align="left">
<span class="style8">Property type:</span> 
<select name=property_type value="<? if(isset($GET['property_type'])) echo $GET['property_type']; ?>">
<option value=House>House
<option value=Flat>Flat
<option value=Rented>Rented

</select>
 
<input name="Submit" type = submit value = "Search" tabindex="3" >
</p>
<p align="left"> </p>
</span>
</form></td>

Here is the php page that collects user data from the form on the html page

<?php
include("dbinfo_2.inc.php");

// Connect to contact database
mysql_connect(localhost,$username,$password);
@mysql_select_db($database) or die( "Unable to select database");

// create variables to hold users input from form
$new_location = $GET['location'];
$new_price_range = $GET['price_range'];
$new_property_type = $_GET['property_type'];

if ($new_location=="")
{
$new_location='%';
}

if ($new_price_range=="")
{
$new_price_range='%';
}

if ($new_property_type=="")
{
$new_property_type='%';
}

// If current page number, use it
// if not, set one!

if(!isset($GET['page'])){
$page = 1;
} else {
$page = $GET['page'];
}

// Define the number of results per page
$max_results =4;

// Figure out the limit for the query based
// on the current page number.
$from = (($page * $max_results) - $max_results);

// Perform MySQL query on only the current page number's results
$result = mysql_query ("SELECT * FROM sellers_properties WHERE location LIKE '$new_location%' AND price_range LIKE '$new_price_range%' AND property_type LIKE '$new_property_type%' LIMIT $from, $max_results");

// Find out how total rows for query
$total_results = mysql_result(mysql_query("SELECT COUNT(*) as Num FROM sellers_properties WHERE location LIKE '$new_location%' AND price_range LIKE '$new_price_range%' AND property_type LIKE '$new_property_type%'"),0);
?>

<?
if ($row=mysql_fetch_array($result)){
do{

//here is all my formatted data to show results

// Space between tables
//print("<p>");

}
while ($row = mysql_fetch_array($result));

}
// Let user know if no matching data found
/

else print "<script>document.location.href='no_results.htm'</script>";
//I know the above should use Header location instead of javascript

// Figure out the total number of results in DB:
//$total_results = mysql_result(mysql_query("SELECT COUNT(*) as Num FROM sellers_properties WHERE location LIKE '$new_location%' AND price_range LIKE '$new_price_range%' AND property_type LIKE '$new_property_type%'"),0);

// Figure out the total number of pages. Always round up using ceil()
$total_pages = ceil($total_results / $max_results);

//Have tested all of above and works fine truble starts below...

// Build Page Number Hyperlinks
echo "<center>Select a Page<br />";

// Build Previous Link
if($page > 1){
$prev = ($page - 1);
// echo "<a href=\"".$SERVER['PHP_SELF']."?page=$prev\">Previous</a> ";
echo '<a href="'.$SERVER['PHP_SELF'].'?page=' .$prev. '&new_location='.$GET['location'].'&new_price_range='.$GET['price_range'].'&new_property_type='.$GET['property_type'].'">prev</a>';
//echo'<a href="buying_2.php?page='.$prev.'&new_location='.$GET['location'].'&new_price_range='.$GET['price_range'].'&new_property_type='.$GET['property_type'].'">PREVIOUS</a> ';

}

for($i = 1; $i <= $total_pages; $i++){
if(($page) == $i){
echo "$i ";
} else {
echo "<a href=\"".$_SERVER['PHP_SELF']."?page=$i\">$i</a> ";
// echo '<a href="buying_2.php?page='.$i.$new_location, $new_price_range, $new_property_type.'">$i</a>';

}
}

// Build Next Link
if($page < $total_pages){
$next = ($page + 1);
// echo "<a href=\"".$SERVER['PHP_SELF']."?page=$next\">Next>></a>";
echo '<a href="'.$SERVER['PHP_SELF'].'?page=' .$next. '&new_location='.$GET['location'].'&new_price_range='.$GET['price_range'].'&new_property_type='.$GET['property_type'].'">next</a>';
//echo'<a href="buying_2.php?page='.$prev.'&new_location='.$GET['location'].'&new_price_range='.$GET['price_range'].'&new_property_type='.$GET['property_type'].'">NEXT</a> ';
}
echo "</center>";
?>

Hope this helps

Your help is much appreciated

Simplecat

vaaaska

Simple cat...how about putting that in PHP tags as I mentioned earlier. This is ROUGH on the eyes...

Simplecat

Sorry

Here we go

<form name ="search" id ="search" action = buying_2.php method=GET>
<p align="left" class="style24">Search >>> </p>
<p align="left">
<span class="style8"> Location:</span>       

<select name=location value

="<? if(isset($_GET['location'])) echo $_GET['location']; ?>" >

<option value=Canterbury>Canterbury
<option value=Whitstable>Whitstable
<option value=Herne Bay>Herne Bay
<option value=Faversham>Faversham

</select>
</p>
<p align="left"> <span class="style8">Price range:</span>   
<select name=price_range value

="<? if(isset($_GET['price_range'])) echo $_GET['price_range']; ?>" >

</select>
 </p>
<p align="left">
<span class="style8">Property type:</span> 
<select name=property_type value

="<? if(isset($_GET['property_type'])) echo $_GET['property_type']; ?>">

<option value=House>House
<option value=Flat>Flat
<option value=Rented>Rented

</select>
 
<input name="Submit" type = submit value = "Search" tabindex="3" >
</p>
<p align="left"> </p>
</span>
</form></td>

Here is the php page that collects user data from the form on the html page

<?php 
include("dbinfo_2.inc.php"); 


// Connect to contact database 
mysql_connect(localhost,$username,$password); 
@mysql_select_db($database) or die( "Unable to select database"); 

// create variables to hold users input from form 
$new_location = $_GET['location']; 
$new_price_range = $_GET['price_range']; 
$new_property_type = $_GET['property_type']; 

if ($new_location=="") 
{ 
$new_location='%'; 
} 

if ($new_price_range=="") 
{ 
$new_price_range='%'; 
} 

if ($new_property_type=="") 
{ 
$new_property_type='%'; 
} 

// If current page number, use it 
// if not, set one! 

if(!isset($_GET['page'])){ 
$page = 1; 
} else { 
$page = $_GET['page']; 
} 

// Define the number of results per page 
$max_results =4; 

// Figure out the limit for the query based 
// on the current page number. 
$from = (($page * $max_results) - $max_results); 

// Perform MySQL query on only the current page number's results 

$result = mysql_query ("SELECT * FROM sellers_properties WHERE location LIKE '$new_location%' AND price_range LIKE '$new_price_range%' AND property_type LIKE '$new_property_type%' LIMIT $from, $max_results"); 

$total_results = mysql_result(mysql_query("SELECT COUNT(*) as Num FROM sellers_properties WHERE location LIKE '$new_location%' AND price_range LIKE '$new_price_range%' AND property_type LIKE '$new_property_type%'"),0); 
?> 


<? 
if ($row=mysql_fetch_array($result)){ 
do{ 

?> 
//here is all my formatted data to show results 

<? 

// Space between tables 
//print("<p>"); 

} 
while ($row = mysql_fetch_array($result)); 

} 
// Let user know if no matching data found 
//else {print "Sorry no records found";}  else print "<script>document.location.href='no_results.htm'</script>"; 


// Figure out the total number of results in DB:  //$total_results = mysql_result(mysql_query("SELECT COUNT(*) as Num FROM sellers_properties WHERE location LIKE '$new_location%' AND price_range LIKE '$new_price_range%' AND property_type LIKE '$new_property_type%'"),0); 

// Figure out the total number of pages. Always round up using ceil() 
$total_pages = ceil($total_results / $max_results); 

// Build Page Number Hyperlinks 
echo "<center>Select a Page<br />"; 

// Build Previous Link 
if($page > 1){ 
$prev = ($page - 1); 
// echo "<a href=\"".$_SERVER['PHP_SELF']."?page=$prev\">Previous</a> "; 

echo '<a href="'.$_SERVER['PHP_SELF'].'?page=' .$prev. '&new_location='.$_GET['location'].'&new_price_range='.$_GET['price_range'].'&new_property_type='.$_GET['property_type'].'">prev</a>'; 
//echo'<a href="buying_2.php?page='.$prev.'&new_location='.$_GET['location'].'&new_price_range='.$_GET['price_range'].'&new_property_type='.$_GET['property_type'].'">PREVIOUS</a> '; 


} 



for($i = 1; $i <= $total_pages; $i++){ 
if(($page) == $i){ 
echo "$i "; 
} else { 
echo "<a href=\"".$_SERVER['PHP_SELF']."?page=$i\">$i</a> "; 
// echo '<a href="buying_2.php?page='.$i.$new_location, $new_price_range, $new_property_type.'">$i</a>'; 


} 
} 

// Build Next Link 
if($page < $total_pages){ 
$next = ($page + 1); 
// echo "<a href=\"".$_SERVER['PHP_SELF']."?page=$next\">Next>></a>"; 
echo '<a href="'.$_SERVER['PHP_SELF'].'?page=' .$next. '&new_location='.$_GET['location'].'&new_price_range='.$_GET['price_range'].'&new_property_type='.$_GET['property_type'].'">next</a>'; 
//echo'<a href="buying_2.php?page='.$prev.'&new_location='.$_GET['location'].'&new_price_range='.$_GET['price_range'].'&new_property_type='.$_GET['property_type'].'">NEXT</a> '; 
} 
echo "</center>"; 
 ?>

vaaaska

Ok, now we can try...first of all this line from your code:

echo '<a href="'.$_SERVER['PHP_SELF'].'?page=' .$next. '&new_location='.$_GET['location'].'&new_price_range='.$_GET['price_range'].'&new_property_type='.$_GET['property_type'].'">next</a>';

When your page builds does this URL actually get built? Viewing your page source will tell you...and also when you click the Prev or Next link this entire URL should appear in the address bar.

What do you see?

Simplecat

Yes Vaaaska

When the links are clicked you can see the entire URL in the address bar and it also shows the users choice from the form ie 'Canterbury for location' etc but when clicked the query is lost and the results are not filtered

So are you saying the URL is not built? cannot check cause at work

vaaaska

One step at a time...

Your code is rather messy. It doesn't appear that you are validating your $_GET[] values but I don't think I need to say more than that about it...

However, I do notice that you do this before your query:

// create variables to hold users input from form 
$new_location = $_GET['location'];  

$new_price_range = $_GET['price_range'];  

$new_property_type = $_GET['property_type'];  

if ($new_location=="")  

{  

$new_location='%';  

}  

if ($new_price_range=="")  

{  

$new_price_range='%';  

}  

if ($new_property_type=="")  

{  

$new_property_type='%';  

}  

// If current page number, use it 
// if not, set one! 

if(!isset($_GET['page'])){  

$page = 1;  

} else {  

$page = $_GET['page'];  

}

And then when you create your URL for Prev and Next you don't use your new variables...you go back to $_GET[]. I'm not sure that's the problem but it is an inconsistency you should look at...

You might use a ternary operator for these instead...shorter, but it's the same thing really (if/else statement). And be sure you use your new vars throughout. What you have above we can do in just four lines...

$new_location = (!isset($_GET['location'])) ? '%' : $_GET['location'];
$new_price_range = (!isset($_GET['price_range'])) ? '%' : $_GET['price_range'];
$new_property_type = (!isset($_GET['property_type'])) ? '%' : $_GET['property_type'];
$page = (!isset($_GET['page'])) ? 1 : $_GET['page'];

You might take the LIMIT off of your query to see if there are any other changes to the output...something doesn't seem right here...and/or use print_r() to print out the array of results...

Simplecat

Thanks will experiment though I,m not sure what syntax i would use for the url lines would it be as below seperating the vars with a comma?

echo '<a href="'.$_SERVER['PHP_SELF'].page=' .$next. '$new_location, $new_price_range, $new_property_type='">next</a>';

Thanks

vaaaska

Like this...I'm breaking it up for readiablity...

echo '<a href="' . $_SERVER['PHP_SELF'] . '?page=' . $next . 
'&new_location=' . $new_location . 
'&new_price_range=' . $new_price_range . 
'&new_property_type=' . $new_property_type . '">next</a>';

Simplecat

OK will try and let you know

Shall i also try replacing the .$_SERVER['PHP_SELF']. with the name of the page my script is on i.e. (buying_2.php ?)

Simplecat

Hi Vaaaska

Tried everything but still not working cant understand you see pagination everywhere like on this site

Any ideas

Grateful for any help

vaaaska

Simplecat...do you have a link I could look at? IM me if you want (it should be in my profile)...I'm sort of twiddling my thumbs until I leave on vacation...

vaaaska

Simplecat wrote:
OK will try and let you know

Shall i also try replacing the .$_SERVER['PHP_SELF']. with the name of the page my script is on i.e. (buying_2.php ?)

If you are going back to the same page after you click the link then it wouldn't matter...it seems to be working...the problem lies in how the query is being formed...

vaaaska

I took 5 mins to clean things up (sort of)...this is what you had originally with some very small changes (and some comments in here)...you need to focus on how to get your query to return the expected results...if you play with your variables (their defaults) and your query I'm pretty sure you will figure out why your query is not working...

Perhaps because I'm just being lazy I have gone through this code with a comb...just trying to focus on where I believe the problem is...

Good luck...

<?php

$new_location = (!isset($_GET['location'])) ? '' : $_GET['location']; 
$new_price_range = (!isset($_GET['price_range'])) ? '' : $_GET['price_range']; 
$new_property_type = (!isset($_GET['property_type'])) ? '' : $_GET['property_type']; 
$page = (!isset($_GET['page'])) ? 1 : $_GET['page'];

?>


<form name="search" id="search" action="buying_2.php" method="GET">

<p align="left" class="style24">Search &gt;&gt;&gt;</p>

<p align="left">

<span class="style8">&nbsp;Location:</span>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 

<select name="location" value="<?php echo $new_location; ?>" > 
<option value="Canterbury">Canterbury</option>
<option value="Whitstable">Whitstable</option>
<option value="Herne Bay">Herne Bay</option>
<option value="Faversham">Faversham</option>
</select>

</p>


<p align="left"> <span class="style8">Price range:</span>&nbsp;&nbsp;&nbsp; 
<select name="price_range" value="<?php echo $new_price_range; ?>" > 

<option value="&pound;100,000 to &pound;200,000">&pound;100,000 to &pound;200,000</option>
<option value="&pound;200,000 to &pound;300,000">&pound;200,000 to &pound;300,000</option>
<option value="&pound;300,000 to &pound;400,000">&pound;300,000 to &pound;400,000</option>
<option value="&pound;400,000 to &pound;500,000">&pound;400,000 to &pound;500,000</option>
<option value="&pound;500,000 to &pound;600,000">&pound;500,000 to &pound;600,000</option>
<option value="&pound;600,000 to &pound;700,000">&pound;600,000 to &pound;700,000</option>
<option value="&pound;700,000 to &pound;800,000">&pound;700,000 to &pound;800,000</option>
<option value="&pound;800,000 to &pound;900,000">&pound;800,000 to &pound;900,000</option>
<option value="&pound;900,000 to &pound;1000,000">&pound;900,000 to &pound;1000,000</option>
<option value="&pound;1000,000 and Above">1000,000 and Above</option>

</select>

&nbsp;</p>


<p align="left">

<span class="style8">Property type:</span>&nbsp;

<select name="property_type" value="<?php echo $new_property_type; ?>"> 
<option value="House">House</option>
<option value="Flat">Flat</option>
<option value="Rented">Rented</option>

</select>

&nbsp; 

<input name="Submit" type="submit" value="Search" tabindex="3" /> 
</p>

<p align="left">&nbsp;</p> 

</span> <!-- this doesn't need to be here, or does it? -->
</form>

</td> 


Here is the php page that collects user data from the form on the html page 

<?php 
include("dbinfo_2.inc.php"); 


// Connect to contact database 
mysql_connect(localhost,$username,$password); 
@mysql_select_db($database) or die ("Unable to select database"); 

// create variables to hold users input from form 
// we created them earliere


// Define the number of results per page 
$max_results =4; 

// Figure out the limit for the query based 
// on the current page number. 
$from = (($page * $max_results) - $max_results); 

// Perform MySQL query on only the current page number's results

// play with your query, this seems to be the problem.
// tear it down and then build it back up.
// plays with the vars you set at the top of the page
// and see if you can get predicted results.
// when you can, i bet the problem becomes clear...

$result = mysql_query ("SELECT * FROM sellers_properties WHERE location LIKE '$new_location%' AND price_range LIKE '$new_price_range%' AND property_type LIKE '$new_property_type%' LIMIT $from, $max_results"); 

// Find out how total rows for query
$total_results = mysql_result(mysql_query("SELECT COUNT(*) as Num FROM sellers_properties WHERE location LIKE '$new_location%' AND price_range LIKE '$new_price_range%' AND property_type LIKE '$new_property_type%'"),0);

?> 


<? 
if ($row = mysql_fetch_array($result)){ 
do{ 

?> 

//here is all my formatted data to show results 

<? 

// Space between tables 
//print("<p>"); 

} 
while ($row = mysql_fetch_array($result)); 

} 
// Let user know if no matching data found 
/ 

else print "<script>document.location.href='no_results.htm'</script>"; 
//I know the above should use Header location instead of javascript 

// Figure out the total number of results in DB: 
//$total_results = mysql_result(mysql_query("SELECT COUNT(*) as Num FROM sellers_properties WHERE location LIKE '$new_location%' AND price_range LIKE '$new_price_range%' AND property_type LIKE '$new_property_type%'"),0); 

// Figure out the total number of pages. Always round up using ceil() 
$total_pages = ceil($total_results / $max_results); 


//Have tested all of above and works fine truble starts below... 


// Build Page Number Hyperlinks 
echo "<center>Select a Page<br />"; 

// Build Previous Link 
if($page > 1){

$prev = ($page - 1);

// echo "<a href=\"".$_SERVER['PHP_SELF']."?page=$prev\">Previous</a> ";

echo '<a href="'.$_SERVER['PHP_SELF'].'?page=' .$prev. '&new_location='.$new_location.'&new_price_range='.$new_price_range.'&new_property_type='.$new_property_type.'">prev</a>'; 

//echo'<a href="buying_2.php?page='.$prev.'&new_location='.$_GET['location'].'&new_price_range='.$_GET['price_range'].'&new_property_type='.$_GET['property_type'].'">PREVIOUS</a> '; 


} 



for($i = 1; $i <= $total_pages; $i++){ 
if(($page) == $i){ 
echo "$i "; 
} else { 
echo "<a href=\"".$_SERVER['PHP_SELF']."?page=$i\">$i</a> "; 
// echo '<a href="buying_2.php?page='.$i.$new_location, $new_price_range, $new_property_type.'">$i</a>'; 


} 
} 

// Build Next Link 
if($page < $total_pages){ 

$next = ($page + 1); 

// echo "<a href=\"".$_SERVER['PHP_SELF']."?page=$next\">Next>></a>"; 

echo '<a href="'.$_SERVER['PHP_SELF'].'?page=' .$next. '&new_location='.$new_location.'&new_price_range='.$new_price_range.'&new_property_type='.$new_property_type.'">next</a>'; 

//echo'<a href="buying_2.php?page='.$prev.'&new_location='.$_GET['location'].'&new_price_range='.$_GET['price_range'].'&new_property_type='.$_GET['property_type'].'">NEXT</a> '; 
} 
echo "</center>"; 
?>