Updating a record?

[Confusion09]

Here's the code I'm using to add and delete stuff out of a table:

<?php if (isset($_GET['addjoke'])): // User wants to add a joke
?>

<form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
<label>Type your joke here:<br />
<textarea name="joketext" rows="10" cols="40">
</textarea></label><br />
<input type="submit" value="SUBMIT" />
</form>

<?php else: // Default page display

 // Connect to the database server
 $dbcnx = @mysql_connect('localhost', 'root', 'mypasswd');
 if (!$dbcnx) {
   exit('<p>Unable to connect to the ' .
       'database server at this time.</p>');
 }

 // Select the jokes database
 if (!@mysql_select_db('ijdb')) {
   exit('<p>Unable to locate the joke ' .
       'database at this time.</p>');
 }

 // If a joke has been submitted,
 // add it to the database.
 if (isset($_POST['joketext'])) {
   $joketext = $_POST['joketext'];
   $sql = "INSERT INTO joke SET
       joketext='$joketext',
       jokedate=CURDATE()";
   if (@mysql_query($sql)) {
     echo '<p>Your joke has been added.</p>';
   } else {
     echo '<p>Error adding submitted joke: ' .
         mysql_error() . '</p>';
   }
 }

 // If a joke has been deleted,
 // remove it from the database.
 if (isset($_GET['deletejoke'])) {
   $jokeid = $_GET['deletejoke'];
   $sql = "DELETE FROM joke
       WHERE id=$jokeid";
   if (@mysql_query($sql)) {
     echo '<p>The joke has been deleted.</p>';
   } else {
     echo '<p>Error deleting joke: ' .
         mysql_error() . '</p>';
   }
 }

 echo '<p> Here are all the jokes in our database: </p>';

 // Request the ID and text of all the jokes
 $result = @mysql_query('SELECT id, joketext FROM joke');
 if (!$result) {
   exit('<p>Error performing query: ' .
       mysql_error() . '</p>');
 }

 // Display the text of each joke in a paragraph
 // with a "Delete this joke" link next to each.
 while ($row = mysql_fetch_array($result)) {
   $jokeid = $row['id'];
   $joketext = $row['joketext'];
   echo '<p>' . $joketext .
       ' <a href="' . $_SERVER['PHP_SELF'] .
       '?deletejoke=' . $jokeid . '">' .
       'Delete this joke</a></p>';
 }

 // When clicked, this link will load this page
 // with the joke submission form displayed.
 echo '<p><a href="' . $_SERVER['PHP_SELF'] .
     '?addjoke=1">Add a Joke!</a></p>';

endif;
?>

Can someone add to this code and make it so that there's a link to "Edit" and it will take you to a form (with the data already in it) and you can update it from there (by just making the changes and hitting an Update button)?

BTW, I'd like this feature to work just like the add/delete ones (see how they use the same page).

Please let me know if you need any more information... I've been trying to accomplish this now for 2 days and I can't seem to make my own code work right.

Thank you.

[gufmn]

Welcome to the boards Confusion09.

A bit of advice. You're not likely going to get much response by simply asking if someone will do something for you. People are busy and have better things to do than spend time writing code for other people for free. If you have a specific question, post your code and ask it. There are many here (including myself) that are more than willing to lend a hand and help you work out the bugs.

Hope you don't think I'm being a jerk. I'm not trying to be. That's just the way it is around here. If you hang around long enough, you'll see just how helpful people can be. You just gotta be willing to put in the effort yourself. Besides, you learn more that way 🙂

[Confusion09]

gufmn wrote:

Welcome to the boards Confusion09.

A bit of advice. You're not likely going to get much response by simply asking if someone will do something for you. People are busy and have better things to do than spend time writing code for other people for free. If you have a specific question, post your code and ask it. There are many here (including myself) that are more than willing to lend a hand and help you work out the bugs.

Hope you don't think I'm being a jerk. I'm not trying to be. That's just the way it is around here. If you hang around long enough, you'll see just how helpful people can be. You just gotta be willing to put in the effort yourself. Besides, you learn more that way 🙂

Fair enough. I didn't mean to be lazy, I I've just tried so many different things. Here's what my code looks like now:

<?php if (isset($_GET['addjoke, editjoke'])): // User wants to add a joke
?>

<form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
<label>Type your joke here:<br />
<textarea name="joketext" rows="10" cols="40">
</textarea></label><br />
<input type="submit" value="SUBMIT" />
</form>

<form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
                                <label>Make your changes here:<br />
                                <?php print("<textarea name=\"joketext\" style=\"width: 90%\" rows=\"9\">joketext</textarea>"); ?>
                                </label>
                                <br />
                                <input name="submit" type="submit" value="SUBMIT" />
                              </form>

<?php else: // Default page display

 // Connect to the database server
 $dbcnx = @mysql_connect('localhost', 'root', 'mypasswd');
 if (!$dbcnx) {
   exit('<p>Unable to connect to the ' .
       'database server at this time.</p>');
 }

 // Select the jokes database
 if (!@mysql_select_db('ijdb')) {
   exit('<p>Unable to locate the joke ' .
       'database at this time.</p>');
 }

 // If a joke has been submitted,
 // add it to the database.
 if (isset($_POST['joketext'])) {
   $joketext = $_POST['joketext'];
   $sql = "INSERT INTO joke SET
       joketext='$joketext',
       jokedate=CURDATE()";
   if (@mysql_query($sql)) {
     echo '<p>Your joke has been added.</p>';
   } else {
     echo '<p>Error adding submitted joke: ' .
         mysql_error() . '</p>';
   }
 }

 // If a joke has been deleted,
 // remove it from the database.
 if (isset($_GET['deletejoke'])) {
   $jokeid = $_GET['deletejoke'];
   $sql = "DELETE FROM joke
       WHERE id=$jokeid";
   if (@mysql_query($sql)) {
     echo '<p>The joke has been deleted.</p>';
   } else {
     echo '<p>Error deleting joke: ' .
         mysql_error() . '</p>';
   }
 }

 echo '<p> Here are all the jokes in our database: </p>';

 // Request the ID and text of all the jokes
 $result = @mysql_query('SELECT id, joketext FROM joke');
 if (!$result) {
   exit('<p>Error performing query: ' .
       mysql_error() . '</p>');
 }

 // Display the text of each joke in a paragraph
// with a "Delete this joke" and "Edit Joke" link next to each.
while ($row = mysql_fetch_array($result)) {
   $jokeid = $row['id'];
   $joketext = $row['joketext'];
   echo '<p>' . $joketext .
       ' <a href="' . $_SERVER['PHP_SELF'] .
       '?deletejoke=' . $jokeid . '">' .
       'Delete this joke</a> | <a href="' . $_SERVER['PHP_SELF'] .
       '?editjoke=' . $jokeid . '">' .
       'Edit joke</a></p>';
}

if (isset($_GET['editjoke'])) {
   $jokeid = $_GET['editjoke'];
   $sql = "SELECT * FROM joke
       WHERE id=$jokeid";
}

 // When clicked, this link will load this page
 // with the joke submission form displayed.
 echo '<p><a href="' . $_SERVER['PHP_SELF'] .
     '?addjoke=1">Add a Joke!</a></p>';

endif;
?>

When you click the edit link, the edit form doens't come up. Can anyone tell me why? I have a feeling that it has to do with how my code is ordered by I honestly don't know or else I'd have it fixed 🙁.

Thanks again and sorry for my initial post.

[gufmn]

Ok,

The structure is really bad. Here's how I would set it up:

switch($_GET['action']){//this will look to see what the "action" variable in the url is
	case "add": {
	include('addjoke.php');
	break;
	}

case "edit": {
include('editjoke.php');
break;
}

case "delete": {
deleteJoke($_GET['jokeId']);
}//break; is not specified here. So php will continue 
//to the default action which is displayJokes() after 
//it runs deleteJoke()

default: {
	displayJokes();//display jokes will always execute unles
					//break; is specified in the above cases
}
}	

function deleteJoke($jokeId){
//run your delete query here using $jokeId
//displayJokes will then run because no break; was 
//used in the switch statement for the "delete" case.
}

function displayJokes(){
//Run your select * statement here and loop 
//through to display all jokes.
}

Then you set up your files to be included (addjoke.php and editjoke.php)

//addjoke.php
if(!isset($_POST['submit']){//check to see if form was NOT submitted

echo "<form building html here blah blah blah>";
// make sure the form action returns to this file. 
//So use $_SERVER['PHP_SELF'] or specify ?action=add in the url
}

else {//this means the form has been submitted
	//add new joke to database

header("Location yourpage.php");//redirect to wherever you want. Probably the main file without 
								//specifying action=whatever in the url. This will cause 
								//displayJokes() to run.
}

and...

//editjoke.php ~ This file will be very similar to addjoke.php

if(!isset($_POST['submit'] || !isset($_GET['jokeId'])){//check to see if form was NOT submitted 
														//and a jokeId was specified in the url

//run query here to grab data for $_GET['jokeId']

echo "<form building html here blah blah blah>";
// echo $row['jokeText']  and so on for the form field values"
// make sure the form action returns to this file. 
//So use $_SERVER['PHP_SELF'] or specify ?action=edit in the url
}

else {//this means the form has been submitted
	//run your update query

header("Location yourpage.php");//redirect to wherever you want. Probably the main file without 
								//specifying action=whatever in the url. This will cause 
								//displayJokes() to run.
}

It might seem like a lot to take in. But if you examine the code and the structure, it should make sense. It will also make editing easier having the diferent processes in separate files.

Good luck.

[maxpup979]

one word of warning. NEVER use delete in a link. EVER! especially if there is a chance that your site might be hit by a spider...whoops there goes all your content...🙂

[Confusion09]

Thanks for all that info. I'll try using it tonight and see if I can finally get this working (I doubt it) 🙂.

maxpup979 wrote:

one word of warning. NEVER use delete in a link. EVER! especially if there is a chance that your site might be hit by a spider...whoops there goes all your content...🙂

Oh, okay. Thanks for the tip!