Can add a new record, but fields don't populate

tryin_to_learn

Hi,

I have a php page that has a form that's supposed to gather data to add a new record to a database. What happens is that when I click on submit, it does add a new record, but none of the fields are populated (except the primary key, which is a field called id that auto-increments). Does anyone know what might be causing this? I'm pretty new to this so I'm thinking it may be something pretty easy that I'm overlooking. Here's the PHP part of the code:


<?php }


if( isset($_POST['submit']) ){ // Submit Button Has Been Pressed	

	// Instantiate MySQL Object
	$db = new MySQL(DBHOST,DBUSER,DBPASS,DBNAME);

	// Store Record
	$sql = "INSERT INTO professional SET prof_id='$id', name='$name', phone='$phone', address='$address', city='$city', state='$state', zip='$zip', fax='$fax', email='$email'";
	$result = $db->query($sql);


	if( !mysql_error() ){

		// No Error, Query Succeded
		// Set Success Message & Redirect
		session_start();
		$_SESSION['message'] = "Record Successfully Stored";
		header("Location:contactAdmin.php");

	}else{

		// Error: Storing File Meta Data Failed
		echo "<h2>Query Failed</h2>";
		echo mysql_error() . "<br /><br />";
		echo $sql . "<br />";

	} // End Query Success Check Conditional


}else{

	showForm();

} // End Conditional: Process or Show Form
?>

bretticus

Well, that INSERT...SET syntax is supported from MySQL versions 3.22.10 and on. However, if you are using a fairly recent version, that should work. However, you appear to be using a MySQL class instead of the actual intrinsic MySQL functions. In other words, the issue may lie in bad code in that class (which we do not have access to.) I would suggest maybe posting the class file or posing this question to the class author (unless you wrote it.)

TobyRT

"INSERT INTO professional SET prof_id='$id', name='$name', phone='$phone', address='$address', city='$city', state='$state', zip='$zip', fax='$fax', email='$email'"; 
        $result = $db->query($sql);

You use the variables $address, $name, $phone etc - but in that snippet you posted at the top, you never actually defined them?

e.g
$address=$POST['address']
$name=$POST['name']
$phone=$_POST['phone']

(where 'phone', 'address' and 'name' are the ids of input areas in the form)

Is that done elsewhere?

tryin_to_learn

Thanks, Toby -- that's exactly it. I hadn't defined them.

bretticus

Very intuiative Toby, way to read between the lines 😉.

I saw

<?php }

at the very top and figuered this was a snippet and assumed that either the variables were initialized or register_globals was on.