Incorrect syntax in sql select statement

thepaan

I have this piece that is not working right and I can't figure out what I am doing wrong. Anny assistance would be greatly appreciated.

<?php
$serverquery = "SELECT svr_name FROM svr";
$serverresult = mssql_query($serverquery);
while (list($server_name) = mssql_fetch_row($serverresult))
  {
  print "$server_name<br>";
  $server_table = svr_.strtolower($server_name);
  $drivequery = "SELECT drv_ltr FROM '$server_table'";
  $driveresult = mssql_query($drivequery);
  while (list($drive_letter) = mssql_fetch_row($driveresult))
    {
    print "$drive_letter<br>";
    }
  }
?>

This is the error I get

Warning: mssql_query() [function.mssql-query]: message: Line 1: Incorrect syntax near 'svr_server-01'. (severity 15) in C:\Inetpub\ConfigMgmt\phpinfo.php on line 30

Warning: mssql_query() [function.mssql-query]: Query failed in C:\Inetpub\ConfigMgmt\phpinfo.php on line 30

Warning: mssql_fetch_row(): supplied argument is not a valid MS SQL-result resource in C:\Inetpub\ConfigMgmt\phpinfo.php on line 31

This line (line 30):

$drivequery = "SELECT drv_ltr FROM '$server_table'";

is what it keeps hanging up. I tried removing the single quotes from the server_table variable and it changes the error to the following.

Warning: mssql_query() [function.mssql-query]: message: Line 1: Incorrect syntax near '-'. (severity 15) in C:\Inetpub\ConfigMgmt\phpinfo.php on line 30

Warning: mssql_query() [function.mssql-query]: Query failed in C:\Inetpub\ConfigMgmt\phpinfo.php on line 30

Warning: mssql_fetch_row(): supplied argument is not a valid MS SQL-result resource in C:\Inetpub\ConfigMgmt\phpinfo.php on line 31

I am kind of new to sql and php so I am hoping it is something silly.

bastien

this line

$drivequery = "SELECT drv_ltr FROM '$server_table'";

should not have the quotes around the table name

thepaan

Then its hanging on the dash in srv_server-01? That is a valid character right? I checked and there are no dashes anywhere in the the code at all. The only place a dash exists is in that server list table.

bastien

what part of

bastien wrote:
should not have the quotes around the table name

didn't you get?

Remove the SINGLE QUOTES

thepaan

Right, if you read my original post I showed the error with the single quotes and without the single quotes.

With the single qoutes it errors on the whole thing, without the single quotes it errors on the dash in the variable. that just seems odd to me. I have confirmed its the dash. I made a row in the server list table called server01 (no dashes in the name) and the corresponding server table and it executes properly.