form validation??

Nawn

This is the source code i have without the validation(it works)

<html>
<head><title>A PROGRAM TO GENERATE SPIRALS GALAXY</title></head>

<body>

//help button

<input type="button" value="Help" onClick="parent.location='helpform.php'"> <br /><br />

//user input

Enter the values<br /><br />

No of arms: <input type"text" name="arms"/> <br />
The type of galaxy 1=log, 2=linear, 3=hyp: <input type"text" name "kind"/> <br/>
Amplitude of the arms from the galaxy: <input type"text" name "amplitude"/> <br/>
The width of the arms: <input type"text" name "width"/> <br/>
The radius at which angle the galaxy has the pitchangle of i0: <input type"text" name "radpitch"/> <br/>
The pitchangle at radius radpitch: <input type"text" name "pitchagle"/> <br/>
The value of the (double)backshape: <input type"text" name "backshape"/> <br/>
The radius of the centre from the galaxy: <input type"text" name "backrad"/> <br/>
the value of the edgeshape: <input type"text" name "edgeshape"/> <br/>
The radius of the arms from the galaxy: <input type"text" name "armsrad"/> <br/>

//submit button

<input type="submit" value="Submit"><br />
</form>

</body>

</html>

this is the source code with the validation(it doesnt work)??

<html>
<head><title>A PROGRAM TO GENERATE SPIRALS GALAXY</title></head>

<body>

//help button

<input type="button" value="Help" onClick="parent.location='helpform.php'"> <br /><br />

//user input

Enter the values<br /><br />

//submit button

<input type="submit" value="Submit"><br />
</form>

//form validation

<?
if(!isset($width)) {
echo "test1"

}
else {
if(empty($width)){
echo "test2"

}
else{
echo "test3"
echo "<h3>Thank you!</h3>"
}

}
?>

</body>

</html>

when i added the validation, it couldnt work. why is that? and how do i make it work then?
im only doing it for one variable, i want to test it out first.

And another problem is why the comments can be seen in the webbrowser?

rikmoncur

Compare and contrast:

<html>
<head><title>A PROGRAM TO GENERATE SPIRALS GALAXY</title></head>

<body>

<input type="button" value="Help" onClick="parent.location='helpform.php'"> <br /><br />

Enter the values<br /><br />

No of arms: <input type"text" name="arms"/> <br />
The type of galaxy 1=log, 2=linear, 3=hyp: <input type"text" name="kind"/> <br/>
Amplitude of the arms from the galaxy: <input type"text" name "amplitude"/> <br/>
The width of the arms: <input type"text" name="width"/> <br/>
The radius at which angle the galaxy has the pitchangle of i0: <input type"text" name="radpitch"/> <br/>
The pitchangle at radius radpitch: <input type"text" name="pitchagle"/> <br/>
The value of the (double)backshape: <input type"text" name="backshape"/> <br/>
The radius of the centre from the galaxy: <input type"text" name="backrad"/> <br/>
the value of the edgeshape: <input type"text" name="edgeshape"/> <br/>
The radius of the arms from the galaxy: <input type"text" name="armsrad"/> <br/>

<input type="submit" value="Submit"><br />
</form>

<?
if(!isset($width)) {
echo "test1" ;

}
else {
if(empty($width)){
echo "test2" ;

}
else{
echo "test3";
echo "<h3>Thank you!</h3>" ;
}

}
?>

</body>
</html>

goldlikesnow

First You're short on semi colons (😉 and you have a wrong order of doing your if /else statements, try this:

<?php

if (!isset($width)) {
echo "test1";
} elseif (empty($width)){
echo "test2";
} else {
echo "test3";
echo "<h3>Thank you!</h3>";
}

Indent, Indent, Indent not with tabs but spaces!!!

Nawn

I decided to use another form of form validation. however i can't figure out whats the problem. it always give me a parse error in line 27.

============================================================================
<html>
<head><title>A PROGRAM TO GENERATE SPIRALS GALAXY</title></head>

<body>

<?php

$arms = $POST ['arms'];
$kind = $POST ['kind'];
$amplitude = $POST ['amplitude'];
$width = $POST ['width'];
$radpitch = $POST ['radpitch'];
$pitchangle = $POST ['pitchangle'];
$backshape = $POST ['backshape'];
$backrad = $POST ['backrad'];
$edgeshape = $POST ['edgeshape'];
$armsrad = $POST ['armsrad'];

$tried = ($_POST['tried'] == 'yes');

if($tried){
$validated = (!empty($arms) && !empty($kind) && !empty($amplitude) && !empty($width) && !empty($radpitch) && !empty($pitchangle) && !empty($backshape) && !empty($backrad) && !empty($edgeshape) && !empty($armsrad))

<p>Please fill out all the fields to continue.</p>

<?php
}

}

if($tried && $validated){
echo The item has been created.

}

<input type="button" value="Help" onClick="parent.location='helpform.php'"> <br /><br />

Enter the values<br /><br />

No of arms: <input type"text" name="arms"/>
<input type="button" value="?" onClick="parent.location='helpArms.php'"> <br /> <br />

The type of galaxy 1=log, 2=linear, 3=hyp: <input type"text" name "kind"/>
<input type="button" value="?" onClick="parent.location='helpKind.php'"> <br /> <br/>

Amplitude of the arms from the galaxy: <input type"text" name "amplitude"/>
<input type="button" value="?" onClick="parent.location='helpAmplitude.php'"> <br/> <br/>

The width of the arms: <input type"text" name "width"/>
<input type="button" value="?" onClick="parent.location='helpWidth.php'"> <br/> <br/>

The radius at which angle the galaxy has the pitchangle of i0: <input type"text" name "radpitch"/>
<input type="button" value="?" onClick="parent.location='helpRadpitch.php'"> <br /> <br/>

The pitchangle at radius radpitch: <input type"text" name "pitchagle"/>
<input type="button" value="?" onClick="parent.location='helpPitchangle.php'"> <br/> <br/>

The value of the (double)backshape: <input type"text" name "backshape"/>
<input type="button" value="?" onClick="parent.location='helpBackshape.php'"> <br/> <br/>

The radius of the centre from the galaxy: <input type"text" name "backrad"/>
<input type="button" value="?" onClick="parent.location='helpBackrad.php'"> <br/><br/>

The value of the edgeshape: <input type"text" name "edgeshape"/>
<input type="button" value="?" onClick="parent.location='helpEdgeshape.php'"> <br/> <br/>

The radius of the arms from the galaxy: <input type"text" name "armsrad"/>
<input type="button" value="?" onClick="parent.location='helpArmsrad.php'"> <br/><br/>

<input type="submit" value="<?php echo $tried? 'Continue' : 'Submit'; ?>"/><br />
</form>

</body>

</html>

One more thing why is "?>" after the "{" ? can i just place it before "if(!$validated)".

 if(!$validated){
?>

rikmoncur

change this:

<p>Please fill out all the fields to continue.</p>

<?php
}

}

if($tried && $validated){
echo The item has been created.

}

?>

to this:

?>
<p>Please fill out all the fields to continue.</p>

<?php

}

if($tried && $validated){
echo "The item has been created.";

}

Nawn

it still doesnt work

============================================================================
<html>
<head><title>A PROGRAM TO GENERATE SPIRALS GALAXY</title></head>

<body>

<?php

$tried = ($_POST['tried'] == 'yes');

 if(!$validated){

?>
<p>Please fill out all the fields to continue.</p>

<?php
}

}

if($tried && $validated){
echo '<p>The item has been created.</p>';